Re: [Openvpn-devel] [PATCH v2] Change the default --tmp-dir path to a more suitable path

2011-04-15 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 14/04/11 16:29, David Sommerseth wrote: > After all the discussions regarding the --tmp-dir patch [1], I have now > condenced everything into one single patch. The main change is that > the new win_get_tempdir() function is simplified by using

Re: [Openvpn-devel] [PATCH v2] Change the default --tmp-dir path to a more suitable path

2011-04-15 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 14/04/11 23:52, Peter Stuge wrote: > David Sommerseth wrote: >> In commit 4e1cc5f6dda22e9 the create_temp_filename() function was >> reviewed and hardened, which in the end renamed this function to >> create_temp_file() in commit 495e3cec5d156. >>

Re: [Openvpn-devel] [PATCH v2] Change the default --tmp-dir path to a more suitable path

2011-04-14 Thread Peter Stuge
David Sommerseth wrote: > In commit 4e1cc5f6dda22e9 the create_temp_filename() function was > reviewed and hardened, which in the end renamed this function to > create_temp_file() in commit 495e3cec5d156. > > With these changes it became more evident that OpenVPN needs a directory > where it can

Re: [Openvpn-devel] [PATCH v2] Change the default --tmp-dir path to a more suitable path

2011-04-14 Thread Gert Doering
Hi, On Thu, Apr 14, 2011 at 04:29:59PM +0200, David Sommerseth wrote: > This patch makes OpenVPN use a more suitable temproary directory by default, ACK. gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert

[Openvpn-devel] [PATCH v2] Change the default --tmp-dir path to a more suitable path

2011-04-14 Thread David Sommerseth
In commit 4e1cc5f6dda22e9 the create_temp_filename() function was reviewed and hardened, which in the end renamed this function to create_temp_file() in commit 495e3cec5d156. With these changes it became more evident that OpenVPN needs a directory where it can create temporary files. The

[Openvpn-devel] [PATCH v2] Change the default --tmp-dir path to a more suitable path

2011-04-14 Thread David Sommerseth
After all the discussions regarding the --tmp-dir patch [1], I have now condenced everything into one single patch. The main change is that the new win_get_tempdir() function is simplified by using GetTempPath() instead. On Windows the fallback solution, if GetTempPath() returns NULL, is now to