Re: [Openvpn-devel] [PATCH v2] More broadly enforce Allman style and braces-around-conditionals

2017-01-12 Thread Steffan Karger
On 12-01-17 02:14, David Sommerseth wrote: > So I tried to apply this one, but there are some odd issues now. Did > you apply your changes against the proper branch locally? Because a > couple of these ones are really odd. Oops, indeed, this one seems to be based on my local branch with lots

Re: [Openvpn-devel] [PATCH v2] More broadly enforce Allman style and braces-around-conditionals

2017-01-11 Thread David Sommerseth
On 23/12/16 23:40, Steffan Karger wrote: > We want { and } aligned, which means also adding a newline between each > for() and {, while() and {, etc. > > Also, we agreed to always use braces with conditionals. The previous > uncrustify config added these for if()s, now also add these for while()

Re: [Openvpn-devel] [PATCH v2] More broadly enforce Allman style and braces-around-conditionals

2016-12-24 Thread Gert Doering
Hi, On Fri, Dec 23, 2016 at 11:40:54PM +0100, Steffan Karger wrote: > This patch replaces the "Add nl_for_brace=add to uncrustify.conf" patch. > > v2: also add nl_do_brace=add and mod_full_brace_do=add > > dev-tools/uncrustify.conf | 8 + [..] > diff --git