Re: [Openvpn-devel] [PATCH v2] msvc: fix various level2 warnings

2020-06-25 Thread Lev Stipakov
Hi, > > -qsort(cipher_list, num_ciphers, sizeof(*cipher_list), cipher_name_cmp); > > +qsort((void *)cipher_list, num_ciphers, sizeof(*cipher_list), > > cipher_name_cmp); > > I find this one questionable. Qsort wants a void *, but every pointer type > should be convertible to void *,

Re: [Openvpn-devel] [PATCH v2] msvc: fix various level2 warnings

2020-06-25 Thread Arne Schwabe
>> @@ -1812,7 +1812,7 @@ do_open_tun(struct context *c) >> #ifdef _WIN32 >> /* store (hide) interactive service handle in tuntap_options */ >> c->c1.tuntap->options.msg_channel = c->options.msg_channel; >> -msg(D_ROUTE, "interactive service msg_channel=%u", (unsigned int) >>

Re: [Openvpn-devel] [PATCH v2] msvc: fix various level2 warnings

2020-06-25 Thread Gert Doering
Hi, On Thu, Jun 25, 2020 at 11:37:45AM +0300, Lev Stipakov wrote: > @@ -315,7 +315,7 @@ show_available_ciphers(void) > } > } > > -qsort(cipher_list, num_ciphers, sizeof(*cipher_list), cipher_name_cmp); > +qsort((void *)cipher_list, num_ciphers, sizeof(*cipher_list), >

[Openvpn-devel] [PATCH v2] msvc: fix various level2 warnings

2020-06-25 Thread Lev Stipakov
From: Lev Stipakov Also set warnings level to level2 and enable "treat warnings as errors" flag. Signed-off-by: Lev Stipakov --- src/compat/Debug.props | 1 - src/openvpn/block_dns.c | 3 --- src/openvpn/crypto_openssl.c | 2 +- src/openvpn/init.c | 2 +-