Re: [Openvpn-devel] [PATCH v2.3] Make error non-fatal while deleting address using netsh

2016-05-13 Thread Selva Nair
Hi, On Fri, May 13, 2016 at 5:55 AM, David Sommerseth < open...@sf.lists.topphemmelig.net> wrote: > On 13/05/16 04:40, Selva Nair wrote: > > Fixes Trac #71 (see comments 37 to 43) > > Nit pick on the commit message. Thanks for responding to the patch. > This message isn't really helpful.

Re: [Openvpn-devel] [PATCH v2.3] Make error non-fatal while deleting address using netsh

2016-05-13 Thread debbie10t
On 13/05/16 10:55, David Sommerseth wrote: I can recommend this blog post on this topic: Thanks David .. Excellent link ! Took me to this: http://git-scm.com/book I wonder if you could recommend a comparable "book on C" ? Cheerz

Re: [Openvpn-devel] [PATCH v2.3] Make error non-fatal while deleting address using netsh

2016-05-13 Thread David Sommerseth
On 13/05/16 04:40, Selva Nair wrote: > Fixes Trac #71 (see comments 37 to 43) Nit pick on the commit message. This message isn't really helpful. And it presumes that Trac will be available "forever". We should always ensure commit messages do not purely depend on external resources. I can

[Openvpn-devel] [PATCH v2.3] Make error non-fatal while deleting address using netsh

2016-05-13 Thread Selva Nair
Fixes Trac #71 (see comments 37 to 43) Signed-off-by: Selva Nair --- src/openvpn/tun.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index b70410d..11027dd 100644 --- a/src/openvpn/tun.c +++