Re: [Openvpn-devel] [PATCH v3] Don't throw fatal errors from verify_cert_export_cert()

2018-01-02 Thread Selva Nair
Hi, Thanks for v3. Looks good now. On Tue, Jan 2, 2018 at 5:52 PM, Steffan Karger wrote: > As with create_temp_file(), this function is called on client connects > and should not cause fatal errors when I/O (possibly temporarily) fails. > Fix this and the openssl

[Openvpn-devel] [PATCH v3] Don't throw fatal errors from verify_cert_export_cert()

2018-01-02 Thread Steffan Karger
As with create_temp_file(), this function is called on client connects and should not cause fatal errors when I/O (possibly temporarily) fails. Fix this and the openssl backend implementation of x509_write_pem() to no longer throw fatal errors. The callers of this function are already fixed in