On Sun, Jan 15, 2017 at 10:36:24AM +0100, Steffan Karger wrote:
> > diff --git a/src/openvpn/crypto.c b/src/openvpn/crypto.c
> > index 944f4c5..9a7745f 100644
> > --- a/src/openvpn/crypto.c
> > +++ b/src/openvpn/crypto.c
> > @@ -36,6 +36,7 @@
> > #include "crypto.h"
> > #include "error.h"
> >
Hi,
Thanks, I like each version better. Even though it adds more lines than
it removes, quite some of it is because of correcting wrapping and
adding useful comments. I think it really improves the readability of
the code. Some (hopefully final) minor comments still though:
On 14-01-17 17:30,
Carrying around the INLINE_TAG is not really efficient,
because it requires a strcmp() to be performed every
time we want to understand if the data is stored inline
or not.
Convert all the *_inline attributes to bool to make the
logic easier and checks more efficient.
Signed-off-by: Antonio
