Re: [Openvpn-devel] [PATCH v4 5/5] Normalise ncp-ciphers option and restrict it to 127 bytes

2020-02-17 Thread Lev Stipakov
Stared at the code, built and tested on MSVC and Ubuntu 18. Cipher "chacha20-POLY1305" correctly translated into "CHACHA20-POLY1305". Also (updated) unit tests passed. Acked-by: Lev Stipakov ___ Openvpn-devel mailing list

[Openvpn-devel] [PATCH v4 5/5] Normalise ncp-ciphers option and restrict it to 127 bytes

2020-02-17 Thread Arne Schwabe
In scenarios of mbed TLS vs OpenSSL we already normalise the ciphers that are send via the wire protocol via OCC to not have a mismatch warning between server and client. This is done by translate_cipher_name_from_openvpn. The same applies also to the ncp-ciphers list. Specifying non normalised