Re: [Openvpn-devel] English language? Re: [PATCH] Support non-ASCII characters in Windows tmp path

2013-12-09 Thread David Sommerseth 
On 04. des. 2013 13:22, Илья Шипицин wrote:
> I've looked through the code and I do not understand why do we need
> that temporary directory on windows platfrom ?
> anyone can explain idea behind initializing tmp-dir ? especially on
> Windows platform.

The client side most likely won't need --tmp-dir at all.  But if running
a server on Windows, OpenVPN will create some temporary files upon
client authentication.

See commit ca4c6d618d7 for more info.


-- 
kind regards,

David Sommerseth



signature.asc
Description: OpenPGP digital signature

Re: [Openvpn-devel] English language? Re: [PATCH] Support non-ASCII characters in Windows tmp path

2013-12-04 Thread Gert Doering 
Hi,

On Wed, Dec 04, 2013 at 06:22:04PM +0600,  ??? wrote:
> I've looked through the code and I do not understand why do we need
> that temporary directory on windows platfrom ?
> anyone can explain idea behind initializing tmp-dir ? especially on
> Windows platform.

tmp-dir is used to create, well, temporary files :-) - usually in the
context of a script being called (--client-connect) or a plugin.

I'm not sure if it is ever used in *client* mode, but since people do
run OpenVPN server instances on Windows, and server definitely needs
--tmp-dir for full functionality, it needs to work.

gert
-- 
USENET is *not* the non-clickable part of WWW!
   //www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025g...@net.informatik.tu-muenchen.de


pgpvoSmm2VX1w.pgp
Description: PGP signature

Re: [Openvpn-devel] English language? Re: [PATCH] Support non-ASCII characters in Windows tmp path

2013-12-04 Thread Илья Шипицин 
I've looked through the code and I do not understand why do we need
that temporary directory on windows platfrom ?
anyone can explain idea behind initializing tmp-dir ? especially on
Windows platform.

2013/12/4 Jonathan K. Bullard :
> On Wed, Dec 4, 2013 at 4:35 AM, Matthias Andree 
> wrote:
>>
>> Am 19.11.2013 18:36, schrieb Heiko Hund:
>> > +  msg (M_WARN, "Could not get temporary directory. Path is too
>> > long."
>> > +  "  Consider to use --tmp-dir");
>>
>> I think when touching the code, we ought to change all occurrences to
>> "Consider using --tmp-dir".
>>
>> Native speakers or linguists correct me, but since most usage references
>> I found were "consider + object" (object often a noun), the -ing form
>> would have to be used here.
>
>
> As a native English speaker, I agree; "Consider using --tmp-dir" is correct.
>
> (As an American, I have almost no formal knowledge of grammar or diction, so
> I can't cite why :-)
>
> --
> Sponsored by Intel(R) XDK
> Develop, test and display web and hybrid apps with a single code base.
> Download it for free now!
> http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
> ___
> Openvpn-devel mailing list
> Openvpn-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openvpn-devel
>

Re: [Openvpn-devel] English language? Re: [PATCH] Support non-ASCII characters in Windows tmp path

2013-12-04 Thread Jonathan K. Bullard 
On Wed, Dec 4, 2013 at 4:35 AM, Matthias Andree wrote:

> Am 19.11.2013 18:36, schrieb Heiko Hund:
> > +  msg (M_WARN, "Could not get temporary directory. Path is too
> long."
> > +  "  Consider to use --tmp-dir");
>
> I think when touching the code, we ought to change all occurrences to
> "Consider using --tmp-dir".
>
> Native speakers or linguists correct me, but since most usage references
> I found were "consider + object" (object often a noun), the -ing form
> would have to be used here.
>

As a native English speaker, I agree; "Consider using --tmp-dir" is correct.

(As an American, I have almost no formal knowledge of grammar or diction,
so I can't cite why :-)

[Openvpn-devel] English language? Re: [PATCH] Support non-ASCII characters in Windows tmp path

2013-12-04 Thread Matthias Andree 
Am 19.11.2013 18:36, schrieb Heiko Hund:
> Get the temporary path from the system as UCS-2 and convert it to
> UTF-8 and return that for internal use.
> 
> Signed-off-by: Heiko Hund 


> +  msg (M_WARN, "Could not find a suitable temporary directory."
> +  " (GetTempPath() failed).  Consider to use --tmp-dir");
> +  return NULL;
> +}
> +
> +  if (WideCharToMultiByte (CP_UTF8, 0, wtmpdir, -1, NULL, 0, NULL, NULL) > 
> sizeof (tmpdir))
> +{
> +  msg (M_WARN, "Could not get temporary directory. Path is too long."
> +  "  Consider to use --tmp-dir");

I think when touching the code, we ought to change all occurrences to
"Consider using --tmp-dir".

Native speakers or linguists correct me, but since most usage references
I found were "consider + object" (object often a noun), the -ing form
would have to be used here.

The closest I found is on
 which has "He
seriously considered changing careers." (under Examples), among lots of
"consider + noun" patterns.