Re: [Openvpn-devel] Unit testing in openvpn?

2016-04-23 Thread Steffan Karger
On Thu, Apr 21, 2016 at 9:12 AM, Jens wrote: > What are your thoughts? Should we add unit tests at all? What would be your > preferred way for dependency management. Please defer discussion on /which/ > unit testing framework to use until we have an agreement on the /if/ and > /how/ (just to pr

Re: [Openvpn-devel] Unit testing in openvpn?

2016-04-22 Thread Samuli Seppänen
Then there's the other codebase (3.x) which, when publicly released, might be a good/better candidate for writing unit tests. Please forgive my ignorance: Is this code base already a thing, and what is the time scale we are looking at (regarding “V3”)? The 3.x codebase is included in OpenV

Re: [Openvpn-devel] Unit testing in openvpn?

2016-04-21 Thread David Sommerseth
On 21/04/16 20:01, Gert Doering wrote: > Hi, > > On Thu, Apr 21, 2016 at 07:40:16PM +0200, Jens Neuhalfen wrote: >> The first candidate would be the U2F integration that I???d like >> to write. A proven strategy for starting unit testing is to write >> tests for all new features. This way the up-f

Re: [Openvpn-devel] Unit testing in openvpn?

2016-04-21 Thread Gert Doering
Hi, On Thu, Apr 21, 2016 at 07:40:16PM +0200, Jens Neuhalfen wrote: > The first candidate would be the U2F integration that I???d like > to write. A proven strategy for starting unit testing is to write > tests for all new features. This way the up-front cost is reduced > to the invest for ???the

Re: [Openvpn-devel] Unit testing in openvpn?

2016-04-21 Thread Gert Doering
Hi, On Thu, Apr 21, 2016 at 09:12:28AM +0200, Jens wrote: > I think that adding unit tests would greatly improve the ease of > implementing new features for openvpn. I have spend a lot of time > coding Java (and others), and unit testing greatly improved my code > quality, my throughput, and last

Re: [Openvpn-devel] Unit testing in openvpn?

2016-04-21 Thread Jens Neuhalfen
Hi Arne, […] >> > The problem with unit tests and existing software is that, if the > software hasn't been written with testing in mind, it is often hard > without major refactoring to do the small java style unit tests. Also > someone has to write these unit tests and free time is currently spa

Re: [Openvpn-devel] Unit testing in openvpn?

2016-04-21 Thread Jens Neuhalfen
Hi Samuli, […] > I think the first step would be to identify the places where unit tests could > be implemented easily (if any), and where they would do most good. If > something falls to both of these categories then writing a unit test there > would probably make sense. The first candidate

Re: [Openvpn-devel] Unit testing in openvpn?

2016-04-21 Thread Samuli Seppänen
Adding a test framework would require a way to include & track this dependency. I see three possibilities * Copy-and-forget: Add a copy the upstream testing framework and add it as-is to the source code repo. * Include-dependency-management: Add some kind of dependency management, e.g. cmake

Re: [Openvpn-devel] Unit testing in openvpn?

2016-04-21 Thread Arne Schwabe
Am 21.04.16 um 09:12 schrieb Jens: > Hi > > I think that adding unit tests would greatly improve the ease of implementing > new features for openvpn. I have spend a lot of time coding Java (and > others), and unit testing greatly improved my code quality, my throughput, > and last, but not le

Re: [Openvpn-devel] Unit testing in openvpn?

2016-04-21 Thread Илья Шипицин
the most comfortable for github is travis-ci (it runs tests even for pull requests). we already use it for openvpn-gui and openvpn-build projects (just build, those projects do not have any tests yet): https://travis-ci.org/OpenVPN/openvpn-gui https://travis-ci.org/OpenVPN/openvpn-build as for op

[Openvpn-devel] Unit testing in openvpn?

2016-04-21 Thread Jens
Hi I think that adding unit tests would greatly improve the ease of implementing new features for openvpn. I have spend a lot of time coding Java (and others), and unit testing greatly improved my code quality, my throughput, and last, but not least, my confidence in the code. Indeed I have be