[Openvpn-devel] [PATCH] Fix management-external-cert option parsing error

2016-06-17 Thread Selva Nair
- Allow --management-external-cert as an alternative to --cert - Also make sure --cert and --management-external-cert are not both specified, and clarify in the man page that the latter must be used with --management-external-key. Signed-off-by: Selva Nair ---

Re: [Openvpn-devel] [PATCH] Fix management-external-cert option parsing error

2016-06-17 Thread Gert Doering
Hi, On Thu, Jun 16, 2016 at 10:54:53PM -0400, Selva Nair wrote: > - Allow --management-external-cert as an alternative to --cert > - Also make sure --cert and --management-external-cert are not >both specified, and clarify in the man page that the latter >must be used with

Re: [Openvpn-devel] [[PATCH v3]] Remove http-proxy-timeout, socks timeout and set default of server-poll-timeout to 120s

2016-06-17 Thread Gert Doering
Hi, On Thu, Jun 16, 2016 at 11:33:39AM +0200, Arne Schwabe wrote: > > I do wonder how useful these settings are, and why they are not > > default... > > they predate my OpenVPN involvement by many years. > > > > No clue.. > I would just propose to remove the option (but accept configs

[Openvpn-devel] [PATCH] Remove http-proxy-retry and socks-proxy-retry

2016-06-17 Thread Arne Schwabe
--- Changes.rst | 2 ++ src/openvpn/init.c| 4 +--- src/openvpn/options.c | 13 - src/openvpn/options.h | 1 - src/openvpn/proxy.c | 3 +-- src/openvpn/proxy.h | 1 - src/openvpn/socks.c | 10 +++--- src/openvpn/socks.h | 4 +--- 8 files changed, 12

[Openvpn-devel] [PATCH v2] Add documentation for http-proxy-user-pass option

2016-06-17 Thread Arne Schwabe
Patch V2: fix formatting problems --- Changes.rst | 4 doc/openvpn.8 | 7 +-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/Changes.rst b/Changes.rst index ab322e2..f945ad7 100644 --- a/Changes.rst +++ b/Changes.rst @@ -51,6 +51,10 @@ AEAD (GCM) data channel cipher

Re: [Openvpn-devel] [PATCH] Fix management-external-cert option parsing error

2016-06-17 Thread Selva Nair
Hi On Fri, Jun 17, 2016 at 4:00 AM, Gert Doering wrote: > Hi, > > On Thu, Jun 16, 2016 at 10:54:53PM -0400, Selva Nair wrote: > > - Allow --management-external-cert as an alternative to --cert > > - Also make sure --cert and --management-external-cert are not > >both

Re: [Openvpn-devel] [PATCH] Remove http-proxy-retry and socks-proxy-retry

2016-06-17 Thread Gert Doering
Hi, On Fri, Jun 17, 2016 at 02:47:22PM +0200, Arne Schwabe wrote: > @@ -5292,8 +5287,8 @@ add_option (struct options *options, >else if (streq (p[0], "socks-proxy-retry") && !p[1]) > { >VERIFY_PERMISSION (OPT_P_GENERAL|OPT_P_CONNECTION); > - options->ce.socks_proxy_retry =

Re: [Openvpn-devel] [PATCH v2] Add documentation for http-proxy-user-pass option

2016-06-17 Thread Selva Nair
On Fri, Jun 17, 2016 at 8:49 AM, Arne Schwabe wrote: > Patch V2: fix formatting problems > --- > Changes.rst | 4 > doc/openvpn.8 | 7 +-- > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/Changes.rst b/Changes.rst > index ab322e2..f945ad7 100644 >