[Openvpn-devel] [PATCH applied] Re: Fix a logic problem in handling of --up scripts in t_client.sh

2016-11-09 Thread Gert Doering
ACK :-) Your patch has been applied to the master branch. commit dd9a4f0ecf06e907c57f4fa7ab035b897268d54a Author: Samuli Seppänen Date: Wed Nov 9 14:42:05 2016 +0200 Fix a logic problem in handling of --up scripts in t_client.sh Signed-off-by: Samuli Seppänen

[Openvpn-devel] [PATCH] Fix a logic problem in handling of --up scripts in t_client.sh

2016-11-09 Thread samuli
From: Samuli Seppänen Previously the $up variable was never reset after being set. This mean that "--up update_t_client_ips.sh" was appended to all subsequent openvpn command-lines, even if cached IPs existed. Signed-off-by: Samuli Seppänen ---

Re: [Openvpn-devel] [PATCH] Repair topology subnet on FreeBSD 11

2016-11-09 Thread Steffan Karger
Hi, On 08-11-16 13:45, Gert Doering wrote: > We used to add "route for this subnet" by using our own address as > the gateway address, which used to mean "connected to the interface, > no gateway". FreeBSD commit 293159 changed the kernel side of that > assumption so "my address" is now always

Re: [Openvpn-devel] [PATCH 5/7] re-implement argv_printf_*()

2016-11-09 Thread David Sommerseth
On 28/10/16 18:42, Heiko Hund wrote: > The previous implementation had the problem that it was not fully > compatible with printf() and could only detect % format directives > following a space character (0x20). > > It modifies the format string and inserts marks to separate groups > before

[Openvpn-devel] [PATCH applied] Re: Repair topology subnet on FreeBSD 11

2016-11-09 Thread Gert Doering
Thanks for testing & review :-) Patch has been applied to the master and release/2.3 branch. commit a433b3813d8c38b491d2baa7b433973f2d6cd7c6 (master) commit 446ef5bda4cdc75d4cb955e274846faff0181fd3 (release/2.3) Author: Gert Doering Date: Tue Nov 8 13:45:06 2016 +0100 Repair topology

[Openvpn-devel] [PATCH] Repair topology subnet on OpenBSD

2016-11-09 Thread Gert Doering
Turns out that "topology subnet" never worked totally right on OpenBSD - the "netmask" parameter to ifconfig is ignored, and one needs to add a subnet route (and this issue is hidden if an encompassing route is pushed, like, by using --redirect-gateway). While add it, apply the hack used for

Re: [Openvpn-devel] [PATCH 6/7] argv: do fewer memory re-allocations

2016-11-09 Thread David Sommerseth
On 28/10/16 18:42, Heiko Hund wrote: > Prevent the re-allocations of memory when the internal argv grows > beyond 2 and 4 arguments by initially allocating argv to hold up to > 7 (+ trailing NULL) pointers. > > While at it rename argv_reset to argv_free to actually express > what's going on. Redo

Re: [Openvpn-devel] [PATCH] systemd: Improve the systemd unit files

2016-11-09 Thread debbie10t
On 20/10/16 21:42, David Sommerseth wrote: > [Service] > PrivateTmp=true > +RuntimeDirectory=openvpn > +RuntimeDirectoryMode=0710 > +WorkingDirectory=/etc/openvpn/server > +ExecStart=/usr/sbin/openvpn --status %t/openvpn/server_%i-status.log > --status-version 2 --suppress-timestamps