Re: [Openvpn-devel] [PATCH] Fix building with LibreSSL 2.5.1 by cleaning a hack.

2017-02-09 Thread Olivier W
Hello, 2017-02-08 23:39 GMT+01:00 Steffan Karger : > > The code change looks good, and passes my (manual) tests. I'd like to > keep the comment though, because this still is a hack/workaround to get > the private key from the SSL_CTX object, it just does so a little nicer > at the cost of a numbe

Re: [Openvpn-devel] [PATCH] Fix building with LibreSSL 2.5.1 by cleaning a hack.

2017-02-09 Thread Olivier W
Hello, Please find the new version of the patch. So, I added back the comment I had removed and new versions of OpenSSL will use SSL_CTX_get0_privatekey() instead of SSL_new() + SSL_get_privatekey() + SSL_free(). It successfully compile with LibreSSL 2.4.5, 2.5.1 and OpenSSL 1.0.2k. I've also pus