SOCKET_UNDEFINED is of type socket_descriptor_t (or SOCKET, in MS types),
so new_sd should be too. Also, the return value of this function is
always stored in a socket_descriptor_t variable, so it should return that
type (which makes sense now, because it returns new_sd) instead of an int.
2017-03-09 0:58 GMT+05:00 Samuli Seppänen :
> Hi,
>
> On 05/03/2017 16:25, Илья Шипицин wrote:
> > Hello,
> >
> > there was some buzz related to improvement of testing system, like
> > patchwork.
> > we tried gitlab-ci on our internal project, it looks very promising.
> >
> >
Commit 13b585e8 added support for multiple X509 env variables with the
same name, but as a side effect caused these variables to pile up for
each renegotiation. The old code would simply overwrite the old variables
(as long as an equally-long chain was used for the new session).
To stop the
A number of printf-like functions in windows-specific code used incorrect
format specifiers, which could potentially lead to incorrect values being
printed.
Signed-off-by: Steffan Karger
---
src/openvpn/route.c | 12 ++--
src/openvpn/socket.c | 6 +++---
Am 09.03.17 um 11:47 schrieb Steffan Karger:
> SOCKET_UNDEFINED is of type socket_descriptor_t (or SOCKET, in MS types),
> so new_sd should be too. Also, the return value of this function is
> always stored in a socket_descriptor_t variable, so it should return that
> type (which makes sense
On 09-03-17 13:23, Steffan Karger wrote:
> A number of printf-like functions in windows-specific code used incorrect
> format specifiers, which could potentially lead to incorrect values being
> printed.
Hm, some of these are not windows-specific, and cause problems for
non-windows builds.
On Thu, Mar 09, 2017 at 03:00:43PM +0100, Steffan Karger wrote:
> A number of printf-like functions used incorrect format specifiers for
> Windows builds, which could potentially lead to incorrect values being
> printed / used when calling executables.
>
> Signed-off-by: Steffan Karger
On 09-03-17 15:20, Antonio Quartulli wrote:
> On Thu, Mar 09, 2017 at 03:00:43PM +0100, Steffan Karger wrote:
>> A number of printf-like functions used incorrect format specifiers for
>> Windows builds, which could potentially lead to incorrect values being
>> printed / used when calling
A number of printf-like functions used incorrect format specifiers for
Windows builds, which could potentially lead to incorrect values being
printed / used when calling executables.
Signed-off-by: Steffan Karger
---
v2: add OVPN_PRI_SKT define to print socket type