Re: [Openvpn-devel] [PATCH for-master v2] Fix format spec errors in Windows builds

2018-02-22 Thread Steffan Karger
Hi, On 22-02-18 05:54, selva.n...@gmail.com wrote: > From: Selva Nair > > - "%ll" is not supported by Windows run time, so use PRIi64 >and cast the variable to (int64_t) in output statements >(as in commit 9ba36639abcac4367c8227d2dd87b18fb56267c4) > > - Fix an

[Openvpn-devel] [PATCH applied] Re: Fix removal of on-link prefix on windows with netsh

2018-02-22 Thread Gert Doering
Thanks. Patch has been applied to the master and release/2.4 branch. commit 2cea72005cb5a825c25494959d550ae16562676a (master) commit b8f56fadbe459423b673886c785b7ed6f3a37c36 (release/2.4) Author: Gert Doering Date: Tue Feb 20 17:00:16 2018 +0100 Fix removal of on-link prefix on windows

[Openvpn-devel] [PATCH applied] Re: Move code to free cd to a function CAPI_DATA_free()

2018-02-22 Thread Gert Doering
Acked-by: Gert Doering Your patch has been applied to the master branch. (I took the ACK from Steffan for v1, and verified that v2 is really idential except for the extra empty line - so line numbers differ, but code is the same. Adding an extra ACK from me for

Re: [Openvpn-devel] [PATCH v2 2/3] Move setting private key to a function in prep for EC support

2018-02-22 Thread Steffan Karger
Hi, On 26-01-18 16:53, selva.n...@gmail.com wrote: > From: Selva Nair > > - Also add reference counting to CAPI_DATA (application data): > > When the application data is assigned to the private key > we free it in the key's finish method. Proper error handling >

Re: [Openvpn-devel] [PATCH v2] Check for time_t overflow in event_timeout_trigger()

2018-02-22 Thread Selva Nair
Hi, On Thu, Feb 22, 2018 at 5:37 PM, Selva Nair wrote: >> +/** Return true if the addition of a and b would overflow. */ >> +static inline bool >> +time_t_add_overflow(time_t a, time_t b) { >> +static_assert(((time_t) -1) < 0, "OpenVPN assumes time_t is signed"); >> +

Re: [Openvpn-devel] [PATCH v2 2/3] Move setting private key to a function in prep for EC support

2018-02-22 Thread Selva Nair
Hi, On Thu, Feb 22, 2018 at 4:47 PM, Steffan Karger wrote: > Hi, > > On 26-01-18 16:53, selva.n...@gmail.com wrote: >> From: Selva Nair >> >> - Also add reference counting to CAPI_DATA (application data): >> >> When the application data is assigned to

Re: [Openvpn-devel] [PATCH v2] Check for time_t overflow in event_timeout_trigger()

2018-02-22 Thread Selva Nair
Hi, This just caught my fancy :) On Tue, Jan 2, 2018 at 5:28 PM, Steffan Karger wrote: > As reported in trac #922, the wakeup computation in > event_timeout_trigger() could overflow. Since time_t and int are signed > types, that is officially undefined behvaiour. > > On

[Openvpn-devel] [PATCH v3 2/3] Move setting private key to a function in prep for EC support

2018-02-22 Thread selva . nair
From: Selva Nair - Also add reference counting to CAPI_DATA (application data): When the application data is assigned to the private key we free it in the key's finish method. Proper error handling requires to keep track of whether data is assigned to the key or

Re: [Openvpn-devel] [PATCH v3 2/3] Move setting private key to a function in prep for EC support

2018-02-22 Thread Steffan Karger
Hi, On 23-02-18 04:03, selva.n...@gmail.com wrote: > From: Selva Nair > > - Also add reference counting to CAPI_DATA (application data): > > When the application data is assigned to the private key > we free it in the key's finish method. Proper error handling >

[Openvpn-devel] [PATCH applied] Re: Fix format spec errors in Windows builds

2018-02-22 Thread Gert Doering
Thanks. Compile-tested, "less warnings" :-) (and stared-at-code). Your patch has been applied to the master branch. commit 06ad53e067d9a8be571a27f44005fa7e8038f69e Author: Selva Nair Date: Wed Feb 21 23:54:55 2018 -0500 Fix format spec errors in Windows builds Signed-off-by: