Re: [Openvpn-devel] [PATCH v5] openvpnserv: enable interactive service to open tun

2019-07-22 Thread Selva Nair
Hi, On Thu, Jul 18, 2019 at 7:42 AM Lev Stipakov wrote: > From: Lev Stipakov > > This patch enables interactive service to open tun device. > This is mostly needed by Wintun, which could be opened > only by privileged process. > > When interactive service is used, instead of calling >

[Openvpn-devel] Fwd: [PATCH] crypto.c: fix Visual Studio build

2019-07-22 Thread Lev Stipakov
Moving discussion to -devel. By the way, are you aware that we already perform Visual Studio builds in appveyor? https://ci.appveyor.com/project/mattock/openvpn-build/history Do you think we should have both? What would be nice to have is to trigger VS build on every commit to openvpn repo,

[Openvpn-devel] [PATCH applied] Re: Fix broken fragment/mssfix with NCP

2019-07-22 Thread Gert Doering
Your patch has been applied to the master branch. I have not tried to understand the actual change, but the general explanation makes sense and with two ACKs already... I did run t_client tests, though :-) (and there is a fragment test). I did try to apply it to 2.4, because it's a bugfix (so

[Openvpn-devel] [PATCH applied] Re: Do not set pkcs11-helper 'safe fork mode'

2019-07-22 Thread Gert Doering
Your patch has been applied to the master and release/2.4 branch (bugfix). Taking Steffan's comments on the list and AlonBL's comments in trac as ACK. David had issues on CentOS, but this might have been a problematic version of pkcs11-helper - which should be tested, though. I have not really

Re: [Openvpn-devel] [PATCH applied] Re: Do not set pkcs11-helper 'safe fork mode'

2019-07-22 Thread Gert Doering
Hi, On Mon, Jul 22, 2019 at 08:54:14PM +0200, Gert Doering wrote: > Your patch has been applied to the master and release/2.4 branch (bugfix). > > Taking Steffan's comments on the list and AlonBL's comments in trac as > ACK. David had issues on CentOS, but this might have been a problematic >