On 26-07-19 22:39, selva.n...@gmail.com wrote:
> From: Selva Nair
>
> Fixes the wrong check on siglen instead of *siglen for
> signing failures.
>
> Bug reported by: lilulo
>
> Signed-off-by: Selva Nair
> ---
>
> 2.4 will need a separate patch
>
> src/openvpn/cryptoapi.c | 4 ++--
> 1
Thanks.
Your patch has been applied to the master and release/2.4 branch. I still
have no idea what it does, but it applies and Lev says the change is good :)
commit abf7a2f226a262860f369e0a3c5d0f6124b7f110 (master)
commit 94157cb368d850032d7c6f436499738ed8bd7834 (release/2.4)
Author: Gisle
From: Selva Nair
For PSS padding, CNG requires the digest to be signed
and the digest algorithm in use, which are not accessible
via the rsa_sign and rsa_priv_enc callbacks of OpenSSL.
This patch uses the EVP_KEY interface to hook to
evp_pkey_sign callback if OpenSSL version is > 1.1.0.
Mapping
And thanks again :-) - even less tested, just checking that this is indeed
the only occurance of siglen/*siglen in 2.4
Your patch has been applied to the release/2.4 branch.
commit eed67cf0e7f6cbe596495c2f83aeea7c15db0d6e
Author: Selva Nair
Date: Fri Jul 26 23:12:21 2019 -0400
Correct
On 27-07-19 05:12, selva.n...@gmail.com wrote:
> From: Selva Nair
>
> Fixes the wrong check on siglen instead of *siglen for
> signing failures.
>
> Bug reported by: lilulo
>
> Signed-off-by: Selva Nair
> ---
> src/openvpn/cryptoapi.c | 2 +-
> 1 file changed, 1 insertion(+), 1
Your patch has been applied to the master branch.
(The code is not in 2.4, so no need to backport). Slightly tested with
a "make check" run.
commit 2df27b2fa3932372075afd0db6b706a38e0a9dc3
Author: Lev Stipakov
Date: Thu Jul 18 12:35:03 2019 +0300
crypto.c: fix Visual Studio build
Thanks (and thanks for sending the patch for 2.4 right with it)
I have not tested anything, but the patch looks very much "obviously
correct".
Your patch has been applied to the master branch.
commit f4ac6b780db2e0c3b60d180bd6545efe30a52059
Author: Selva Nair
Date: Fri Jul 26 16:39:17 2019
