Hi,
On Fri, Aug 16, 2019 at 10:49:45PM +0200, Antonio Quartulli wrote:
> Commit ("openssl: Fix compilation without deprecated OpenSSL 1.1 APIs")
> has removed the cipher_ctx_cleanup() API, as it is not anymore required
> to be a distinct call. However, while doing so it also touched the
> mbedtls
On Fri, 2019-08-16 at 13:45 +0200, David Sommerseth wrote:
> This gets a Feature-ACK from me. This is useful information, and
> something
> other users in the community have asked for earlier too. But there
> are a few
> things here before starting to dive into the details.
>
> First of all, we
Am 17.08.2019 um 08:48 schrieb Gert Doering:
> Hi,
>
> On Fri, Aug 16, 2019 at 10:49:45PM +0200, Antonio Quartulli wrote:
>> Commit ("openssl: Fix compilation without deprecated OpenSSL 1.1 APIs")
>> has removed the cipher_ctx_cleanup() API, as it is not anymore required
>> to be a distinct call. H
Your patch has been applied to the master branch.
As already written, the explanation makes sense, and it fully fixes the
problems observed on the buildslaves -> so, another ACK from me.
Thanks for the quick investigation & fix.
commit 2a74fc3f66bb9f73fc957719d187256922ca003f
Author: Antonio Qua
Acked-by: Gert Doering
Things look much nicer now - less casts, less free() calls :-) - thanks.
Tested on Linux/iproute2 and Linux/sitnl (t_client tests).
Your patch has been applied to the master branch.
commit 59fde742a113a450fe65a4d6b2cb9122425c1920
Author: Antonio Quartulli
Date: Fri Aug
Acked-by: Gert Doering
Looks like a reasonable change, tested on Linux/iproute2 and FreeBSD
(to cover the "#ifndef TARGET_LINUX" part).
Your patch has been applied to the master branch.
commit e64d9c47d580427ed5e3d176dbcb7aa2ea55c4ba
Author: Antonio Quartulli
Date: Mon Aug 5 11:25:27 2019 +02
Acked-by: Gert Doering
Verified that this does, indeed, only whitespace / bracket changes, and
there are no ambiguous brackets in the parts that are touched.
It messes up your nice formatting of the backspaces for SITNL_ADDATTR(),
though :-)
Lightly tested on FreeBSD and Linux/sitnl.
Your patc
Acked-by: Gert Doering
These look like reasonable simplifications - if we're not on linux,
we'll never have ENABLE_IPROUTE2, so no good testing for it. And so on.
Compile tested on Linux/sitnl, Linux/iproute2, FreeBSD. Buildbot will
see to the others (if it breaks AIX, I'll find out next tim
