[Openvpn-devel] [PATCH applied] Re: Add .git-blame-ignore-revs with reformat commits

2020-06-10 Thread Gert Doering
Great discovery, much appreciated :-) - and I have not added the two dangling new files in this patch. Your patch has been applied to the master branch. commit e0b49cb95286a62a4e615470c6d3fe841b433314 Author: Arne Schwabe Date: Fri Jun 5 01:53:38 2020 +0200 Add .git-blame-ignore-revs

Re: [Openvpn-devel] [PATCH v2] [openvpn-build] Install/uninstall dialer DLL as part of Windows installer operation

2020-06-10 Thread Gert Doering
Hi, On Wed, Jul 25, 2018 at 07:51:03PM +, Kevin Kane via Openvpn-devel wrote: > Signed-off-by: Kevin Kane > --- > windows-nsis/openvpn.nsi | 4 > 1 file changed, 4 insertions(+) I'm trying to clean up "dangling" OpenVPN stuff while in the run-down to 2.5 code freeze. Came across your

Re: [Openvpn-devel] [PATCH v2] Add .git-blame-ignore-revs with reformat commits

2020-06-10 Thread David Sommerseth
On 05/06/2020 01:53, Arne Schwabe wrote: > This allows git blame to ignore reformatting changes and instead > to show the previous commit that changed the line. > > To avoid manually building the list of commits this commit > adds a file with a list of reformatting commits. I might have > missed

[Openvpn-devel] Summary of the community meeting (10th June 2020)

2020-06-10 Thread Samuli Seppänen
Hi, Here's the summary of the IRC meeting. --- COMMUNITY MEETING Place: #openvpn-meeting on irc.freenode.net Date: Wed 10th June 2020 Time: 11:30 CEST (10:30 UTC) Planned meeting topics for this meeting were here: Your local

[Openvpn-devel] [PATCH] pool: remove useless 'options.h' include

2020-06-10 Thread Antonio Quartulli
Commit 6a8cd033 ("pool: add support for ifconfig-pool-persist with IPv6 only") has accidentally introduced an include for 'options.h', which revealed to not be useful at all. Remove it. Reported-by: Gert Doering Signed-off-by: Antonio Quartulli --- src/openvpn/pool.c | 1 - 1 file changed, 1

[Openvpn-devel] [PATCH applied] Re: multi: skip IPv4 logic in multi_select_virtual_addr() if no pool is configured

2020-06-10 Thread Gert Doering
Acked-by: Gert Doering The patch is quite trivial - if seen with "git show -w" :-) - it basically just encapsulates the whole "the pool has returned something, how does it need to be wrapped for pushing out?" into "is there an IPv4 pool at all?". Tested on the t_server setup - warnings are

[Openvpn-devel] [PATCH] multi: skip IPv4 logic in multi_select_virtual_addr() if no pool is configured

2020-06-10 Thread Antonio Quartulli
When no IPv4 pool is configured (but we have an IPv6 pool only), the multi_select_virtual_addr() function will spit a warning when allocating an address for a new client. This happens because the code will check for some IPv4 bits and will see that they are missing. However, these bits are not

[Openvpn-devel] [PATCH applied] Re: pool: remove useless 'options.h' include

2020-06-10 Thread Gert Doering
Acked-by: Gert Doering "trivial and obviously correct" Your patch has been applied to the master branch. commit 28e395856c897b6f2dea441dbe5eb4a151d75b85 Author: Antonio Quartulli Date: Wed Jun 10 11:01:00 2020 +0200 pool: remove useless 'options.h' include Signed-off-by: Antonio

[Openvpn-devel] [PATCH applied] Re: Set the correct mtu on windows based systems

2020-06-10 Thread Gert Doering
Acked-by: Gert Doering Selva has ACKed the version sent in April 2019, and it should have been merged then and there - we (I) let it rot, tun.c got changed quite a bit for wintun support, now we have a new patch. Thanks! (And thanks for the repeated reminders, this is necessary at times) I