[Openvpn-devel] [PATCH] t_client.sh: correctly report all failed instances in summary

2020-06-26 Thread Gert Doering
t_client.sh reports a summary at the end: Test sets succeeded: none. Test sets failed: 1 2 3 4 5. for tests that are skipped due to the pre-test ping check ("vpn target IP must not ping before VPN ist started") the script forgot to add the instance number to the summary line. Fixed.

Re: [Openvpn-devel] [PATCH v4] Make compression asymmetric by default and add warnings

2020-06-26 Thread Lev Stipakov
Hi, Apologize for delay. I tested with various combinations of flags and code works as expected. Let's reword messages as you proposed: > We reword the message a bit so that two messages are not that bad if both > are shown: > > WARNING: Compression for receiving enabled, Compression > has

[Openvpn-devel] [PATCH v4] msvc: fix various level2 warnings

2020-06-26 Thread Lev Stipakov
From: Lev Stipakov Also set warnings level to level2 and enable "treat warnings as errors" flag. Signed-off-by: Lev Stipakov --- v4: - cast setsockopt() parameter to (void *) to make Windows happy _and_ not to make code look confusing on other platforms v3: - use proper format

Re: [Openvpn-devel] [PATCH v4] Make compression asymmetric by default and add warnings

2020-06-26 Thread Gert Doering
Hi, On Fri, Jun 26, 2020 at 12:51:34PM +0300, Lev Stipakov wrote: > Semi-acked-by: Lev-Stipakov Is that an "ACKed if Gert changes the text of the message as suggested" (which is a typo, so okay-ish), or "Arne should send a new version"? gert -- "If was one thing all people took for granted,

Re: [Openvpn-devel] Darwin tap ipv6 fix

2020-06-26 Thread Gert Doering
Hi, cleaning up loose ends, and this is one of the things on my plate - sorry for stalling so long., On Tue, May 15, 2018 at 06:01:41PM -0700, Scott Shambarger via Openvpn-devel wrote: > I???m setting up a tap config on a Darwin client (Tunnelblick on OSX) to a > Linux server (Fedora). The

Re: [Openvpn-devel] [PATCH v3] msvc: fix various level2 warnings

2020-06-26 Thread Gert Doering
Hi, On Thu, Jun 25, 2020 at 01:31:39PM +0300, Lev Stipakov wrote: > case AF_INET: > if (setsockopt > -(sd, IPPROTO_IP, IP_MTU_DISCOVER, _type, > sizeof(mtu_type))) > +(sd, IPPROTO_IP, IP_MTU_DISCOVER, (const char >

Re: [Openvpn-devel] [PATCH v4] Make compression asymmetric by default and add warnings

2020-06-26 Thread Lev Stipakov
Hi, > Is that an "ACKed if Gert changes the text of the message as suggested" > (which is a typo, so okay-ish), Yes, ACKed if the committer (Gert) will change the message. ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net

[Openvpn-devel] [PATCH v5] Make compression asymmetric by default and add warnings

2020-06-26 Thread Arne Schwabe
This commit introduces the allow-compression option that allow changing the new default to the previous default or to a stricter version. Warning for comp-lzo/compress are not generated in the post option check (options_postprocess_mutate) since these warnings should also be shown on pushed

Re: [Openvpn-devel] [PATCH v5] Make compression asymmetric by default and add warnings

2020-06-26 Thread Lev Stipakov
Checked that only diffs are warning messages (as agreed) and different indentation in #define VERIFY_PERMISSION (probably caused by uncrustify). Acked-by: Lev Stipakov pe 26. kesäk. 2020 klo 14.06 Arne Schwabe (a...@rfc2549.org) kirjoitti: > > This commit introduces the allow-compression option

[Openvpn-devel] [PATCH applied] Re: Make compression asymmetric by default and add warnings

2020-06-26 Thread Gert Doering
Your patch has been applied to the master branch. Lightly tested, aka "t_client test on FreeBSD and Linux", which does use various lzo/lz4 variants - so it's not breaking existing setups (though it might turn off compression :-) - which I have not verified) David: this brings in a sizeable

[Openvpn-devel] [PATCH] Reformat files using uncrustify

2020-06-26 Thread Arne Schwabe
Some of the commits, especially engine have not strictly used uncrustify clean code. Rerun uncrustify to make them compliant again. --- src/openvpn/crypto_openssl.c| 18 ++- src/openvpn/crypto_openssl.h| 8 +- src/openvpn/helper.c| 1 -

[Openvpn-devel] [PATCH applied] Re: Reformat files using uncrustify

2020-06-26 Thread Gert Doering
Acked-by: Gert Doering Verified that this is all whitespace. "The usual". I'll add a new commit to update .git-blame-ignore-revs with this commit (which needs to be an extra commit, recursion for beginners :-)) Sorry for those that I caused or ACKed... I left out the hunk to option.c since

[Openvpn-devel] [PATCH applied] Re: msvc: fix various level2 warnings

2020-06-26 Thread Gert Doering
Acked-by: Gert Doering I have test compiled this on MacOS, FreeBSD, Linux to see if it brought in "new warnings" - nada. And the changes are good :-) - thanks. Your patch has been applied to the master branch. commit 2569902c444657464077950fca52516ca81e Author: Lev Stipakov Date: Fri

Re: [Openvpn-devel] [PATCH] New man page - Simple corrections

2020-06-26 Thread David Sommerseth
On 25/06/2020 23:01, Richard Bonhomme wrote: > Signed-off-by: Richard Bonhomme > --- > doc/man-sections/connection-profiles.rst | 2 +- > doc/man-sections/examples.rst| 2 +- > doc/man-sections/pkcs11-options.rst | 2 +- > doc/man-sections/plugin-options.rst | 4 ++-- >

[Openvpn-devel] "VRF support on Linux" / --bind-dev support

2020-06-26 Thread Maximilian Wilhelm
Hi, this set reintroduces the patch for "VRF support on Linux" by implementing --bind-dev option from 2016 as well as some real live documentation as requested by Gert :) I wrote a .rst file in the style of the "man-page overhaul project" in the hope that this format is useful and can easily be

[Openvpn-devel] [PATCH 1/2] Add --bind-dev option.

2020-06-26 Thread Maximilian Wilhelm
This options allows the user to specify a network device the OpenVPN process should use when making a connection or binding to an address. This translates in setting the SO_BINDTODEVICE option to the corresponding socket (on Linux). When for example using VRFs on Linux [0] this allows

[Openvpn-devel] [PATCH 2/2] Documentation for --bind-dev / VRFs on Linux

2020-06-26 Thread Maximilian Wilhelm
From: Maximilian Wilhelm Signed-off-by: Maximilian Wilhelm --- doc/man-sections/vrf.rst | 75 1 file changed, 75 insertions(+) create mode 100644 doc/man-sections/vrf.rst diff --git a/doc/man-sections/vrf.rst b/doc/man-sections/vrf.rst new

[Openvpn-devel] [PATCH] New man page corrections - encryption-options.rst

2020-06-26 Thread Richard Bonhomme
Signed-off-by: Richard Bonhomme --- doc/man-sections/encryption-options.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/man-sections/encryption-options.rst b/doc/man-sections/encryption-options.rst index 42c80eb8..076b5fd3 100644 ---

Re: [Openvpn-devel] [PATCH] New man page corrections - advanced-options.rst

2020-06-26 Thread David Sommerseth
On 26/06/2020 15:32, Richard Bonhomme wrote: > Signed-off-by: Richard Bonhomme > --- > doc/man-sections/advanced-options.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/doc/man-sections/advanced-options.rst > b/doc/man-sections/advanced-options.rst > index

Re: [Openvpn-devel] [PATCH] New man page corrections - encryption-options.rst

2020-06-26 Thread tincanteksup
Comment inline: On 26/06/2020 15:29, Richard Bonhomme wrote: Signed-off-by: Richard Bonhomme --- doc/man-sections/encryption-options.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/man-sections/encryption-options.rst

[Openvpn-devel] [PATCH] New man page corrections - advanced-options.rst

2020-06-26 Thread Richard Bonhomme
Signed-off-by: Richard Bonhomme --- doc/man-sections/advanced-options.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/man-sections/advanced-options.rst b/doc/man-sections/advanced-options.rst index 262e568c..dbf7799c 100644 ---

Re: [Openvpn-devel] [PATCH] New man page corrections - encryption-options.rst

2020-06-26 Thread Arne Schwabe
Am 26.06.20 um 16:34 schrieb tincanteksup: > Comment inline: > > On 26/06/2020 15:29, Richard Bonhomme wrote: >> Signed-off-by: Richard Bonhomme >> --- >>   doc/man-sections/encryption-options.rst | 8 >>   1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git

Re: [Openvpn-devel] [PATCH] New man page corrections - encryption-options.rst

2020-06-26 Thread David Sommerseth
On 26/06/2020 16:34, tincanteksup wrote: > Comment inline: > > On 26/06/2020 15:29, Richard Bonhomme wrote: >> Signed-off-by: Richard Bonhomme >> --- >>   doc/man-sections/encryption-options.rst | 8 >>   1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git