Re: [Openvpn-devel] [PATCH] Remove parameter config from multi_client_connect_mda

2020-07-01 Thread Antonio Quartulli
Hi, On 01/07/2020 14:22, Arne Schwabe wrote: > config is always used as mi->cc_config and we pass mi, > so directly use mi->cc_config > > Signed-off-by: Arne Schwabe Acked-by: Antonio Quartulli -- Antonio Quartulli ___ Openvpn-devel mailing

[Openvpn-devel] [PATCH] Remove parameter config from multi_client_connect_mda

2020-07-01 Thread Arne Schwabe
config is always used as mi->cc_config and we pass mi, so directly use mi->cc_config Signed-off-by: Arne Schwabe --- src/openvpn/multi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index 95b16744..19261c37 100644 ---

[Openvpn-devel] [PATCH applied] Re: Fix 'engine' unit test on FreeBSD (specifically 'not GNU make')

2020-07-01 Thread Gert Doering
Patch has been applied to the master branch. commit 8a168a9ac82c197725091f67fb5812d4b64050d8 Author: Gert Doering Date: Mon Jun 29 19:51:09 2020 +0200 Fix 'engine' unit test on FreeBSD (specifically 'not GNU make') Signed-off-by: Gert Doering Acked-by: James Bottomley

[Openvpn-devel] users of --single-session?

2020-07-01 Thread Gert Doering
Hi, is one of you using the openvpn option "--single-session"? If yes, what for? (This is one of the weird ones that brings quite a bit of extra state checking, and hard-to-test special-case code - so we want to get rid of it) gert -- "If was one thing all people took for granted, was

[Openvpn-devel] [PATCH applied] Re: multi.c: use mi->cc_config instead of config variable

2020-07-01 Thread Gert Doering
Acked-by: Gert Doering Test compiled. Stared at code. Grumbled. Ran a small t_server test ("just to be sure"). Your patch has been applied to the master branch. commit 712f2629c8406c017931a082cd996b439b5dfdc9 Author: Antonio Quartulli Date: Wed Jul 1 16:05:17 2020 +0200 multi.c: use

[Openvpn-devel] [PATCH applied] Re: Remove parameter config from multi_client_connect_mda

2020-07-01 Thread Gert Doering
Your patch has been applied to the master branch. (Haven't done any testing, but patch looks "obviously correct" and Antonio beat me to ACKing it anyway :) ) commit 9f0a7dcc7fa21228dbd40d976aaee5a90ac48299 Author: Arne Schwabe Date: Wed Jul 1 14:22:39 2020 +0200 Remove parameter config

[Openvpn-devel] [PATCH] multi.c: use mi->cc_config instead of config variable

2020-07-01 Thread Antonio Quartulli
Commit ("Remove parameter config from multi_client_connect_mda") has removed the config variable in favour of mi->cc_config, however one occurence was not changed. Fix it now by properly using mi->cc_config. Signed-off-by: Antonio Quartulli --- src/openvpn/multi.c | 2 +- 1 file changed, 1

[Openvpn-devel] [Patch] New man page corrections - client-options.rst

2020-07-01 Thread Richard Bonhomme
Signed-off-by: Richard Bonhomme --- doc/man-sections/client-options.rst | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/doc/man-sections/client-options.rst b/doc/man-sections/client-options.rst index 966ede1e..c5aa58c9 100644 ---

[Openvpn-devel] [Patch] New man page corrections - protocol-options.rst

2020-07-01 Thread Richard Bonhomme
Signed-off-by: Richard Bonhomme --- doc/man-sections/protocol-options.rst | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/doc/man-sections/protocol-options.rst b/doc/man-sections/protocol-options.rst index 5bc072af..a5a1253a 100644 ---