Re: [Openvpn-devel] [PATCH v2] Rework NCP compability logic and drop BF-CBC support by default

2020-08-04 Thread Gert Doering
Hi, On Wed, Jul 29, 2020 at 01:38:35PM +0200, Arne Schwabe wrote: > This reworks the NCP logic to be more strict about what is > considered an acceptable result of an NCP negotiation. It also > us to finally drop BF-CBC support by default. I think the goals are good, but there are two corner

Re: [Openvpn-devel] [PATCH v2] Rework NCP compability logic and drop BF-CBC support by default

2020-08-04 Thread Arne Schwabe
> > I'm not exactly sure what the code *does*, TBH, but de-fusing the check > into > > if (remote_cipher == NULL > || (peer_info && strstr(peer_info, "IV_CIPHERS=") )) > > makes it no longer crash (and also pass the unit test). Yes that is the right fix. My test client client

Re: [Openvpn-devel] [PATCH] Skip existing interfaces on opening the first available utun on macOS

2020-08-04 Thread Gert Doering
Hi, On Fri, Jul 31, 2020 at 12:06:29PM +0200, Arne Schwabe wrote: > This avoids the error messages trying to open already used utuns. > > Signed-off-by: Arne Schwabe I think the code looks good, but I have no time right now to test it (I can build MacOS binaries but have no test environment

Re: [Openvpn-devel] MSI Installer: Add .ovpn file

2020-08-04 Thread Илья Шипицин
Hello, we used to put *.ovpn files on special dedicated website (some guide + installer downloads + ovpn). works as charm чт, 30 июл. 2020 г. в 13:37, Robert Grätz : > Hello, > > I am very happy that 2.5 will be hopefully soon released. > > I want to integrate my config file inside the msi

[Openvpn-devel] [PATCH applied] Re: client-connect: Add documentation for the deferred client connect feature

2020-08-04 Thread Gert Doering
Acked-by: Gert Doering The code is long in. I thought I'd see some review by "not me" on the docs, but since the 2.5_beta1 cutoff date is coming soon, I just did this now. Included all the latest suggestions from Richard as well. I have reworded the "script-options.rst" section somewhat,