Thanks for digging up a way to make uncrustify fix these. Annoying,
and I did not always catch these...
Your patch has been applied to the master branch.
commit a76153c1ca98c841b8c8cf3b6ade6c00ee3876a5
Author: Frank Lichtenheld
Date: Wed May 18 12:51:57 2022 +0200
uncrustify: have
I have not tested this much - will use it soon :-) - but I'm fine
if Frank and Antonio says this works now for "with stage" usage,
too.
Your patch has been applied to the master branch.
commit d78c2a73a8f631f082ec03bb21b329d3e6fd00dd
Author: Heiko Hund
Date: Tue May 17 23:01:21 2022 +0200
I have only stared a bit at the code, and then run "make check" on
a FreeBSD / OpenSSL 3.0.3 - which passes, including test_provider
(the t_client check succeeds, but does not excercise this code at all -
so I'm not really testing it).
Uncrustify / pre-applypatch complained about the new ","
Thanks for spotting this & reporting, and sorry for not picking up
the trac ticket. Sometimes we're too busy and only pay attention
to the openvpn-devel list & our IRC channel.
Tested with master and 2.5 "make dist".
Your patch has been applied to the master and release/2.5 branch.
commit
Yes, this is a good thing - "we do this", but uncrustify didn't check,
and so inconsistencies sneaked in.
I'll add this commit ID to .git-blame-ignore-revs in the next commit.
Verified with "git show -w" that this is indeed just trivial whitespace
changes, no line wraps, brackets, or anything.
Good addition. I have added the change to ignore the previous commit
from "git blame" (.git-blame-ignore-revs) into this commit - no need
for a 3rd one.
Your patch has been applied to the master branch.
commit 63ba6b27ceb5972947175624a6a6f4a83cf67d8e
Author: Frank Lichtenheld
Date: Thu May 19
