Stared-at-code for a bit...
The remove_iroutes_from_push_route_list() function would benefit from
our new "early exit" style - but that's outside the scope of this patch
(and actually not changing both at the same time helps readability).
The way the change is done is symmetric v4/v6, so
Am 05.10.2022 um 22:19 schrieb Gert Doering:
Hi,
On Fri, Sep 09, 2022 at 09:59:01PM +0200, Arne Schwabe wrote:
The current approach of checking a string buffer is a bit clunky and
also not very extensible. Refactor this by collecting the flags in
a buffer.
I think that this one is obsolete,
Hi,
I have a few documentation / comment language issues, and a bit of
grumbling about the code (which can be ignored).
On Mon, Sep 19, 2022 at 03:41:08PM +0200, Antonio Quartulli wrote:
> +--session-timeout n
> + Raises :code:`SIGTERM` for the client instance after ``n`` seconds since
> + the
Am 23.09.22 um 12:12 schrieb Frank Lichtenheld:
bool event_timeout_trigger(struct event_timeout *et,
struct timeval *tv,
- const int et_const_retry);
+ int et_const_retry);
Why remove the const here? You did
Remove function event_timeout_clear_ret as it is unused.
Cleanup event_timeout_trigger a bit. Do an instant return false if the
timeout is not defined and inline local_now and use
event_timeout_remaining instead of local duplicated code.
Add doxygen comments for all timeout function, especially
Hi,
FreeBSD DCO has the open issue of "iroute with the same netmask as
route, so we want metric/weight/... to differenciate"
On Mon, Aug 22, 2022 at 02:55:09PM +0200, Kristof Provost wrote:
> But:
>
> $ sudo route add 172.16.2.0/24 10.0.2.1
> add net 172.16.2.0: gateway 10.0.2.1
>
From: Dmitry Zelenkovsky
Disconnect clients after session-timeout expires.
session-timeout can be defined in ccd files in order to limit
per-user connection time.
Signed-off-by: Dmitry Zelenkovsky
---
Changes from v2:
* improve manpage wording
* improve session_timeout comment
Changes from
Hi,
sorry for not handling this in a more timely fashion. It needs some
changes, though.
On Fri, Jun 24, 2022 at 12:49:41PM +0200, Paolo Cerrito wrote:
> From: paolo
>
> "Changes from v1:
> changed sprintf for logging to plugin_log
> "
>
> change to reflect current head openvpn repository
>
