[Openvpn-devel] [M] Change in openvpn[master]: samples: Remove tls-*.conf

2024-03-04 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/531?usp=email to review the following change. Change subject: samples: Remove tls-*.conf

[Openvpn-devel] [M] Change in openvpn[master]: samples: Update sample configurations

2024-03-04 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/532?usp=email to review the following change. Change subject: samples: Update sample configurations

[Openvpn-devel] [S] Change in openvpn[master]: gerrit-send-mail: add missing Signed-off-by

2024-03-04 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/530?usp=email to review the following change. Change subject: gerrit-send-mail: add missing Signed-off-by

[Openvpn-devel] [M] Change in openvpn[master]: samples: Remove tls-*.conf

2024-03-04 Thread ordex (Code Review)
Attention is currently required from: flichtenheld. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/531?usp=email ) Change subject: samples: Remove tls-*.conf .. Patch Set 1: Code-Review+2

[Openvpn-devel] [M] Change in openvpn[master]: samples: Update sample configurations

2024-03-04 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/532?usp=email to look at the new patch set (#2). Change subject: samples: Update sample configurations

[Openvpn-devel] [M] Change in openvpn[master]: samples: Remove tls-*.conf

2024-03-04 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/531?usp=email ) Change subject: samples: Remove tls-*.conf .. Patch Set 1:

[Openvpn-devel] [M] Change in openvpn[master]: samples: Update sample configurations

2024-03-04 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/532?usp=email ) Change subject: samples: Update sample configurations .. Patch

[Openvpn-devel] [XS] Change in openvpn[master]: Fix typo --data-cipher-fallback

2024-03-04 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/534?usp=email ) Change subject: Fix typo --data-cipher-fallback .. Patch Set 1:

[Openvpn-devel] [XS] Change in openvpn[master]: Fix typo --data-cipher-fallback

2024-03-04 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/534?usp=email to review the following change. Change subject: Fix typo --data-cipher-fallback

[Openvpn-devel] [XS] Change in openvpn[master]: Avoid SIGUR1 to SIGHUP when the configuration is read from stdin

2024-03-04 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/533?usp=email to review the following change. Change subject: Avoid SIGUR1 to SIGHUP when the configuration is read from stdin

[Openvpn-devel] [M] Change in openvpn[master]: samples: Update sample configurations

2024-03-04 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. Hello ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/532?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed:

[Openvpn-devel] [PATCH 1/1] openvpn-[client|server].service: Remove syslog.target

2024-03-04 Thread Frank Lichtenheld
From: Martin Rys Change-Id: If825e5b1ebc6eecc9e5398f0d8274927b53e5b83 Signed-off-by: Martin Rys Acked-by: Frank Lichtenheld Signed-off-by: Frank Lichtenheld --- distro/systemd/openvpn-cli...@.service.in | 2 +- distro/systemd/openvpn-ser...@.service.in | 2 +- 2 files changed, 2

[Openvpn-devel] [M] Change in openvpn[master]: Persist-key: enable persist-key option by default

2024-03-04 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld, its_Giaan. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/529?usp=email ) Change subject: Persist-key: enable persist-key option by default

[Openvpn-devel] [PATCH v1] samples: Remove tls-*.conf

2024-03-04 Thread Frank Lichtenheld
These are mostly redundant with client/server.conf Let's try to manage to maintain one set of sample configurations before we branch out further. Change-Id: I199541fea5a76c8edef7f67d2dbfc476987dc2f7 Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Acked-by: Antonio Quartulli --- This

[Openvpn-devel] [M] Change in openvpn[master]: Minor fix to process_ip_header

2024-03-04 Thread plaisthos (Code Review)
Attention is currently required from: its_Giaan, ordex. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/525?usp=email ) Change subject: Minor fix to process_ip_header .. Patch Set 2: