Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/

2017-02-01 Thread Илья Шипицин
developers are lazy beasts ... they just want their patches out > ASAP, and documentation are too easily ignored. > > > -- > kind regards, > > David Sommerseth > OpenVPN Technologies, Inc > > > > > On 30/01/2017 08:48, Илья Шипицин wrote: > >> can we

Re: [Openvpn-devel] [PATCH applied] github: Add PR template with contributor related information

2017-02-06 Thread Илья Шипицин
2017-02-06 15:44 GMT+05:00 David Sommerseth : > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > I have ACKed and applied this, just to get this one resolved. But I am > very > disappointed that you have yet again completely ignored the guidelines > described in the URL[1]

Re: [Openvpn-devel] [PATCH applied] github: Add PR template with contributor related information

2017-02-07 Thread Илья Шипицин
2017-02-07 15:09 GMT+05:00 Samuli Seppänen : > On 07/02/2017 11:06, Samuli Seppänen wrote: > >> On 06/02/2017 12:44, David Sommerseth wrote: >> >>> -BEGIN PGP SIGNED MESSAGE- >>> Hash: SHA1 >>> >>> I have ACKed and applied this, just to get this one resolved. But I am

Re: [Openvpn-devel] [PATCH] Fix building with LibreSSL 2.5.1 by cleaning a hack.

2017-02-07 Thread Илья Шипицин
2017-02-07 9:14 GMT+05:00 Antonio Quartulli : > On Mon, Feb 06, 2017 at 08:18:01PM +0100, Olivier W wrote: > > Should be compatible with all versions of OpenSSL and LibreSSL. > > Similar to what is done in curl: > >

Re: [Openvpn-devel] [PATCH applied] github: Add PR template with contributor related information

2017-02-07 Thread Илья Шипицин
2017-02-07 18:11 GMT+05:00 David Sommerseth < open...@sf.lists.topphemmelig.net>: > On 07/02/17 11:23, Илья Шипицин wrote: > > as for compliance check, it will always annoy people if it is something > > written somewhere. people will forget to have a look at it. > > ca

Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/

2017-02-02 Thread Илья Шипицин
2017-02-02 13:27 GMT+05:00 Samuli Seppänen : > On 31/01/2017 15:49, David Sommerseth wrote: > >> On 30/01/17 13:34, Samuli Seppänen wrote: >> >>> I agree with you on keeping the pull request template minimal and having >>> the more fine-grained information in Trac. >>> >>>

Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/

2017-01-21 Thread Илья Шипицин
2017-01-21 0:24 GMT+05:00 David Sommerseth < open...@sf.lists.topphemmelig.net>: > On 13/01/17 10:05, Samuli Seppänen wrote: > > Il 13/01/2017 10:50, Ilya Shipitsin ha scritto: > >> --- > >> .github/PULL_REQUEST_TEMPLATE.md | 8 > >> 1 file changed, 8 insertions(+) > >> create mode

Re: [Openvpn-devel] [PATCH] Resolving several travis-ci issues:

2017-01-24 Thread Илья Шипицин
can we apply it ? seems nobody minds 2017-01-10 13:04 GMT+05:00 Ilya Shipitsin : > * moving LD_LIBRARY_PATH as far as possible (otherwise "wget" picks it, > which is not desirable) > * split LD_LIBRARY_PATH into LD_LIBRARY_PATH/DYLD_LIBRARY_PATH depending > on operating

Re: [Openvpn-devel] [PATCH] Resolving several travis-ci issues:

2017-01-27 Thread Илья Шипицин
2017-01-26 0:21 GMT+05:00 David Sommerseth < open...@sf.lists.topphemmelig.net>: > On 10/01/17 09:04, Ilya Shipitsin wrote: > > * moving LD_LIBRARY_PATH as far as possible (otherwise "wget" picks it, > which is not desirable) > > * split LD_LIBRARY_PATH into LD_LIBRARY_PATH/DYLD_LIBRARY_PATH >

Re: [Openvpn-devel] [PATCH] Resolve several travis-ci issues

2017-01-27 Thread Илья Шипицин
please, ignore it. I will send v2 soon Пт, 27 янв. 2017 г. в 18:53, Ilya Shipitsin : > MBEDTLS_VERSION, OPENSSL_VERSION were defined twice - in both > .travis.yml and .travis/build-deps.sh files, the last one > defined OPENSSL_VERSION via nonexistent OPENSSL_VERION >

Re: [Openvpn-devel] [PATCH] Resolve several travis-ci issues

2017-01-28 Thread Илья Шипицин
this one is final v2 patch 2017-01-28 13:06 GMT+05:00 Ilya Shipitsin : > MBEDTLS_VERSION, OPENSSL_VERSION were defined twice - in both > .travis.yml and .travis/build-deps.sh files, the last one > defined OPENSSL_VERSION via nonexistent OPENSSL_VERION > variable, which

Re: [Openvpn-devel] [PATCH] Resolve several travis-ci issues

2017-01-28 Thread Илья Шипицин
forgot to mention, this patch might be applied to both master and release/2.4 branches 2017-01-28 13:07 GMT+05:00 Илья Шипицин <chipits...@gmail.com>: > this one is final v2 patch > > 2017-01-28 13:06 GMT+05:00 Ilya Shipitsin <chipits...@gmail.com>: > >> MBEDTLS

Re: [Openvpn-devel] [PATCH] Resolve several travis-ci issues

2017-01-28 Thread Илья Шипицин
2017-01-29 1:29 GMT+05:00 Selva Nair : > Hi, > > On Sat, Jan 28, 2017 at 3:06 AM, Ilya Shipitsin > wrote: > >> MBEDTLS_VERSION, OPENSSL_VERSION were defined twice - in both >> .travis.yml and .travis/build-deps.sh files, the last one >> defined

Re: [Openvpn-devel] [PATCH] Fix segfault when using crypto lib without AES-256-CTR or SHA256

2017-02-22 Thread Илья Шипицин
2017-02-22 13:30 GMT+05:00 Steffan Karger : > On 22-02-17 08:39, Gert Doering wrote: > > On Wed, Feb 22, 2017 at 02:21:35AM +0100, David Sommerseth wrote: > >From d97f526a2ddbf2abe60a64260601ebd742fc00cc Mon Sep 17 00:00:00 > 2001 > From: "Simon (simix)" >

Re: [Openvpn-devel] build against openssl 1.1.0

2017-02-18 Thread Илья Шипицин
2017-02-19 4:16 GMT+05:00 David Sommerseth < open...@sf.lists.topphemmelig.net>: > On 18/02/17 08:34, Илья Шипицин wrote: > > I added openssl-1.0.1e to test matrix (do not pay attention to > > commit title, it happened accidently from iPad), so ... > > &g

Re: [Openvpn-devel] build against openssl 1.1.0

2017-02-17 Thread Илья Шипицин
Пт, 17 февр. 2017 г. в 22:21, David Sommerseth < open...@sf.lists.topphemmelig.net>: > On 17/02/17 17:35, Emmanuel Deloget wrote: > > > > Now, I have a question which is related to this. The way I'm doing > > things, I will make sure that the new code is compatible with both > > OpenSSL 1.0.x and

Re: [Openvpn-devel] build against openssl 1.1.0

2017-02-17 Thread Илья Шипицин
2017-02-17 23:17 GMT+05:00 Илья Шипицин <chipits...@gmail.com>: > > Пт, 17 февр. 2017 г. в 22:21, David Sommerseth <openvpn@sf.lists. > topphemmelig.net>: > >> On 17/02/17 17:35, Emmanuel Deloget wrote: >> > >> > Now, I have a question which is r

Re: [Openvpn-devel] build against openssl 1.1.0

2017-02-23 Thread Илья Шипицин
2017-02-19 9:48 GMT+05:00 Илья Шипицин <chipits...@gmail.com>: > > > 2017-02-19 4:16 GMT+05:00 David Sommerseth <openvpn@sf.lists. > topphemmelig.net>: > >> On 18/02/17 08:34, Илья Шипицин wrote: >> > I added openssl-1.0.1e to test matrix (do

Re: [Openvpn-devel] [PATCH] cleanup: Remove faulty env processing functions

2017-02-25 Thread Илья Шипицин
there are two another unused functions in misc.c [src/openvpn/misc.c:661]: (style) The function 'env_set_print' is never used. [src/openvpn/misc.c:895]: (style) The function 'setenv_int_i' is never used. 2017-02-25 7:02 GMT+05:00 David Sommerseth : > The

Re: [Openvpn-devel] [PATCH] travis-ci: add "make distcheck" to test scenario

2017-02-25 Thread Илья Шипицин
ack ? nack ? 2017-02-23 23:22 GMT+05:00 Ilya Shipitsin : > in rare cases openvpn is built from tarball, it happens during "installer > build" > process. "make distcheck" helps to prevent problems during such builds. > > Signed-off-by: Ilya Shipitsin >

Re: [Openvpn-devel] [PATCH] travis-ci: add "make distcheck" to test scenario

2017-02-25 Thread Илья Шипицин
2017-02-25 21:10 GMT+05:00 Steffan Karger : > Hi, > > On 23-02-17 19:22, Ilya Shipitsin wrote: > > in rare cases openvpn is built from tarball, it happens during > "installer build" > > process. "make distcheck" helps to prevent problems during such builds. > > > >

Re: [Openvpn-devel] [PATCH] cleanup: Remove faulty env processing functions

2017-02-25 Thread Илья Шипицин
2017-02-25 16:49 GMT+05:00 David Sommerseth < open...@sf.lists.topphemmelig.net>: > On 25/02/17 10:42, Илья Шипицин wrote: > > there are two another unused functions in misc.c > > > > [src/openvpn/misc.c:661]: (style) The function 'env_set_print' is never >

Re: [Openvpn-devel] [PATCH] cleanup: Remove faulty env processing functions

2017-02-25 Thread Илья Шипицин
2017-02-25 19:36 GMT+05:00 Antonio Quartulli <a...@unstable.cc>: > On Sat, Feb 25, 2017 at 06:45:36PM +0500, Илья Шипицин wrote: > > 2017-02-25 16:49 GMT+05:00 David Sommerseth < > > open...@sf.lists.topphemmelig.net>: > > > > > On 25/02/17 10:42, Илья Ши

[Openvpn-devel] travis-ci + mingw again

2017-02-15 Thread Илья Шипицин
Hello, I created "build only' testing configurations https://github.com/OpenVPN/openvpn/pull/83 I'm going to add "pkcs11" and "lzo" support later (not trivial to build those on travis, but it is desirable, because it is the way we currently build openvpn for windows) Cheers, Ilya Shipitsin

Re: [Openvpn-devel] [PATCH] Change timestamps to POSIX format.

2016-08-11 Thread Илья Шипицин
iso 8601 is good format. it is accepted by default by sql servers, Log Parser 2016-08-12 0:23 GMT+05:00 Gert Doering : > All our timestams used to be "what ctime()" produces, which is > > "Thu Aug 11 21:15:27 2016" > > Changed to use POSIX standard format, which is > >

Re: [Openvpn-devel] [PATCH] enable "--disable-crypto" build configuration

2016-09-17 Thread Илья Шипицин
2016-09-17 16:17 GMT+05:00 Steffan Karger : > Hi, > > On 17 September 2016 at 12:54, Ilya Shipitsin > wrote: > > --- > > .travis.yml | 4 > > 1 file changed, 4 deletions(-) > > > > diff --git a/.travis.yml b/.travis.yml > > index 452c48e..369db97

[Openvpn-devel] how is debug/doval and debug/dovalns are supposed to be used ?

2016-09-17 Thread Илья Шипицин
Hello, I see couple of valgrind-like tests debug/dovalns debug/doval however, I do not see any usage of them [ilia@localhost openvpn]$ find . -type f -exec grep doval {} ';' -print Binary file ./.git/index matches ./.git/index [ilia@localhost openvpn]$ I would like to valgrind tests to

Re: [Openvpn-devel] [PATCH] Fix win32 building with C99 mode

2016-09-17 Thread Илья Шипицин
Should we add mingw compiler to travis-ci matrix? 17 сент. 2016 г. 6:34 PM пользователь "Gert Doering" написал: In -std=c99 mode, WIN32 is not defined to be "1" anymore, but just "#define WIN32" - so the "#if WIN32" breaks, needs to be "#ifdef WIN32" Signed-off-by: Gert

Re: [Openvpn-devel] [PATCH] Fix win32 building with C99 mode

2016-09-18 Thread Илья Шипицин
we already run openvpn/openvpn-build in travis. build only is not complicated. there are minor issues with 14.04 mingw gcc, which is too old for openvpn master. I'll make patch after I will resolve it. 2016-09-17 18:58 GMT+05:00 Gert Doering : > Hi, > On Sat, Sep 17, 2016

Re: [Openvpn-devel] [PATCH] cppcheck finding: add "ASSERT( maxoutput > 0 || separator != NULL )" to prevent possible null pointer derefence

2016-09-18 Thread Илья Шипицин
Hello, this defect was found by cppcheck, however cppcheck still complains. so, we did not make it happy yet. I think, the best would be split this function into 2 separate functions (with either null argument) or leave it like that. 2016-09-18 20:14 GMT+05:00 David Sommerseth <

[Openvpn-devel] extended error messages ?

2016-09-23 Thread Илья Шипицин
Hello, is there a way to tell user that login/password are correct, but ... 1) password is expired 2) acount is disabled 3) access is not permitted is 2FA mechanism suitable for that ? is somebody already working on above mentioned error handling ? Cheers, Ilya Shipitsin

Re: [Openvpn-devel] [PATCH] enable "--disable-crypto" build configuration

2016-09-24 Thread Илья Шипицин
can we merge it ? 2016-09-17 16:17 GMT+05:00 Steffan Karger : > Hi, > > On 17 September 2016 at 12:54, Ilya Shipitsin > wrote: > > --- > > .travis.yml | 4 > > 1 file changed, 4 deletions(-) > > > > diff --git a/.travis.yml b/.travis.yml > > index

Re: [Openvpn-devel] [PATCH] enable "--disable-crypto" build configuration

2016-09-26 Thread Илья Шипицин
2016-09-26 12:37 GMT+05:00 Samuli Seppänen <sam...@openvpn.net>: > Il 24/09/2016 09:32, Илья Шипицин ha scritto: > >> can we merge it ? >> >> 2016-09-17 16:17 GMT+05:00 Steffan Karger <stef...@karger.me >> <mailto:stef...@karger.me>>: >> &g

[Openvpn-devel] use of "-no-undefined" in lzo local patch ?

2013-08-28 Thread Илья Шипицин
Hello! I wonder what was the purpose of "-no-undefined" in src_liblzo2_la_LDFLAGS = -version-info 2:0:0 -no-undefined $(AM_LDFLAGS) ? I made clean build, captured all output with "script" and "-no-undefined" is not mentioned there. Most probably, that option was never used during build

Re: [Openvpn-devel] "unix style line endings" in openvpn-build repo ?

2013-09-18 Thread Илья Шипицин
2013/9/18 Gert Doering : > Hi, > > On Wed, Sep 18, 2013 at 02:42:22AM +0600, ??? wrote: >> I was very impressed how Cassandra community helps developers: >> >> http://wiki.apache.org/cassandra/HowToContribute > > Yeah, this is great. > >> I spent an hour when I tried

Re: [Openvpn-devel] Windows TAP driver and NDIS 6.0

2013-11-30 Thread Илья Шипицин
I had look at "NDIS 5.1 to NDIS 6.0 migration guide", looks easy enough, I hope to give a try soon. also, it is possibility to run tap-driver on WinRT, there's still no openvpn for WinRT devices, right ? 2013/11/17 David Sommerseth : > On 17. nov. 2013 11:40, Gert

Re: [Openvpn-devel] English language? Re: [PATCH] Support non-ASCII characters in Windows tmp path

2013-12-04 Thread Илья Шипицин
I've looked through the code and I do not understand why do we need that temporary directory on windows platfrom ? anyone can explain idea behind initializing tmp-dir ? especially on Windows platform. 2013/12/4 Jonathan K. Bullard : > On Wed, Dec 4, 2013 at 4:35 AM, Matthias

[Openvpn-devel] uninitialized handle fix (serious issue on Win 8.1)

2013-12-04 Thread Илья Шипицин
Hello! I confirm issue described here: https://forums.openvpn.net/topic13246.html also, I confirm that it is due to random handle value (which somehow was null before Win 8.1 was released) also, I do not understand why we should check "err" handle on INVALID_HANDLE_VALUE, it will fail anyway on

[Openvpn-devel] Fwd: uninitialized handle fix (serious issue on Win 8.1)

2013-12-05 Thread Илья Шипицин
guys, please pay attention to this message. it really resolves issue with openvpn on windows 8.1 -- Forwarded message -- From: Илья Шипицин <chipits...@gmail.com> List-Post: openvpn-devel@lists.sourceforge.net Date: 2013/12/4 Subject: uninitialized handle fix (serious issue

Re: [Openvpn-devel] uninitialized handle fix (serious bug on Win 8.1), another attempt

2013-12-08 Thread Илья Шипицин
Ok, your suggestion? воскресенье, 8 декабря 2013 г. пользователь Gert Doering писал: > Hi, > > On Sat, Dec 07, 2013 at 09:01:35PM +0600, ??? wrote: > > if handle is not initialized, orig_stderr variable could take random > > value, which we observe on Windows 8.1 (bug reported here as

Re: [Openvpn-devel] uninitialized handle fix (serious bug on Win 8.1), another attempt

2013-12-08 Thread Илья Шипицин
ok, you suggest to initialize orig_stderr. initialize with what ? what value of orig_stderr should mean a) "no stderr redirection requested, return GetStdHandle (STD_ERROR_HANDLE)" b) "stderr redirection was requested, return orig_stderr" as Matthias Andree said, neither NULL, nor

Re: [Openvpn-devel] Heartbleed

2014-04-09 Thread Илья Шипицин
am I right that "nobind" option gives some protection to windows openvpn client ? 2014-04-08 23:02 GMT+06:00 Samuli Seppänen : > Hi, Am 08.04.2014 15:42, schrieb Steffan Karger: >> Perhaps a dumb question, but if the server instance is linked >> against

Re: [Openvpn-devel] Heartbleed

2014-04-09 Thread Илья Шипицин
ability, but not any attacker. 2014-04-09 14:30 GMT+06:00 Arne Schwabe <a...@rfc2549.org>: > Am 09.04.14 10:25, schrieb Илья Шипицин: >> am I right that "nobind" option gives some protection to windows >> openvpn client ? >> > No. Nobind gives no protection. > > Arne

Re: [Openvpn-devel] Ongoing Windoes 8 issues

2014-08-20 Thread Илья Шипицин
we have a lot of users on Windows 8, no issue at all. well, I recall some issue (it was different than https://community.openvpn.net/openvpn/ticket/316) couple of early adopters installed Windows 8 preview, openvpn doesn't work on that windows edition (due to improper variable initialization

Re: [Openvpn-devel] Ongoing Windoes 8 issues

2014-08-20 Thread Илья Шипицин
when "some hacks work, some not" , it looks like assumtion that variables should be initialized with zero. have a look around, maybe youl'll find another uninitialized variable :-) 2014-08-20 13:32 GMT+06:00 Richard Weinberger : > Hi! > > This bug exists for almost

Re: [Openvpn-devel] New OpenVPN Windows installers (I004 and I604) released

2014-10-21 Thread Илья Шипицин
this is because Heiko rejected merge request: http://sourceforge.net/p/openvpn-gui/code/merge-requests/1/ it is easily fixed by openvpn-gui manifest I keep hearing from Heiko about some magic openvpn service for years. it is just couple of minutes to merge that request though... 2014-10-21

Re: [Openvpn-devel] Windows TAP driver profiling

2015-01-17 Thread Илья Шипицин
have a look at wire speed of tap adapter, https://yadi.sk/i/zz4WbnOHe3hJf I see 10mb 2015-01-17 0:02 GMT+05:00 Dan Moulding : > Hello all, > > I have been extensively testing OpenVPN recently, for potential deployment > with some other systems I have been

Re: [Openvpn-devel] Packet loss due to radius issues

2015-07-31 Thread Илья Шипицин
Hello, I've rewritten radius thing with .net, my plugin performs queries to multiple radius servers in parallel, I'm using it with Mono in production for few months: https://github.com/skbkontur/openvpn-auth-radius I can help with that plugin if you are interested 2015-07-31 4:37 GMT+05:00

Re: [Openvpn-devel] Packet loss due to radius issues

2015-07-31 Thread Илья Шипицин
just 'user' it is too early to talk about central repository, currently I'm the only user of that plugin 2015-07-31 14:12 GMT+05:00 Samuel Thibault <samuel.thiba...@ens-lyon.org>: > Илья Шипицин, le Fri 31 Jul 2015 14:09:51 +0500, a écrit : >> I've rewritten radius thing with .net, m

Re: [Openvpn-devel] Packet loss due to radius issues

2015-08-01 Thread Илья Шипицин
I do not mind about "the official repo". can you provide more details on that? 2015-08-01 18:07 GMT+05:00 Gert Doering : > Hi, > > On Fri, Jul 31, 2015 at 11:57:26AM +0200, Samuel Thibault wrote: >> But without a central repository where people would get to know about >> your

Re: [Openvpn-devel] Packet loss due to radius issues

2015-08-05 Thread Илья Шипицин
I can maitain such a repo. also, did you consider to employ students from GSoC ? for example, ToX (which I like very much) employed 9 students. it might give some drive into development. 2015-08-02 16:36 GMT+05:00 Samuli Seppänen : > > Hi, >> >> On Fri, Jul 31, 2015 at

[Openvpn-devel] windows team ?

2015-12-28 Thread Илья Шипицин
Hello, I've heard about "things need some loving" and "let us create windows team". can you please pay some attention to pull requests https://github.com/OpenVPN/openvpn-gui/pulls ? it is no good when PR stay without any attention. looks like there's no loving for windows things. Cheers, Ilya

[Openvpn-devel] link to openvpn.se ?

2015-12-30 Thread Илья Шипицин
Hello, I mentioned that you want to shut down openvpn.se, because of beeing too old. however, there're links to it, for instance, https://github.com/OpenVPN/openvpn-gui/blob/master/README more links, higher google page rank, so people will see it in search results. should we remove that link ?

Re: [Openvpn-devel] [PATCH] Warn user if their certificate has expired

2016-01-02 Thread Илья Шипицин
I'm getting "segmentation fault" after that commit. well, I suspect you beleive that user _always_ has client cert, which is not true. obviously, for preshared keys there''s no user cert, and for user/password auth there's also no user cert (which is our case) is Valgrind I see the following:

Re: [Openvpn-devel] [PATCH] Warn user if their certificate has expired

2016-01-02 Thread Илья Шипицин
also, does it make sence to perform unit testing on build like setup server with user/password auth on localhost, connect to is using client, see whether it is ok ? 2015-12-26 12:40 GMT+03:00 Steffan Karger : > On 26-12-15 10:19, Gert Doering wrote: > > On Wed, Dec 23,

Re: [Openvpn-devel] [PATCH] Warn user if their certificate has expired

2016-01-02 Thread Илья Шипицин
as for my observation, people share password with coworkers, they will share cert in the same way :) well, password-only is legitimate setup, so I would add test case for it. maybe bit later. where can I have a look at existing test cases you are talking about? суббота, 2 января 2016 г.

[Openvpn-devel] some cleanup on openvpn-build

2016-01-10 Thread Илья Шипицин
Hello, please someone have a look at https://github.com/OpenVPN/openvpn-build/pull/16 it seems there few more files with --enable-password-save or --disable-snappy Cheers, Ilya Shipitsin

Re: [Openvpn-devel] link to openvpn.se ?

2016-01-10 Thread Илья Шипицин
Hello, any progress here ? 2015-12-31 14:48 GMT+05:00 Samuli Seppänen : > > > Hello, > >> >> I mentioned that you want to shut down openvpn.se , >> because of beeing too old. >> however, there're links to it, for instance, >>

[Openvpn-devel] unused functions (as a result of cppcheck testing)

2016-01-11 Thread Илья Шипицин
Hello, cppcheck found several unused functions: [src/openvpn/misc.c:842]: (style) The function 'setenv_int_i' is never used. [src/openvpn/misc.c:669]: (style) The function 'env_set_add_to_environment' is never used. [src/openvpn/misc.c:627]: (style) The function 'env_set_print' is never used.

[Openvpn-devel] travis-ci for openvpn-gui

2016-01-18 Thread Илья Шипицин
Hello, https://github.com/OpenVPN/openvpn-gui/pull/12 should we add build configuration under https://travis-ci.org/openvpn/ ?

Re: [Openvpn-devel] travis-ci for openvpn-gui

2016-01-18 Thread Илья Шипицин
for now, there are no tests. it will be visible whether project builds or not (for pull requests as well). 2016-01-18 11:44 GMT+05:00 Jacky Alcine <jackyalc...@gmail.com>: > This would be great. Helps with visibility of tests for the public. > > > On Mon, 2016-01-18 at 11:39 +

Re: [Openvpn-devel] travis-ci for openvpn-gui

2016-01-18 Thread Илья Шипицин
and, I'm going to add coverity to openvpn-gui later. 2016-01-18 11:44 GMT+05:00 Jacky Alcine <jackyalc...@gmail.com>: > This would be great. Helps with visibility of tests for the public. > > > On Mon, 2016-01-18 at 11:39 +0500, Илья Шипицин wrote: > > Hello, > &

Re: [Openvpn-devel] travis-ci for openvpn-gui

2016-01-22 Thread Илья Шипицин
Hello, who can add it to https://travis-ci.org/openvpn/ ? 2016-01-18 17:36 GMT+05:00 Samuli Seppänen : > Hi, > > Hello, >> >> https://github.com/OpenVPN/openvpn-gui/pull/12 >> > > I merged this one, it looked good afaict. > > should we add build configuration under

Re: [Openvpn-devel] travis-ci for openvpn-gui

2016-01-22 Thread Илья Шипицин
any progress here ? 2016-01-22 14:05 GMT+05:00 Steffan Karger <stef...@karger.me>: > On Fri, Jan 22, 2016 at 9:40 AM, Илья Шипицин <chipits...@gmail.com> > wrote: > > who can add it to https://travis-ci.org/openvpn/ ? > > Samuli can do this - I do not have sufficie

Re: [Openvpn-devel] travis-ci for openvpn-gui

2016-01-25 Thread Илья Шипицин
Samuli, any news from you ? 2016-01-23 1:22 GMT+05:00 Илья Шипицин <chipits...@gmail.com>: > any progress here ? > > 2016-01-22 14:05 GMT+05:00 Steffan Karger <stef...@karger.me>: > >> On Fri, Jan 22, 2016 at 9:40 AM, Илья Шипицин <chipits...@gmail.com> &g

Re: [Openvpn-devel] travis-ci for openvpn-gui

2016-01-25 Thread Илья Шипицин
t; > Samuli, any news from you ? >> >> 2016-01-23 1:22 GMT+05:00 Илья Шипицин <chipits...@gmail.com >> <mailto:chipits...@gmail.com>>: >> >> any progress here ? >> >> 2016-01-22 14:05 GMT+05:00 Steffan Karger <stef...@karger.me >&

Re: [Openvpn-devel] GUI repo

2016-02-07 Thread Илья Шипицин
if you mean interactive service, keep in mind that people sometimes start openvpn as a child of openvpn-gui, not as a service воскресенье, 7 февраля 2016 г. пользователь Selva Nair написал: > Hi, > > We can now remove the HighestAvailable privilege request in GUI, but have > to keep it in the

Re: [Openvpn-devel] GUI repo

2016-02-07 Thread Илья Шипицин
there's still "Start OpenVPN directly" https://github.com/OpenVPN/openvpn-gui/blob/master/openvpn.c#L724 in such case admin rights are still required for routes manipulation. maybe we should release two installers (or make a checkbox in installer?) 1) regular mode (with highest priv manifest)

Re: [Openvpn-devel] GUI repo

2016-02-07 Thread Илья Шипицин
as far as I understand it is up to user whether to install openvpn as a service or not. if openvpn is not installed as a service, highest priv is required, right? 2016-02-08 1:29 GMT+05:00 Selva Nair <selva.n...@gmail.com>: > Hi, > > On Sun, Feb 7, 2016 at 3:12 PM, Илья Ш

Re: [Openvpn-devel] GUI repo

2016-02-08 Thread Илья Шипицин
2016-02-08 2:55 GMT+05:00 Gert Doering : > Hi, > > On Mon, Feb 08, 2016 at 01:12:37AM +0500, ?? wrote: > > there's still "Start OpenVPN directly" > > > > https://github.com/OpenVPN/openvpn-gui/blob/master/openvpn.c#L724 > > > > in such case admin rights

Re: [Openvpn-devel] GUI repo

2016-02-08 Thread Илья Шипицин
I saw that PR. I have one question regarding that. when we deployed openvpn, we used to supply our users a config file without "nobind" keyword. it worked for most of our users, however, those who needed 2 or more vpn connections complained that "port already bind". so, we added "nobind" to

Re: [Openvpn-devel] GUI repo

2016-02-08 Thread Илья Шипицин
I saw few cases when openvpn.exe remains running even after openvpn-gui told it to stop (and it was awful). is iservice magic of start/stop openvpn.exe the same as for openvpn-gui ? if yes, I would say that it is ok to switch to iservice by default. 2016-02-08 12:42 GMT+05:00 Gert Doering

Re: [Openvpn-devel] Micro-sha-ft

2016-02-15 Thread Илья Шипицин
we sign our software here. actually it works like SHA-2 sign + SHA-1 timestamp. we use "signtool" for that. I'll have a look how to do that with openvpn release system 2016-02-15 14:05 GMT+05:00 Samuli Seppänen : > > > > > I presume you are aware but just in case > >

Re: [Openvpn-devel] Unit testing in openvpn?

2016-04-21 Thread Илья Шипицин
the most comfortable for github is travis-ci (it runs tests even for pull requests). we already use it for openvpn-gui and openvpn-build projects (just build, those projects do not have any tests yet): https://travis-ci.org/OpenVPN/openvpn-gui https://travis-ci.org/OpenVPN/openvpn-build as for

[Openvpn-devel] compiling openvpn-gui artifacts on PR

2016-05-02 Thread Илья Шипицин
Hello, what do you think if we involve circle ci for compiling PR ? it is know to keep artifacts https://circleci.com/gh/chipitsine/openvpn-gui-circleci/12#artifacts https://circleci.com/gh/chipitsine/openvpn-gui-circleci/10#artifacts I haven't figured out how to report automatically to github

[Openvpn-devel] automatically close PR

2016-05-02 Thread Илья Шипицин
Hello, it is not very ethical to allow people to open PR in order to say later "hey, you know, we do not accept PR" I suggest to enable https://nopullrequests.appspot.com/ on https://github.com/openvpn/openvpn repo, it looks like a polite way of saying things. ideas? Ilya Shipitsin

[Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
Hello, I just run cppcheck and ... [src/openvpnserv/interactive.c:601]: (error) Memory pointed to by 'addr_row' is freed twice. [src/openvpnserv/interactive.c:700]: (error) Memory pointed to by 'fwd_row' is freed twice. [src/openvpnserv/interactive.c:1329]: (error) Common realloc mistake:

Re: [Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
I can prepare .travis.yml for openvpn, however, I'm not prepared for "pack your commit so and so... We are short on time to merge it" Is it ok if I send .travis.yml to you? Can you proceed with commit/review procedure? 2 мая 2016 г. 12:44 пользователь "Samuli Seppänen"

Re: [Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
It seems, patches are often lost "somewhere in mailing list archives" I still have no idea why this way of distributing patches is prefferable over native github PRs 2 мая 2016 г. 12:55 пользователь "Steffan Karger" написал: On Mon, May 2, 2016 at 9:44 AM, Samuli Seppänen

Re: [Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
it is already running at "coverity_scan" branch: https://travis-ci.org/OpenVPN/openvpn/builds/120718429 so, it definitely good however, I would add (to make build running on ubuntu trusty) sudo: required dist: trusty 2016-05-02 13:59 GMT+05:00 Samuli Seppänen : > > On Mon,

Re: [Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
sf.net mailing list can go away as well. I do not see why relying on sf.net is any better than relying on github.com 2016-05-02 14:47 GMT+05:00 Gert Doering : > Hi, > > On Mon, May 02, 2016 at 12:02:37PM +0300, Samuli Seppänen wrote: > > At minimum we should clearly state

Re: [Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
when using mailing list there's no way to clearly determine what was done and needs to pay attention to. and people get disappointed "I sent a patch and nothing happened" how that is supposed to work in mailing list paradigma? 2016-05-02 15:09 GMT+05:00 Gert Doering : >

Re: [Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
if we would have been using PR, anyone would be able to have a look at single place and find opened PRs. can you find unmerged patches ? 2016-05-02 15:46 GMT+05:00 Gert Doering : > Hi > > On Mon, May 02, 2016 at 03:19:54PM +0500, ?? wrote: > > when

Re: [Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
there's nothing to be afraid of. http://doc.gitlab.com/ee/workflow/importing/import_projects_from_github.html we can export all issues, pr, whatever from github to gitlab if github will decide to follow code.google.com 2016-05-02 15:09 GMT+05:00 Gert Doering : > Hi, > > On

Re: [Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
well, I'm not prepared to pass commit procedures, I'm awaiting for Samuli response whether or not he can handle those if I will send patches directly to him 2016-05-02 15:56 GMT+05:00 Gert Doering : > Hi, > > On Mon, May 02, 2016 at 03:54:46PM +0500, ??

Re: [Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
ok, I sent to list bug report, it was somewhere on windows 8.1 beta. somehow, uninitialized variables were initialized with garbage (it was fixed to NULL in windows 8.1 release) bug is there https://github.com/OpenVPN/openvpn/blob/master/src/openvpn/error.c#L458 if std_redir is defined, so

Re: [Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
ok, we are running 1000+ users installation, just couple of them experienced that behaviour. and, after I investigated it in details, I came to uninitilized variable (which by chance was "almost always" initialized with NULL) from that point of view, 2 out of 1000 is almost nothing and I could

Re: [Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
the point is "if there were PR ... and some friendly developers behaviour", so that issue wouldn't get lost "in mailing list archives" currently, it was definitely lost. nobody knows where it is 2016-05-02 16:17 GMT+05:00 Gert Doering : > Hi, > > On Mon, May 02, 2016 at

Re: [Openvpn-devel] Need help for adding feature: Selecting remote servers by best latency

2016-05-11 Thread Илья Шипицин
how are you going to resolve a) host.example.com resolves in multiple "A" records b) host.example.com resolves in both "" and "A" records ? 2016-05-11 20:41 GMT+05:00 Paul Garnier : > Hello, > > > I’m actually trying to add an option in openvpn which will allow the

Re: [Openvpn-devel] [PATCH 1/2] Refactor t_client.sh

2016-05-24 Thread Илья Шипицин
Travis CI supports Linux and MacOS X, no *BSD, no Windows, ... 2016-05-24 12:31 GMT+05:00 Steffan Karger : > Hi, > > On Mon, May 23, 2016 at 10:44 AM, Samuli Seppänen > wrote: > > Yes. I think a separate testing branch with more liberal commit rights > >

[Openvpn-devel] travis-ci (smoke testing)

2016-06-04 Thread Илья Шипицин
Hello, I was impressed by unit testing efforts, so I suggest to implement something like that https://travis-ci.org/chipitsine/openvpn/builds/135318558 ( https://github.com/OpenVPN/openvpn/pull/52 ) we can use Linux, Mac OSX, gcc, clang, various configure options. (unfortunately, ssl cert at

Re: [Openvpn-devel] travis-ci (smoke testing)

2016-06-05 Thread Илья Шипицин
I marked xcode6.4 as failures for a while (I've no idea what's wrong there, time is correct, certificate is correct, I'll dive into that later) as for Mac OS X, we can choose build matrix as wide as we want to, I do not insist on using xcode6.4 image, it is just as example. we can pick any

[Openvpn-devel] clang static analysis

2016-06-05 Thread Илья Шипицин
Hello, I performed the following steps 1) cloned master branch of https://github.com/openvpn/openvpn 2) autoreconf -iv 3) ./configure 4) scan-build make (scan-build is clang tool for static analysis) report is here: http://chipitsine.github.io/openvpn-clang-scan/ I think we should take care

Re: [Openvpn-devel] travis-ci (smoke testing)

2016-06-05 Thread Илья Шипицин
it is because of SNI 2016-06-05 12:25 GMT+05:00 Steffan Karger : > On Sun, Jun 5, 2016 at 2:16 AM, Jens Neuhalfen > wrote: > >> (unfortunately, ssl cert at mbed tls website was expired and Xcode7.3 > does > >> not compile openvpn with openssl) >

Re: [Openvpn-devel] travis-ci (smoke testing)

2016-06-05 Thread Илья Шипицин
воскресенье, 5 июня 2016 г. пользователь Steffan Karger написал: > Hi, > > On Sun, Jun 5, 2016 at 12:21 AM, Илья Шипицин <chipits...@gmail.com > <javascript:;>> wrote: > > I was impressed by unit testing efforts, so I suggest to implement > something > >

Re: [Openvpn-devel] [PATCH] Another fix related to unit test framework

2016-06-07 Thread Илья Шипицин
it is not true that Travis-CI is limited to Linux/Ubuntu, at least there's Mac OS X. and we can set up (later) cross builds for MIPS/ARM/Windows/whatever (not sure about "make check") cross build would be good starting point, if there was such thing already, we could notice that mingw build got

Re: [Openvpn-devel] [PATCH] Another fix related to unit test framework

2016-06-07 Thread Илья Шипицин
mingw is an official way of building windows packages. I guess something like that appliable for ARM as well (I haven't heard about compilers running on those machines) so, if we can catch an issue during such compile, it is good. 2016-06-07 12:58 GMT+05:00 Samuli Seppänen :

Re: [Openvpn-devel] [PATCH] Another fix related to unit test framework

2016-06-07 Thread Илья Шипицин
as for Travis-CI builds, there's such possibility already 1) register at github.com 2) add your own repo to travis-ci.org 3) voila, you can attack Pentagon from travis-ci cloud the way of "add some attacking code to openvpn codebase" seems to be much more complicated 2016-06-07 13:20 GMT+05:00

Re: [Openvpn-devel] [PATCH] Another fix related to unit test framework

2016-06-07 Thread Илья Шипицин
oops, I was wrong. 2016-06-07 13:28 GMT+05:00 Arne Schwabe <a...@rfc2549.org>: > Am 07.06.16 um 10:23 schrieb Илья Шипицин: > > mingw is an official way of building windows packages. I guess something > > like that appliable for ARM as well (I haven't heard about compilers

[Openvpn-devel] potential segfault on strlen(NULL)

2016-06-07 Thread Илья Шипицин
Hello, I'm investigating some cppcheck findings, for example: [src/openvpn/buffer.c:442] -> [src/openvpn/buffer.c:447]: (warning) Either the condition 'if(separator&&&!(i%(space_break_flags&255)))' is redundant or there is possible null pointer dereference: separator. [src/openvpn/buffer.c:443]

  1   2   3   4   >