Re: [Openvpn-devel] [PATCH] Fix win32 building with C99 mode

Hi, On Sun, Sep 18, 2016 at 10:15:56PM +0200, Gert Doering wrote: > On Sun, Sep 18, 2016 at 10:20:16AM -0400, Selva Nair wrote: > > Yeah, to me that only confirms my feeling that #ifdef WIN32 is not > > reliable. Much better to use _WIN32 which appears to be defined by all (?) > > C compilers

Re: [Openvpn-devel] [PATCH] Fix win32 building with C99 mode

Hi, On Sun, Sep 18, 2016 at 10:20:16AM -0400, Selva Nair wrote: > Yeah, to me that only confirms my feeling that #ifdef WIN32 is not > reliable. Much better to use _WIN32 which appears to be defined by all (?) > C compilers that support windows and doesn't require any particular header > to be

Re: [Openvpn-devel] [PATCH] Fix win32 building with C99 mode

On Sun, Sep 18, 2016 at 2:59 AM, Gert Doering wrote: > Ah. Here we go... trying to redefine WIN32 at the end of syshead.h > shows what is happening: > > In file included from /usr/share/mingw-w64/include/windef.h:8:0, > from

Re: [Openvpn-devel] [PATCH] Fix win32 building with C99 mode

we already run openvpn/openvpn-build in travis. build only is not complicated. there are minor issues with 14.04 mingw gcc, which is too old for openvpn master. I'll make patch after I will resolve it. 2016-09-17 18:58 GMT+05:00 Gert Doering : > Hi, > On Sat, Sep 17, 2016

Re: [Openvpn-devel] [PATCH] Fix win32 building with C99 mode

Hi, On Sat, Sep 17, 2016 at 07:11:56PM -0400, Selva Nair wrote: > On Sat, Sep 17, 2016 at 9:20 AM, Gert Doering wrote: > > > In -std=c99 mode, WIN32 is not defined to be "1" anymore, but just > > "#define WIN32" - so the "#if WIN32" breaks, needs to be "#ifdef WIN32" > >

Re: [Openvpn-devel] [PATCH] Fix win32 building with C99 mode

Hi, On Sat, Sep 17, 2016 at 9:20 AM, Gert Doering wrote: > In -std=c99 mode, WIN32 is not defined to be "1" anymore, but just > "#define WIN32" - so the "#if WIN32" breaks, needs to be "#ifdef WIN32" > Indeed... To depend on the compiler or system headers to define WIN32

Re: [Openvpn-devel] [PATCH] Fix win32 building with C99 mode

Hi, On Sat, Sep 17, 2016 at 06:40:00PM +0500, ?? wrote: > Should we add mingw compiler to travis-ci matrix? If travis can do mingw builds, that would be good. But it is complicated. gert -- USENET is *not* the non-clickable part of WWW!

Re: [Openvpn-devel] [PATCH] Fix win32 building with C99 mode

Should we add mingw compiler to travis-ci matrix? 17 сент. 2016 г. 6:34 PM пользователь "Gert Doering" написал: In -std=c99 mode, WIN32 is not defined to be "1" anymore, but just "#define WIN32" - so the "#if WIN32" breaks, needs to be "#ifdef WIN32" Signed-off-by: Gert

[Openvpn-devel] [PATCH] Fix win32 building with C99 mode

In -std=c99 mode, WIN32 is not defined to be "1" anymore, but just "#define WIN32" - so the "#if WIN32" breaks, needs to be "#ifdef WIN32" Signed-off-by: Gert Doering --- src/openvpn/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git