Re: [Openvpn-devel] [PATCH] Improve Windows version detection with manifest

2020-07-24 Thread Gert Doering
Hi, On Fri, Jul 24, 2020 at 10:49:07PM +0300, Lev Stipakov wrote: > > How do you build? I use the "build-snapshot" script, and that does > > a "make dist" somewhere in between. > > ubuntu@ip-172-31-38-110:~/openvpn-build/windows-nsis$ > OPENVPN_VERSION=fix-remove-impersonation >

Re: [Openvpn-devel] [PATCH] Improve Windows version detection with manifest

2020-07-24 Thread Lev Stipakov
> How do you build? I use the "build-snapshot" script, and that does > a "make dist" somewhere in between. ubuntu@ip-172-31-38-110:~/openvpn-build/windows-nsis$ OPENVPN_VERSION=fix-remove-impersonation OPENVPN_URL=https://github.com/lstipakov/openvpn/archive/fix/remove-impersonation.zip

Re: [Openvpn-devel] [PATCH] Improve Windows version detection with manifest

2020-07-24 Thread Gert Doering
Hi, On Fri, Jul 24, 2020 at 10:34:17PM +0300, Lev Stipakov wrote: > 2) When I tested mingw build, I pointed source url to git repo, not to > tarball - that's why it worked. How do you build? I use the "build-snapshot" script, and that does a "make dist" somewhere in between. > That XML is

Re: [Openvpn-devel] [PATCH] Improve Windows version detection with manifest

2020-07-24 Thread Lev Stipakov
Hm.. I tested mingw build (windows-nsis) on Ubuntu 19.04 and everything worked fine. That's because: 1) Ubuntu 19.04 probably has recent enough mingw with _WIN32_WINNT_WINTHRESHOLD 2) When I tested mingw build, I pointed source url to git repo, not to tarball - that's why it worked. That XML

Re: [Openvpn-devel] [PATCH] Improve Windows version detection with manifest

2020-07-24 Thread Gert Doering
Hi, On Fri, Jul 24, 2020 at 05:14:45PM +0300, Lev Stipakov wrote: > From: Lev Stipakov > > Add manifest file to detect Windows versions greater than Windows 8. NAK, this breaks Ubuntu/MinGW builds. Actually, I think it breaks all windows builds, if you build from tarballs (which the

[Openvpn-devel] [PATCH] Improve Windows version detection with manifest

2020-07-24 Thread Lev Stipakov
From: Lev Stipakov Add manifest file to detect Windows versions greater than Windows 8. Below is an example output on Windows 10. Before: Windows version 6.2 (Windows 8 or greater) 64bit After: Windows version 10.0 (Windows 10 or greater) 64bit Signed-off-by: Lev Stipakov