Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/

2017-02-02 Thread David Sommerseth 
On 02/02/17 09:27, Samuli Seppänen wrote:
> On 31/01/2017 15:49, David Sommerseth wrote:
>> On 30/01/17 13:34, Samuli Seppänen wrote:
>>> I agree with you on keeping the pull request template minimal and having
>>> the more fine-grained information in Trac.
>>>
>>> ACK.
>>
>> Don't get me wrong!  I agree we should keep the template minimal.  But I
>> yet have to see a developer full of enthusiasm with a fix ready, who
>> just clicked "Send pull request!" who will actually instantly go reading
>> further.  And especially when the information need is fairly
>> comprehensive and not even directly in the first URL being listed.
>>
>> In fact the first place where the patch process is described is here:
>> .
>>  That is "hidden" in the middle of the wiki on the second URL.  And the
>> first URL provides just a link to the same DeveloperDocumentation wiki page.
>>
>> So I kindly ask you to reconsider the text more carefully once more.
>>
>> From my experience, to get the best success, provide the most critical
>> and as accurate information as quickly as possible.  Once things are
>> behind one URL you need to visit, many ignores it.  If you need to read
>> through more text on that URL, even more will fall off.  But provide
>> links to the more verbose documentation, as some will read it if the
>> first 2-3 sentences sounds intriguing and the contributor have time to
>> be curious.
>>
>> Most developers are lazy beasts ... they just want their patches out
>> ASAP, and documentation are too easily ignored.
>>
>>
> 
> Well, I asked if anyone had any comments regarding the PR template text, 
> and nobody did. Except when it was ACKed, of course :).
> 
> I think we need to lure GitHub people into sending patches to the 
> mailing list. If we describe the full process in the pull request 
> template, many will just say "meh, too difficult". Once they've sent 
> their patch to the list they're quite far already, and are unlikely to 
> quit if we ask them to make minor changes.
> 
> So what about this:
> 
> ---
> 
> # Thank you for your contribution
> 
> You are welcome to open PR, but they are used for discussion only. All
> patches must eventually go to the openvpn-devel mailing list for review:
> 
> * https://lists.sourceforge.net/lists/listinfo/openvpn-devel
> 
> Please send your patch using 
> [git-send-email](https://git-scm.com/docs/git-send-email). For example 
> to send your latest commit to the list:
> 
>  $ git-send-email --to=openvpn-devel@lists.sourceforge.net HEAD~1
> 
> For details, see these Wiki articles:
> 
> * https://community.openvpn.net/openvpn/wiki/Contributing
> * https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation

Thank you!  Much better!

I would just change the order of the URLs below, the Contributing one is
very generic and not very developer specific.  The second one got the
core development contribution details.

For the git-send-email/git send-email ... Antonio and Gert have already
covered that (both are correct).


-- 
kind regards,

David Sommerseth
OpenVPN Technologies, Inc




signature.asc
Description: OpenPGP digital signature
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/

2017-02-02 Thread Gert Doering 
Hi,

On Thu, Feb 02, 2017 at 02:15:06PM +0200, Samuli Seppänen wrote:
> It was not a typo. I actually did not know about "git send-email" until 
> now. I've used "git-send-email" which on Debian/Ubuntu resides in 
> /usr/lib/git-core. Are these the same thing?

Sort of.  When you run "git foo", git will (if it's not a built-in) go
out and look for a program "git-foo" in your PATH, or it seems in its
libdir.

The "ACK and mail" script David and I use is called "git-ack-am", I
put it in $HOME/bin/git-ack-am, and then I can do "git ack-am ..."
on patches...

> Anyways, let's use "git send-email" in the PR template if that one is 
> readily available on all Git installations.

That's the official one.  The other one is what you call under the hood,
and the fact that it's not in "bin/" tells stories :-)

gert
-- 
USENET is *not* the non-clickable part of WWW!
   //www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025g...@net.informatik.tu-muenchen.de


signature.asc
Description: PGP signature
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/

2017-02-02 Thread Samuli Seppänen 
On 02/02/2017 14:07, Antonio Quartulli wrote:
> On Thu, Feb 02, 2017 at 04:58:37PM +0500, Илья Шипицин wrote:
>>> Please send your patch using [git-send-email](https://git-s
>>> cm.com/docs/git-send-email). For example to send your latest commit to
>>> the list:
>>>
>>> $ git-send-email --to=openvpn-devel@lists.sourceforge.net HEAD~1
>>>
>>
>> documentation seems to be confusing here.
>> I could not get "git-send-email" for fedora, it is "git send-email" instead.
>
> I think this was a typ0 from Samuli. It's "git send-email" on every system.
> Giving an easy way to send patches (with just one command) is probably useful:
> avoid several iterations when people try to send their patches with gmail and
> similar ..
>
> Cheers,

It was not a typo. I actually did not know about "git send-email" until 
now. I've used "git-send-email" which on Debian/Ubuntu resides in 
/usr/lib/git-core. Are these the same thing?

Anyways, let's use "git send-email" in the PR template if that one is 
readily available on all Git installations.

-- 
Samuli Seppänen
Community Manager
OpenVPN Technologies, Inc

irc freenode net: mattock

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/

2017-02-02 Thread Antonio Quartulli 
On Thu, Feb 02, 2017 at 04:58:37PM +0500, Илья Шипицин wrote:
> > Please send your patch using [git-send-email](https://git-s
> > cm.com/docs/git-send-email). For example to send your latest commit to
> > the list:
> >
> > $ git-send-email --to=openvpn-devel@lists.sourceforge.net HEAD~1
> >
> 
> documentation seems to be confusing here.
> I could not get "git-send-email" for fedora, it is "git send-email" instead.

I think this was a typ0 from Samuli. It's "git send-email" on every system.
Giving an easy way to send patches (with just one command) is probably useful:
avoid several iterations when people try to send their patches with gmail and
similar ..

Cheers,



-- 
Antonio Quartulli


signature.asc
Description: Digital signature
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/

2017-02-02 Thread Илья Шипицин 
2017-02-02 13:27 GMT+05:00 Samuli Seppänen :

> On 31/01/2017 15:49, David Sommerseth wrote:
>
>> On 30/01/17 13:34, Samuli Seppänen wrote:
>>
>>> I agree with you on keeping the pull request template minimal and having
>>> the more fine-grained information in Trac.
>>>
>>> ACK.
>>>
>>
>> Don't get me wrong!  I agree we should keep the template minimal.  But I
>> yet have to see a developer full of enthusiasm with a fix ready, who
>> just clicked "Send pull request!" who will actually instantly go reading
>> further.  And especially when the information need is fairly
>> comprehensive and not even directly in the first URL being listed.
>>
>> In fact the first place where the patch process is described is here:
>> > tation#Communitypatchesandtheacceptanceprocessofthesepatches>.
>>  That is "hidden" in the middle of the wiki on the second URL.  And the
>> first URL provides just a link to the same DeveloperDocumentation wiki
>> page.
>>
>> So I kindly ask you to reconsider the text more carefully once more.
>>
>> From my experience, to get the best success, provide the most critical
>> and as accurate information as quickly as possible.  Once things are
>> behind one URL you need to visit, many ignores it.  If you need to read
>> through more text on that URL, even more will fall off.  But provide
>> links to the more verbose documentation, as some will read it if the
>> first 2-3 sentences sounds intriguing and the contributor have time to
>> be curious.
>>
>> Most developers are lazy beasts ... they just want their patches out
>> ASAP, and documentation are too easily ignored.
>>
>>
>>
> Well, I asked if anyone had any comments regarding the PR template text,
> and nobody did. Except when it was ACKed, of course :).
>
> I think we need to lure GitHub people into sending patches to the mailing
> list. If we describe the full process in the pull request template, many
> will just say "meh, too difficult". Once they've sent their patch to the
> list they're quite far already, and are unlikely to quit if we ask them to
> make minor changes.
>
> So what about this:
>
> ---
>
> # Thank you for your contribution
>
> You are welcome to open PR, but they are used for discussion only. All
> patches must eventually go to the openvpn-devel mailing list for review:
>
> * https://lists.sourceforge.net/lists/listinfo/openvpn-devel
>
> Please send your patch using [git-send-email](https://git-s
> cm.com/docs/git-send-email). For example to send your latest commit to
> the list:
>
> $ git-send-email --to=openvpn-devel@lists.sourceforge.net HEAD~1
>

documentation seems to be confusing here.
I could not get "git-send-email" for fedora, it is "git send-email" instead.
something like "send patches to list" should be ok




>
> For details, see these Wiki articles:
>
> * https://community.openvpn.net/openvpn/wiki/Contributing
> * https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation
>
> ---
>
>
> --
> Samuli Seppänen
> Community Manager
> OpenVPN Technologies, Inc
>
> irc freenode net: mattock
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/

2017-02-02 Thread Samuli Seppänen 
On 31/01/2017 15:49, David Sommerseth wrote:
> On 30/01/17 13:34, Samuli Seppänen wrote:
>> I agree with you on keeping the pull request template minimal and having
>> the more fine-grained information in Trac.
>>
>> ACK.
>
> Don't get me wrong!  I agree we should keep the template minimal.  But I
> yet have to see a developer full of enthusiasm with a fix ready, who
> just clicked "Send pull request!" who will actually instantly go reading
> further.  And especially when the information need is fairly
> comprehensive and not even directly in the first URL being listed.
>
> In fact the first place where the patch process is described is here:
> .
>  That is "hidden" in the middle of the wiki on the second URL.  And the
> first URL provides just a link to the same DeveloperDocumentation wiki page.
>
> So I kindly ask you to reconsider the text more carefully once more.
>
> From my experience, to get the best success, provide the most critical
> and as accurate information as quickly as possible.  Once things are
> behind one URL you need to visit, many ignores it.  If you need to read
> through more text on that URL, even more will fall off.  But provide
> links to the more verbose documentation, as some will read it if the
> first 2-3 sentences sounds intriguing and the contributor have time to
> be curious.
>
> Most developers are lazy beasts ... they just want their patches out
> ASAP, and documentation are too easily ignored.
>
>

Well, I asked if anyone had any comments regarding the PR template text, 
and nobody did. Except when it was ACKed, of course :).

I think we need to lure GitHub people into sending patches to the 
mailing list. If we describe the full process in the pull request 
template, many will just say "meh, too difficult". Once they've sent 
their patch to the list they're quite far already, and are unlikely to 
quit if we ask them to make minor changes.

So what about this:

---

# Thank you for your contribution

You are welcome to open PR, but they are used for discussion only. All
patches must eventually go to the openvpn-devel mailing list for review:

* https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Please send your patch using 
[git-send-email](https://git-scm.com/docs/git-send-email). For example 
to send your latest commit to the list:

 $ git-send-email --to=openvpn-devel@lists.sourceforge.net HEAD~1

For details, see these Wiki articles:

* https://community.openvpn.net/openvpn/wiki/Contributing
* https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation

---

-- 
Samuli Seppänen
Community Manager
OpenVPN Technologies, Inc

irc freenode net: mattock

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/

2017-02-01 Thread Илья Шипицин 
2017-01-31 18:49 GMT+05:00 David Sommerseth <
open...@sf.lists.topphemmelig.net>:

> On 30/01/17 13:34, Samuli Seppänen wrote:
> > I agree with you on keeping the pull request template minimal and having
> > the more fine-grained information in Trac.
> >
> > ACK.
>
> Don't get me wrong!  I agree we should keep the template minimal.  But I
> yet have to see a developer full of enthusiasm with a fix ready, who
> just clicked "Send pull request!" who will actually instantly go reading
> further.  And especially when the information need is fairly
> comprehensive and not even directly in the first URL being listed.
>
> In fact the first place where the patch process is described is here:
>  Communitypatchesandtheacceptanceprocessofthesepatches>.
>  That is "hidden" in the middle of the wiki on the second URL.  And the
> first URL provides just a link to the same DeveloperDocumentation wiki
> page.
>
> So I kindly ask you to reconsider the text more carefully once more.
>

well, I double checked everything, including refrigerator, unfortunately,
current text is the best I have.

@mattock, do you have a better text ?


>
> From my experience, to get the best success, provide the most critical
> and as accurate information as quickly as possible.  Once things are
> behind one URL you need to visit, many ignores it.  If you need to read
> through more text on that URL, even more will fall off.  But provide
> links to the more verbose documentation, as some will read it if the
> first 2-3 sentences sounds intriguing and the contributor have time to
> be curious.
>
> Most developers are lazy beasts ... they just want their patches out
> ASAP, and documentation are too easily ignored.
>
>
> --
> kind regards,
>
> David Sommerseth
> OpenVPN Technologies, Inc
>
>
>
> > On 30/01/2017 08:48, Илья Шипицин wrote:
> >> can we merge it ?
> >> @mattock ?
> >>
> >> 2017-01-21 13:47 GMT+05:00 Илья Шипицин  >> >:
> >>
> >>
> >>
> >> 2017-01-21 0:24 GMT+05:00 David Sommerseth
> >>  >> >:
> >>
> >> On 13/01/17 10:05, Samuli Seppänen wrote:
> >> > Il 13/01/2017 10:50, Ilya Shipitsin ha scritto:
> >> >> ---
> >> >>  .github/PULL_REQUEST_TEMPLATE.md | 8 
> >> >>  1 file changed, 8 insertions(+)
> >> >>  create mode 100644 .github/PULL_REQUEST_TEMPLATE.md
> >> >>
> >> >> diff --git a/.github/PULL_REQUEST_TEMPLATE.md
> b/.github/PULL_REQUEST_TEMPLATE.md
> >> >> new file mode 100644
> >> >> index 000..d0cfd7f
> >> >> --- /dev/null
> >> >> +++ b/.github/PULL_REQUEST_TEMPLATE.md
> >> >> @@ -0,0 +1,8 @@
> >> >> +# Thank you for your contribution
> >> >> +
> >> >> +You are welcome to open PR, but they are used for
> discussion only. All
> >> >> +patches must eventually go to the openvpn-devel mailing
> list for review.
> >> >> +For details, see these Wiki articles:
> >> >> +
> >> >> +* https://community.openvpn.net/openvpn/wiki/Contributing
> >> 
> >> >> +* https://community.openvpn.net/openvpn/wiki/
> DeveloperDocumentation  DeveloperDocumentation>
> >> >>
> >> >
> >> > Based on testing in the travis-openssl-test repository the
> template
> >> > works as intended, so ACK on that part.
> >> >
> >> > Any comments on the text itself?
> >>
> >> How does this work with branches?  Do we need to say that new
> >> patches
> >> should go into the master branch primarily, unless it is fixing
> >> a bug or
> >> another issue which is only relevant for specific release
> branches?
> >>
> >>
> >>
> >> we can put such information to
> >>
> >> https://community.openvpn.net/openvpn/wiki/Contributing
> >> 
> >> https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation
> >> 
> >>
> >>
> >> I would leave PR template skinny
> >>
> >>
> >>
> >>
> >> --
> >> kind regards,
> >>
> >> David Sommerseth
> >> OpenVPN Technologies, Inc
> >>
> >>
> >>
> >>
> >
> >
>
>
>
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/

2017-01-31 Thread David Sommerseth 
On 30/01/17 13:34, Samuli Seppänen wrote:
> I agree with you on keeping the pull request template minimal and having 
> the more fine-grained information in Trac.
> 
> ACK.

Don't get me wrong!  I agree we should keep the template minimal.  But I
yet have to see a developer full of enthusiasm with a fix ready, who
just clicked "Send pull request!" who will actually instantly go reading
further.  And especially when the information need is fairly
comprehensive and not even directly in the first URL being listed.

In fact the first place where the patch process is described is here:
.
 That is "hidden" in the middle of the wiki on the second URL.  And the
first URL provides just a link to the same DeveloperDocumentation wiki page.

So I kindly ask you to reconsider the text more carefully once more.

From my experience, to get the best success, provide the most critical
and as accurate information as quickly as possible.  Once things are
behind one URL you need to visit, many ignores it.  If you need to read
through more text on that URL, even more will fall off.  But provide
links to the more verbose documentation, as some will read it if the
first 2-3 sentences sounds intriguing and the contributor have time to
be curious.

Most developers are lazy beasts ... they just want their patches out
ASAP, and documentation are too easily ignored.


-- 
kind regards,

David Sommerseth
OpenVPN Technologies, Inc



> On 30/01/2017 08:48, Илья Шипицин wrote:
>> can we merge it ?
>> @mattock ?
>>
>> 2017-01-21 13:47 GMT+05:00 Илья Шипицин > >:
>>
>>
>>
>> 2017-01-21 0:24 GMT+05:00 David Sommerseth
>> > >:
>>
>> On 13/01/17 10:05, Samuli Seppänen wrote:
>> > Il 13/01/2017 10:50, Ilya Shipitsin ha scritto:
>> >> ---
>> >>  .github/PULL_REQUEST_TEMPLATE.md | 8 
>> >>  1 file changed, 8 insertions(+)
>> >>  create mode 100644 .github/PULL_REQUEST_TEMPLATE.md
>> >>
>> >> diff --git a/.github/PULL_REQUEST_TEMPLATE.md 
>> b/.github/PULL_REQUEST_TEMPLATE.md
>> >> new file mode 100644
>> >> index 000..d0cfd7f
>> >> --- /dev/null
>> >> +++ b/.github/PULL_REQUEST_TEMPLATE.md
>> >> @@ -0,0 +1,8 @@
>> >> +# Thank you for your contribution
>> >> +
>> >> +You are welcome to open PR, but they are used for discussion 
>> only. All
>> >> +patches must eventually go to the openvpn-devel mailing list for 
>> review.
>> >> +For details, see these Wiki articles:
>> >> +
>> >> +* https://community.openvpn.net/openvpn/wiki/Contributing
>> 
>> >> +* 
>> https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation 
>> 
>> >>
>> >
>> > Based on testing in the travis-openssl-test repository the template
>> > works as intended, so ACK on that part.
>> >
>> > Any comments on the text itself?
>>
>> How does this work with branches?  Do we need to say that new
>> patches
>> should go into the master branch primarily, unless it is fixing
>> a bug or
>> another issue which is only relevant for specific release branches?
>>
>>
>>
>> we can put such information to
>>
>> https://community.openvpn.net/openvpn/wiki/Contributing
>> 
>> https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation
>> 
>>
>>
>> I would leave PR template skinny
>>
>>
>>
>>
>> --
>> kind regards,
>>
>> David Sommerseth
>> OpenVPN Technologies, Inc
>>
>>
>>
>>
> 
> 





signature.asc
Description: OpenPGP digital signature
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/

2017-01-30 Thread Samuli Seppänen 
I agree with you on keeping the pull request template minimal and having 
the more fine-grained information in Trac.

ACK.

On 30/01/2017 08:48, Илья Шипицин wrote:
> can we merge it ?
> @mattock ?
>
> 2017-01-21 13:47 GMT+05:00 Илья Шипицин  >:
>
>
>
> 2017-01-21 0:24 GMT+05:00 David Sommerseth
>  >:
>
> On 13/01/17 10:05, Samuli Seppänen wrote:
> > Il 13/01/2017 10:50, Ilya Shipitsin ha scritto:
> >> ---
> >>  .github/PULL_REQUEST_TEMPLATE.md | 8 
> >>  1 file changed, 8 insertions(+)
> >>  create mode 100644 .github/PULL_REQUEST_TEMPLATE.md
> >>
> >> diff --git a/.github/PULL_REQUEST_TEMPLATE.md 
> b/.github/PULL_REQUEST_TEMPLATE.md
> >> new file mode 100644
> >> index 000..d0cfd7f
> >> --- /dev/null
> >> +++ b/.github/PULL_REQUEST_TEMPLATE.md
> >> @@ -0,0 +1,8 @@
> >> +# Thank you for your contribution
> >> +
> >> +You are welcome to open PR, but they are used for discussion 
> only. All
> >> +patches must eventually go to the openvpn-devel mailing list for 
> review.
> >> +For details, see these Wiki articles:
> >> +
> >> +* https://community.openvpn.net/openvpn/wiki/Contributing
> 
> >> +* 
> https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation 
> 
> >>
> >
> > Based on testing in the travis-openssl-test repository the template
> > works as intended, so ACK on that part.
> >
> > Any comments on the text itself?
>
> How does this work with branches?  Do we need to say that new
> patches
> should go into the master branch primarily, unless it is fixing
> a bug or
> another issue which is only relevant for specific release branches?
>
>
>
> we can put such information to
>
> https://community.openvpn.net/openvpn/wiki/Contributing
> 
> https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation
> 
>
>
> I would leave PR template skinny
>
>
>
>
> --
> kind regards,
>
> David Sommerseth
> OpenVPN Technologies, Inc
>
>
>
>


-- 
Samuli Seppänen
Community Manager
OpenVPN Technologies, Inc

irc freenode net: mattock

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/

2017-01-21 Thread Илья Шипицин 
2017-01-21 0:24 GMT+05:00 David Sommerseth <
open...@sf.lists.topphemmelig.net>:

> On 13/01/17 10:05, Samuli Seppänen wrote:
> > Il 13/01/2017 10:50, Ilya Shipitsin ha scritto:
> >> ---
> >>  .github/PULL_REQUEST_TEMPLATE.md | 8 
> >>  1 file changed, 8 insertions(+)
> >>  create mode 100644 .github/PULL_REQUEST_TEMPLATE.md
> >>
> >> diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_
> TEMPLATE.md
> >> new file mode 100644
> >> index 000..d0cfd7f
> >> --- /dev/null
> >> +++ b/.github/PULL_REQUEST_TEMPLATE.md
> >> @@ -0,0 +1,8 @@
> >> +# Thank you for your contribution
> >> +
> >> +You are welcome to open PR, but they are used for discussion only. All
> >> +patches must eventually go to the openvpn-devel mailing list for
> review.
> >> +For details, see these Wiki articles:
> >> +
> >> +* https://community.openvpn.net/openvpn/wiki/Contributing
> >> +* https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation
> >>
> >
> > Based on testing in the travis-openssl-test repository the template
> > works as intended, so ACK on that part.
> >
> > Any comments on the text itself?
>
> How does this work with branches?  Do we need to say that new patches
> should go into the master branch primarily, unless it is fixing a bug or
> another issue which is only relevant for specific release branches?
>


we can put such information to

https://community.openvpn.net/openvpn/wiki/Contributing
https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation


I would leave PR template skinny


>
>
> --
> kind regards,
>
> David Sommerseth
> OpenVPN Technologies, Inc
>
>
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/

2017-01-20 Thread David Sommerseth 
On 13/01/17 10:05, Samuli Seppänen wrote:
> Il 13/01/2017 10:50, Ilya Shipitsin ha scritto:
>> ---
>>  .github/PULL_REQUEST_TEMPLATE.md | 8 
>>  1 file changed, 8 insertions(+)
>>  create mode 100644 .github/PULL_REQUEST_TEMPLATE.md
>>
>> diff --git a/.github/PULL_REQUEST_TEMPLATE.md 
>> b/.github/PULL_REQUEST_TEMPLATE.md
>> new file mode 100644
>> index 000..d0cfd7f
>> --- /dev/null
>> +++ b/.github/PULL_REQUEST_TEMPLATE.md
>> @@ -0,0 +1,8 @@
>> +# Thank you for your contribution
>> +
>> +You are welcome to open PR, but they are used for discussion only. All
>> +patches must eventually go to the openvpn-devel mailing list for review.
>> +For details, see these Wiki articles:
>> +
>> +* https://community.openvpn.net/openvpn/wiki/Contributing
>> +* https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation
>>
> 
> Based on testing in the travis-openssl-test repository the template 
> works as intended, so ACK on that part.
> 
> Any comments on the text itself?

How does this work with branches?  Do we need to say that new patches
should go into the master branch primarily, unless it is fixing a bug or
another issue which is only relevant for specific release branches?


-- 
kind regards,

David Sommerseth
OpenVPN Technologies, Inc




signature.asc
Description: OpenPGP digital signature
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/

2017-01-13 Thread Samuli Seppänen 
Il 13/01/2017 10:50, Ilya Shipitsin ha scritto:
> ---
>  .github/PULL_REQUEST_TEMPLATE.md | 8 
>  1 file changed, 8 insertions(+)
>  create mode 100644 .github/PULL_REQUEST_TEMPLATE.md
>
> diff --git a/.github/PULL_REQUEST_TEMPLATE.md 
> b/.github/PULL_REQUEST_TEMPLATE.md
> new file mode 100644
> index 000..d0cfd7f
> --- /dev/null
> +++ b/.github/PULL_REQUEST_TEMPLATE.md
> @@ -0,0 +1,8 @@
> +# Thank you for your contribution
> +
> +You are welcome to open PR, but they are used for discussion only. All
> +patches must eventually go to the openvpn-devel mailing list for review.
> +For details, see these Wiki articles:
> +
> +* https://community.openvpn.net/openvpn/wiki/Contributing
> +* https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation
>

Based on testing in the travis-openssl-test repository the template 
works as intended, so ACK on that part.

Any comments on the text itself?

-- 
Samuli Seppänen
Community Manager
OpenVPN Technologies, Inc

irc freenode net: mattock

--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel