Re: [Openvpn-devel] [PATCH 1/3] auth_token_kt: ensure key_type object is initialized

[Arne Schwabe]

Am 10.11.19 um 14:35 schrieb Antonio Quartulli:
> Fixes the following warning:
> 
> auth_token.c: In function 'auth_token_init_secret':
> auth_token.c:47: warning: 'kt.cipher_length' is used uninitialized in this 
> function
> auth_token.c:34: note: 'kt.cipher_length' was declared here
> 
> Signed-off-by: Arne Schwabe 
> Signed-off-by: Antonio Quartulli 
> ---
>  src/openvpn/auth_token.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/openvpn/auth_token.c b/src/openvpn/auth_token.c
> index 1edc8069..6275299d 100644
> --- a/src/openvpn/auth_token.c
> +++ b/src/openvpn/auth_token.c
> @@ -31,7 +31,7 @@ const char *auth_token_pem_name = "OpenVPN auth-token 
> server key";
>  static struct key_type
>  auth_token_kt(void)
>  {
> -struct key_type kt;
> +struct key_type kt = { 0 };
>  /* We do not encrypt our session tokens */
>  kt.cipher = NULL;
>  kt.digest = md_kt_get("SHA256");
> 

Acked-by: Arne Schwabe 

Arne



signature.asc
Description: OpenPGP digital signature
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [PATCH 1/3] auth_token_kt: ensure key_type object is initialized

[Antonio Quartulli]

Fixes the following warning:

auth_token.c: In function 'auth_token_init_secret':
auth_token.c:47: warning: 'kt.cipher_length' is used uninitialized in this 
function
auth_token.c:34: note: 'kt.cipher_length' was declared here

Signed-off-by: Arne Schwabe 
Signed-off-by: Antonio Quartulli 
---
 src/openvpn/auth_token.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/openvpn/auth_token.c b/src/openvpn/auth_token.c
index 1edc8069..6275299d 100644
--- a/src/openvpn/auth_token.c
+++ b/src/openvpn/auth_token.c
@@ -31,7 +31,7 @@ const char *auth_token_pem_name = "OpenVPN auth-token server 
key";
 static struct key_type
 auth_token_kt(void)
 {
-struct key_type kt;
+struct key_type kt = { 0 };
 /* We do not encrypt our session tokens */
 kt.cipher = NULL;
 kt.digest = md_kt_get("SHA256");
-- 
2.24.0



___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel