Re: [Openvpn-devel] [PATCH applied] Re: Sent indication that a session is expired to clients
On 01/10/2019 13:11, Gert Doering wrote: > > The patch itself looks like a very nice approach to the problem with > "how can we communicate authentication fail reasons to the client?" issue > that had a few (fairly intrusiv) patch sets flying around... someone > needs to go through the open patches and see what has become obsolete. This patch should obsolete the older patches resolving the same issue. It's a simpler approach, storing the reason in a session context object which is then picked up when sending AUTH_FAILED. I had one more intrusive change, which changed the internal APIs fairly much, an approach not even I didn't really liked that much. I don't think there were any other proposals on the mailing list. I don't know what the various GUIs does, but they should also now be able to pick up these rejections via the management interface as well; even on 2.4.x clients connecting to a server with this patch. -- kind regards, David Sommerseth OpenVPN Inc signature.asc Description: OpenPGP digital signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [PATCH applied] Re: Sent indication that a session is expired to clients
Your patch has been applied to the master branch. This breaks --disable-server (again), but since David sent a patch to remedy this, I'm merging it nonetheless. I'll merge David's patch right away and push both together to avoid needless buildbot fails. The patch itself looks like a very nice approach to the problem with "how can we communicate authentication fail reasons to the client?" issue that had a few (fairly intrusiv) patch sets flying around... someone needs to go through the open patches and see what has become obsolete. commit fba0e8b8964d5a1f24182ff4c48b18923b5d7ba8 Author: Arne Schwabe Date: Tue Sep 17 14:11:15 2019 +0200 Sent indication that a session is expired to clients Acked-by: David Sommerseth Message-Id: <20190917121115.13966-1-a...@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg18820.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
