[Openvpn-devel] [S] Change in openvpn[master]: GHA: increase verbosity for make check

2024-01-05 Thread cron2 (Code Review)
cron2 has submitted this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/485?usp=email )

Change subject: GHA: increase verbosity for make check
..

GHA: increase verbosity for make check

Make sure we get to see the test-suite.log on
failure.

Change-Id: Ie44a4b750605c4cc3ac1f75e1fa5ab85804ffa71
Signed-off-by: Frank Lichtenheld 
Acked-by: Arne Schwabe 
Message-Id: <20240105142340.25735-1-g...@greenie.muc.de>
URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27943.html
Signed-off-by: Gert Doering 
---
M .github/workflows/build.yaml
1 file changed, 5 insertions(+), 5 deletions(-)




diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 4393f5c..51100c3 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -163,7 +163,7 @@
   - name: make all
 run: make -j3
   - name: make check
-run: make check
+run: make check VERBOSE=1

   ubuntu-clang-asan:
 strategy:
@@ -190,7 +190,7 @@
   - name: make all
 run: make -j3
   - name: make check
-run: make check
+run: make check VERBOSE=1

   macos:
 strategy:
@@ -239,7 +239,7 @@
   - name: make all
 run: make -j4
   - name: make check
-run: make check
+run: make check VERBOSE=1

   msvc:
   strategy:
@@ -348,7 +348,7 @@
   - name: make all
 run: make -j3
   - name: make check
-run: make check
+run: make check VERBOSE=1

   mbedtls3:
 strategy:
@@ -399,4 +399,4 @@
   - name: make all
 run: make -j3
   - name: make check
-run: make check
+run: make check VERBOSE=1

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/485?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie44a4b750605c4cc3ac1f75e1fa5ab85804ffa71
Gerrit-Change-Number: 485
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
Gerrit-MessageType: merged
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel


[Openvpn-devel] [S] Change in openvpn[master]: GHA: increase verbosity for make check

2024-01-05 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by 
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/485?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by plaisthos


Change subject: GHA: increase verbosity for make check
..

GHA: increase verbosity for make check

Make sure we get to see the test-suite.log on
failure.

Change-Id: Ie44a4b750605c4cc3ac1f75e1fa5ab85804ffa71
Signed-off-by: Frank Lichtenheld 
Acked-by: Arne Schwabe 
Message-Id: <20240105142340.25735-1-g...@greenie.muc.de>
URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27943.html
Signed-off-by: Gert Doering 
---
M .github/workflows/build.yaml
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/85/485/2

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 4393f5c..51100c3 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -163,7 +163,7 @@
   - name: make all
 run: make -j3
   - name: make check
-run: make check
+run: make check VERBOSE=1

   ubuntu-clang-asan:
 strategy:
@@ -190,7 +190,7 @@
   - name: make all
 run: make -j3
   - name: make check
-run: make check
+run: make check VERBOSE=1

   macos:
 strategy:
@@ -239,7 +239,7 @@
   - name: make all
 run: make -j4
   - name: make check
-run: make check
+run: make check VERBOSE=1

   msvc:
   strategy:
@@ -348,7 +348,7 @@
   - name: make all
 run: make -j3
   - name: make check
-run: make check
+run: make check VERBOSE=1

   mbedtls3:
 strategy:
@@ -399,4 +399,4 @@
   - name: make all
 run: make -j3
   - name: make check
-run: make check
+run: make check VERBOSE=1

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/485?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie44a4b750605c4cc3ac1f75e1fa5ab85804ffa71
Gerrit-Change-Number: 485
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
Gerrit-MessageType: newpatchset
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel


[Openvpn-devel] [S] Change in openvpn[master]: GHA: increase verbosity for make check

2024-01-05 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/485?usp=email )

Change subject: GHA: increase verbosity for make check
..


Patch Set 1: Code-Review+2

(1 comment)

Patchset:

PS1:
> Retracting my previous ACK. I mixed up cmake VERBOSE=1 with the V=1 of make.
I had still a backout of the serial test in my branch, so I did had the 
generated code for this in my tree:

tests/unit_tests/openvpn/Makefile:test x"$$VERBOSE" = x || cat 
$(TEST_SUITE_LOG);

So it actually works.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/485?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie44a4b750605c4cc3ac1f75e1fa5ab85804ffa71
Gerrit-Change-Number: 485
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
Gerrit-Attention: flichtenheld 
Gerrit-Comment-Date: Fri, 05 Jan 2024 14:19:56 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos 
Gerrit-MessageType: comment
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel


[Openvpn-devel] [S] Change in openvpn[master]: GHA: increase verbosity for make check

2024-01-05 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/485?usp=email )

The change is no longer submittable: Code-Review is unsatisfied now.

Change subject: GHA: increase verbosity for make check
..


Patch Set 1: -Code-Review

(1 comment)

Patchset:

PS1:
Retracting my previous ACK. I mixed up cmake VERBOSE=1 with the V=1 of make.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/485?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie44a4b750605c4cc3ac1f75e1fa5ab85804ffa71
Gerrit-Change-Number: 485
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
Gerrit-Attention: flichtenheld 
Gerrit-Comment-Date: Fri, 05 Jan 2024 14:09:44 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel


[Openvpn-devel] [S] Change in openvpn[master]: GHA: increase verbosity for make check

2024-01-05 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/485?usp=email )

Change subject: GHA: increase verbosity for make check
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/485?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie44a4b750605c4cc3ac1f75e1fa5ab85804ffa71
Gerrit-Change-Number: 485
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
Gerrit-Attention: flichtenheld 
Gerrit-Comment-Date: Fri, 05 Jan 2024 13:54:02 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel


[Openvpn-devel] [S] Change in openvpn[master]: GHA: increase verbosity for make check

2023-12-27 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

http://gerrit.openvpn.net/c/openvpn/+/485?usp=email

to review the following change.


Change subject: GHA: increase verbosity for make check
..

GHA: increase verbosity for make check

Make sure we get to see the test-suite.log on
failure.

Change-Id: Ie44a4b750605c4cc3ac1f75e1fa5ab85804ffa71
Signed-off-by: Frank Lichtenheld 
---
M .github/workflows/build.yaml
1 file changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/85/485/1

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 4393f5c..51100c3 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -163,7 +163,7 @@
   - name: make all
 run: make -j3
   - name: make check
-run: make check
+run: make check VERBOSE=1

   ubuntu-clang-asan:
 strategy:
@@ -190,7 +190,7 @@
   - name: make all
 run: make -j3
   - name: make check
-run: make check
+run: make check VERBOSE=1

   macos:
 strategy:
@@ -239,7 +239,7 @@
   - name: make all
 run: make -j4
   - name: make check
-run: make check
+run: make check VERBOSE=1

   msvc:
   strategy:
@@ -348,7 +348,7 @@
   - name: make all
 run: make -j3
   - name: make check
-run: make check
+run: make check VERBOSE=1

   mbedtls3:
 strategy:
@@ -399,4 +399,4 @@
   - name: make all
 run: make -j3
   - name: make check
-run: make check
+run: make check VERBOSE=1

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/485?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie44a4b750605c4cc3ac1f75e1fa5ab85804ffa71
Gerrit-Change-Number: 485
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
Gerrit-Attention: plaisthos 
Gerrit-MessageType: newchange
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel