[Openvpn-devel] [XS] Change in openvpn[master]: Document tls-exit option mainly as test option
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/447?usp=email ) Change subject: Document tls-exit option mainly as test option .. Document tls-exit option mainly as test option Change-Id: I93afff2372c4150d6bddc8c07fd4ebc8bfb0cc3e Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld Message-Id: <2023120937.15214-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27626.html Signed-off-by: Gert Doering --- M doc/man-sections/tls-options.rst 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/man-sections/tls-options.rst b/doc/man-sections/tls-options.rst index 908a42a..ad8ca72 100644 --- a/doc/man-sections/tls-options.rst +++ b/doc/man-sections/tls-options.rst @@ -553,7 +553,9 @@ code. --tls-exit - Exit on TLS negotiation failure. + Exit on TLS negotiation failure. This option can be useful when you only + want to make one attempt at connecting, e.g. in a test or monitoring script. + (OpenVPN's own test suite uses it this way.) --tls-export-cert directory Store the certificates the clients use upon connection to this -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/447?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I93afff2372c4150d6bddc8c07fd4ebc8bfb0cc3e Gerrit-Change-Number: 447 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-MessageType: merged ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XS] Change in openvpn[master]: Document tls-exit option mainly as test option
cron2 has uploaded a new patch set (#4) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/447?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Document tls-exit option mainly as test option .. Document tls-exit option mainly as test option Change-Id: I93afff2372c4150d6bddc8c07fd4ebc8bfb0cc3e Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld Message-Id: <2023120937.15214-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27626.html Signed-off-by: Gert Doering --- M doc/man-sections/tls-options.rst 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/47/447/4 diff --git a/doc/man-sections/tls-options.rst b/doc/man-sections/tls-options.rst index 908a42a..ad8ca72 100644 --- a/doc/man-sections/tls-options.rst +++ b/doc/man-sections/tls-options.rst @@ -553,7 +553,9 @@ code. --tls-exit - Exit on TLS negotiation failure. + Exit on TLS negotiation failure. This option can be useful when you only + want to make one attempt at connecting, e.g. in a test or monitoring script. + (OpenVPN's own test suite uses it this way.) --tls-export-cert directory Store the certificates the clients use upon connection to this -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/447?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I93afff2372c4150d6bddc8c07fd4ebc8bfb0cc3e Gerrit-Change-Number: 447 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XS] Change in openvpn[master]: Document tls-exit option mainly as test option
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/447?usp=email ) Change subject: Document tls-exit option mainly as test option .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/447?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I93afff2372c4150d6bddc8c07fd4ebc8bfb0cc3e Gerrit-Change-Number: 447 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Fri, 01 Dec 2023 10:28:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XS] Change in openvpn[master]: Document tls-exit option mainly as test option
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/447?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review-1 by flichtenheld Change subject: Document tls-exit option mainly as test option .. Document tls-exit option mainly as test option Change-Id: I93afff2372c4150d6bddc8c07fd4ebc8bfb0cc3e Signed-off-by: Arne Schwabe --- M doc/man-sections/tls-options.rst 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/47/447/3 diff --git a/doc/man-sections/tls-options.rst b/doc/man-sections/tls-options.rst index 908a42a..ad8ca72 100644 --- a/doc/man-sections/tls-options.rst +++ b/doc/man-sections/tls-options.rst @@ -553,7 +553,9 @@ code. --tls-exit - Exit on TLS negotiation failure. + Exit on TLS negotiation failure. This option can be useful when you only + want to make one attempt at connecting, e.g. in a test or monitoring script. + (OpenVPN's own test suite uses it this way.) --tls-export-cert directory Store the certificates the clients use upon connection to this -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/447?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I93afff2372c4150d6bddc8c07fd4ebc8bfb0cc3e Gerrit-Change-Number: 447 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-MessageType: newpatchset ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XS] Change in openvpn[master]: Document tls-exit option mainly as test option
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/447?usp=email ) Change subject: Document tls-exit option mainly as test option .. Patch Set 2: (2 comments) File doc/man-sections/tls-options.rst: http://gerrit.openvpn.net/c/openvpn/+/447/comment/4d388cf4_11246be5 : PS2, Line 556: Exit on TLS negotiation failure. This option is useful when doing in > Let's try to make the sentence flow better: […] Acknowledged http://gerrit.openvpn.net/c/openvpn/+/447/comment/e69984e2_7bdb0b79 : PS2, Line 558: connecting. (OpenVPN's own t_cltsrv.sh uses it in this way). > "OpenVPN's own test suite" Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/447?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I93afff2372c4150d6bddc8c07fd4ebc8bfb0cc3e Gerrit-Change-Number: 447 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Thu, 30 Nov 2023 15:03:48 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XS] Change in openvpn[master]: Document tls-exit option mainly as test option
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/447?usp=email ) Change subject: Document tls-exit option mainly as test option .. Patch Set 2: Code-Review-1 (3 comments) Patchset: PS2: Text needs work File doc/man-sections/tls-options.rst: http://gerrit.openvpn.net/c/openvpn/+/447/comment/eb8fc4f8_daf925ac : PS2, Line 556: Exit on TLS negotiation failure. This option is useful when doing in Let's try to make the sentence flow better: "This option can be useful when you only want to make one attempt at connecting, e.g. in a test or monitoring script." http://gerrit.openvpn.net/c/openvpn/+/447/comment/d383cfac_d29a9e0b : PS2, Line 558: connecting. (OpenVPN's own t_cltsrv.sh uses it in this way). "OpenVPN's own test suite" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/447?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I93afff2372c4150d6bddc8c07fd4ebc8bfb0cc3e Gerrit-Change-Number: 447 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Tue, 28 Nov 2023 14:18:36 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XS] Change in openvpn[master]: Document tls-exit option mainly as test option
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/447?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by flichtenheld Change subject: Document tls-exit option mainly as test option .. Document tls-exit option mainly as test option Change-Id: I93afff2372c4150d6bddc8c07fd4ebc8bfb0cc3e Signed-off-by: Arne Schwabe --- M doc/man-sections/tls-options.rst 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/47/447/2 diff --git a/doc/man-sections/tls-options.rst b/doc/man-sections/tls-options.rst index 908a42a..82351d9 100644 --- a/doc/man-sections/tls-options.rst +++ b/doc/man-sections/tls-options.rst @@ -553,7 +553,9 @@ code. --tls-exit - Exit on TLS negotiation failure. + Exit on TLS negotiation failure. This option is useful when doing in + some check script or similar and you want to have only attempt at + connecting. (OpenVPN's own t_cltsrv.sh uses it in this way). --tls-export-cert directory Store the certificates the clients use upon connection to this -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/447?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I93afff2372c4150d6bddc8c07fd4ebc8bfb0cc3e Gerrit-Change-Number: 447 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-MessageType: newpatchset ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XS] Change in openvpn[master]: Document tls-exit option mainly as test option
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/447?usp=email ) Change subject: Document tls-exit option mainly as test option .. Patch Set 2: (2 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/447/comment/fd71717e_4dfcdc38 : PS1, Line 9: This option is questionable and I cannot see any reason to actually use it. > t_cltsrv.sh uses it, so I think when claiming it is questionable you should > remove that usage first. Done File Changes.rst: http://gerrit.openvpn.net/c/openvpn/+/447/comment/3268e8cb_33c9d95b : PS1, Line 15: the will otherwise be removed in the future. > "the option will" Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/447?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I93afff2372c4150d6bddc8c07fd4ebc8bfb0cc3e Gerrit-Change-Number: 447 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Tue, 28 Nov 2023 14:03:30 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
