[Openvpn-devel] [XS] Change in openvpn[master]: FreeBSD DCO: repair incoming 'delete peer' notifications in p2p clien...

2025-11-07 Thread cron2 (Code Review) 
Hello flichtenheld, plaisthos,

I'd like you to reexamine a change. Please visit

http://gerrit.openvpn.net/c/openvpn/+/1353?usp=email

to look at the new patch set (#4).

The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld


Change subject: FreeBSD DCO: repair incoming 'delete peer' notifications in p2p 
client mode
..

FreeBSD DCO: repair incoming 'delete peer' notifications in p2p client mode

commit 4a48841da2 introduced a workaround for spurious DCO notifications
"with no useful content" on Linux - namely, ignoring dco_message_type==0
in forward.c, process_incoming_dco(), "because Linux has no message
type 0 anyway".

Each DCO platform uses its own enum for these notification messages
*inside* OpenVPN (which might not have the best design decision ever),
and FreeBSD had OVPN_CMD_DEL_PEER in the enum on "position 0"...

Fix by changing the enum to start with 1.  Tested with DEL_PEER in p2p
client and DEL_PEER & FLOAT in p2mp server mode.

v2:
  introduce OVPN_CMD_NO_MESSAGE in position 0, and a comment explaining why.
  A future commit can then clean up forward.c and dco_linux.c to use the
  constant, and not "magic 0 which happens to be in there after CLEAR()".

Github: fixes OpenVPN/openvpn#881

Change-Id: I991d6053776efed771bc1a3880acb80b55959cbc
Signed-off-by: Gert Doering 
Acked-by: Frank Lichtenheld 
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1353
Message-Id: <[email protected]>
URL: 
https://www.mail-archive.com/[email protected]/msg34237.html
Signed-off-by: Gert Doering 
---
M src/openvpn/dco_freebsd.h
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/53/1353/4

diff --git a/src/openvpn/dco_freebsd.h b/src/openvpn/dco_freebsd.h
index 0797b82..5e2a552 100644
--- a/src/openvpn/dco_freebsd.h
+++ b/src/openvpn/dco_freebsd.h
@@ -33,6 +33,8 @@

 enum ovpn_message_type_t
 {
+/* message type #0 is treated as magic number by process_incoming_dco() */
+OVPN_CMD_NO_MESSAGE = 0,
 OVPN_CMD_DEL_PEER,
 OVPN_CMD_PACKET,
 OVPN_CMD_SWAP_KEYS,

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1353?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I991d6053776efed771bc1a3880acb80b55959cbc
Gerrit-Change-Number: 1353
Gerrit-PatchSet: 4
Gerrit-Owner: cron2 
Gerrit-Reviewer: flichtenheld 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
___
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [XS] Change in openvpn[master]: FreeBSD DCO: repair incoming 'delete peer' notifications in p2p clien...

2025-11-07 Thread cron2 (Code Review) 
cron2 has submitted this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/1353?usp=email )

Change subject: FreeBSD DCO: repair incoming 'delete peer' notifications in p2p 
client mode
..

FreeBSD DCO: repair incoming 'delete peer' notifications in p2p client mode

commit 4a48841da2 introduced a workaround for spurious DCO notifications
"with no useful content" on Linux - namely, ignoring dco_message_type==0
in forward.c, process_incoming_dco(), "because Linux has no message
type 0 anyway".

Each DCO platform uses its own enum for these notification messages
*inside* OpenVPN (which might not have the best design decision ever),
and FreeBSD had OVPN_CMD_DEL_PEER in the enum on "position 0"...

Fix by changing the enum to start with 1.  Tested with DEL_PEER in p2p
client and DEL_PEER & FLOAT in p2mp server mode.

v2:
  introduce OVPN_CMD_NO_MESSAGE in position 0, and a comment explaining why.
  A future commit can then clean up forward.c and dco_linux.c to use the
  constant, and not "magic 0 which happens to be in there after CLEAR()".

Github: fixes OpenVPN/openvpn#881

Change-Id: I991d6053776efed771bc1a3880acb80b55959cbc
Signed-off-by: Gert Doering 
Acked-by: Frank Lichtenheld 
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1353
Message-Id: <[email protected]>
URL: 
https://www.mail-archive.com/[email protected]/msg34237.html
Signed-off-by: Gert Doering 
---
M src/openvpn/dco_freebsd.h
1 file changed, 2 insertions(+), 0 deletions(-)




diff --git a/src/openvpn/dco_freebsd.h b/src/openvpn/dco_freebsd.h
index 0797b82..5e2a552 100644
--- a/src/openvpn/dco_freebsd.h
+++ b/src/openvpn/dco_freebsd.h
@@ -33,6 +33,8 @@

 enum ovpn_message_type_t
 {
+/* message type #0 is treated as magic number by process_incoming_dco() */
+OVPN_CMD_NO_MESSAGE = 0,
 OVPN_CMD_DEL_PEER,
 OVPN_CMD_PACKET,
 OVPN_CMD_SWAP_KEYS,

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1353?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I991d6053776efed771bc1a3880acb80b55959cbc
Gerrit-Change-Number: 1353
Gerrit-PatchSet: 4
Gerrit-Owner: cron2 
Gerrit-Reviewer: flichtenheld 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
___
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [XS] Change in openvpn[master]: FreeBSD DCO: repair incoming "delete peer" notifications in p2p clien...

2025-11-07 Thread flichtenheld (Code Review) 
Attention is currently required from: cron2, plaisthos.

flichtenheld has posted comments on this change by cron2. ( 
http://gerrit.openvpn.net/c/openvpn/+/1353?usp=email )

Change subject: FreeBSD DCO: repair incoming "delete peer" notifications in p2p 
client mode
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1353?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I991d6053776efed771bc1a3880acb80b55959cbc
Gerrit-Change-Number: 1353
Gerrit-PatchSet: 3
Gerrit-Owner: cron2 
Gerrit-Reviewer: flichtenheld 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
Gerrit-Attention: plaisthos 
Gerrit-Attention: cron2 
Gerrit-Comment-Date: Fri, 07 Nov 2025 14:13:08 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
___
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [XS] Change in openvpn[master]: FreeBSD DCO: repair incoming "delete peer" notifications in p2p clien...

2025-11-07 Thread cron2 (Code Review) 
Attention is currently required from: flichtenheld, plaisthos.

cron2 has posted comments on this change by cron2. ( 
http://gerrit.openvpn.net/c/openvpn/+/1353?usp=email )

Change subject: FreeBSD DCO: repair incoming "delete peer" notifications in p2p 
client mode
..


Patch Set 3:

(1 comment)

File src/openvpn/dco_freebsd.h:

http://gerrit.openvpn.net/c/openvpn/+/1353/comment/399e42cb_cfbf57f1?usp=email :
PS1, Line 36: OVPN_CMD_DEL_PEER = 1,
> Should have some comment why this is required.
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1353?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I991d6053776efed771bc1a3880acb80b55959cbc
Gerrit-Change-Number: 1353
Gerrit-PatchSet: 3
Gerrit-Owner: cron2 
Gerrit-Reviewer: flichtenheld 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
Gerrit-Attention: plaisthos 
Gerrit-Attention: flichtenheld 
Gerrit-Comment-Date: Fri, 07 Nov 2025 13:50:56 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld 
___
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [XS] Change in openvpn[master]: FreeBSD DCO: repair incoming "delete peer" notifications in p2p clien...

2025-11-07 Thread cron2 (Code Review) 
Attention is currently required from: cron2, flichtenheld, plaisthos.

Hello flichtenheld, plaisthos,

I'd like you to reexamine a change. Please visit

http://gerrit.openvpn.net/c/openvpn/+/1353?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Code-Review-1 by flichtenheld


Change subject: FreeBSD DCO: repair incoming "delete peer" notifications in p2p 
client mode
..

FreeBSD DCO: repair incoming "delete peer" notifications in p2p client mode

commit 4a48841da2 introduced a workaround for spurious DCO notifications
"with no useful content" on Linux - namely, ignoring dco_message_type==0
in forward.c, process_incoming_dco(), "because Linux has no message
type 0 anyway".

Each DCO platform uses its own enum for these notification messages
*inside* OpenVPN (which might not have the best design decision ever),
and FreeBSD had OVPN_CMD_DEL_PEER in the enum on "position 0"...

Fix by changing the enum to start with 1.  Tested with DEL_PEER in p2p
client and DEL_PEER & FLOAT in p2mp server mode.

v2:
  introduce OVPN_CMD_NO_MESSAGE in position 0, and a comment explaining why.
  A future commit can then clean up forward.c and dco_linux.c to use the
  constant, and not "magic 0 which happens to be in there after CLEAR()".

Github: fixes OpenVPN/openvpn#881

Change-Id: I991d6053776efed771bc1a3880acb80b55959cbc
Signed-off-by: Gert Doering 
---
M src/openvpn/dco_freebsd.h
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/53/1353/2

diff --git a/src/openvpn/dco_freebsd.h b/src/openvpn/dco_freebsd.h
index 0797b82..5e2a552 100644
--- a/src/openvpn/dco_freebsd.h
+++ b/src/openvpn/dco_freebsd.h
@@ -33,6 +33,8 @@

 enum ovpn_message_type_t
 {
+/* message type #0 is treated as magic number by process_incoming_dco() */
+OVPN_CMD_NO_MESSAGE = 0,
 OVPN_CMD_DEL_PEER,
 OVPN_CMD_PACKET,
 OVPN_CMD_SWAP_KEYS,

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1353?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I991d6053776efed771bc1a3880acb80b55959cbc
Gerrit-Change-Number: 1353
Gerrit-PatchSet: 2
Gerrit-Owner: cron2 
Gerrit-Reviewer: flichtenheld 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
Gerrit-Attention: plaisthos 
Gerrit-Attention: cron2 
Gerrit-Attention: flichtenheld 
___
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [XS] Change in openvpn[master]: FreeBSD DCO: repair incoming "delete peer" notifications in p2p clien...

2025-11-07 Thread flichtenheld (Code Review) 
Attention is currently required from: cron2, plaisthos.

flichtenheld has posted comments on this change by cron2. ( 
http://gerrit.openvpn.net/c/openvpn/+/1353?usp=email )

Change subject: FreeBSD DCO: repair incoming "delete peer" notifications in p2p 
client mode
..


Patch Set 1: Code-Review-1

(1 comment)

File src/openvpn/dco_freebsd.h:

http://gerrit.openvpn.net/c/openvpn/+/1353/comment/361a0454_0355a257?usp=email :
PS1, Line 36: OVPN_CMD_DEL_PEER = 1,
Should have some comment why this is required.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1353?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I991d6053776efed771bc1a3880acb80b55959cbc
Gerrit-Change-Number: 1353
Gerrit-PatchSet: 1
Gerrit-Owner: cron2 
Gerrit-Reviewer: flichtenheld 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
Gerrit-Attention: plaisthos 
Gerrit-Attention: cron2 
Gerrit-Comment-Date: Fri, 07 Nov 2025 13:29:03 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
___
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [XS] Change in openvpn[master]: FreeBSD DCO: repair incoming "delete peer" notifications in p2p clien...

2025-11-06 Thread cron2 (Code Review) 
Attention is currently required from: flichtenheld, plaisthos.

Hello plaisthos, flichtenheld,

I'd like you to do a code review.
Please visit

http://gerrit.openvpn.net/c/openvpn/+/1353?usp=email

to review the following change.


Change subject: FreeBSD DCO: repair incoming "delete peer" notifications in p2p 
client mode
..

FreeBSD DCO: repair incoming "delete peer" notifications in p2p client mode

commit 4a48841da2 introduced a workaround for spurious DCO notifications
"with no useful content" on Linux - namely, ignoring dco_message_type==0
in forward.c, process_incoming_dco(), "because Linux has no message
type 0 anyway".

Each DCO platform uses its own enum for these notification messages
*inside* OpenVPN (which might not have the best design decision ever),
and FreeBSD had OVPN_CMD_DEL_PEER in the enum on "position 0"...

Fix by changing the enum to start with 1.  Tested with DEL_PEER in p2p
client and DEL_PEER & FLOAT in p2mp server mode.

Github: fixes OpenVPN/openvpn#881

Change-Id: I991d6053776efed771bc1a3880acb80b55959cbc
Signed-off-by: Gert Doering 
---
M src/openvpn/dco_freebsd.h
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/53/1353/1

diff --git a/src/openvpn/dco_freebsd.h b/src/openvpn/dco_freebsd.h
index 0797b82..207795f 100644
--- a/src/openvpn/dco_freebsd.h
+++ b/src/openvpn/dco_freebsd.h
@@ -33,7 +33,7 @@

 enum ovpn_message_type_t
 {
-OVPN_CMD_DEL_PEER,
+OVPN_CMD_DEL_PEER = 1,
 OVPN_CMD_PACKET,
 OVPN_CMD_SWAP_KEYS,
 OVPN_CMD_FLOAT_PEER,

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1353?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I991d6053776efed771bc1a3880acb80b55959cbc
Gerrit-Change-Number: 1353
Gerrit-PatchSet: 1
Gerrit-Owner: cron2 
Gerrit-Reviewer: flichtenheld 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
Gerrit-Attention: plaisthos 
Gerrit-Attention: flichtenheld 
___
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel