[Openvpn-devel] [XS] Change in openvpn[master]: Remove unused function prototype crypto_adjust_frame_parameters
cron2 has uploaded a new patch set (#2) to the change originally created by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/451?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: Remove unused function prototype crypto_adjust_frame_parameters .. Remove unused function prototype crypto_adjust_frame_parameters Change-Id: I1141eb7740d8900ed4af0ff5ff52aa3659df99aa Acked-by: Frank Lichtenheld Message-Id: <20231121104037.15307-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27524.html Signed-off-by: Gert Doering --- M src/openvpn/crypto.h 1 file changed, 0 insertions(+), 6 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/51/451/2 diff --git a/src/openvpn/crypto.h b/src/openvpn/crypto.h index c5fd253..9255d38 100644 --- a/src/openvpn/crypto.h +++ b/src/openvpn/crypto.h @@ -429,12 +429,6 @@ struct gc_arena *gc); -/** Calculate crypto overhead and adjust frame to account for that */ -void crypto_adjust_frame_parameters(struct frame *frame, -const struct key_type *kt, -bool packet_id, -bool packet_id_long_form); - /** Calculate the maximum overhead that our encryption has * on a packet. This does not include needed additional buffer size * -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/451?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1141eb7740d8900ed4af0ff5ff52aa3659df99aa Gerrit-Change-Number: 451 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XS] Change in openvpn[master]: Remove unused function prototype crypto_adjust_frame_parameters
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/451?usp=email ) Change subject: Remove unused function prototype crypto_adjust_frame_parameters .. Remove unused function prototype crypto_adjust_frame_parameters Change-Id: I1141eb7740d8900ed4af0ff5ff52aa3659df99aa Acked-by: Frank Lichtenheld Message-Id: <20231121104037.15307-1-fr...@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27524.html Signed-off-by: Gert Doering --- M src/openvpn/crypto.h 1 file changed, 0 insertions(+), 6 deletions(-) diff --git a/src/openvpn/crypto.h b/src/openvpn/crypto.h index c5fd253..9255d38 100644 --- a/src/openvpn/crypto.h +++ b/src/openvpn/crypto.h @@ -429,12 +429,6 @@ struct gc_arena *gc); -/** Calculate crypto overhead and adjust frame to account for that */ -void crypto_adjust_frame_parameters(struct frame *frame, -const struct key_type *kt, -bool packet_id, -bool packet_id_long_form); - /** Calculate the maximum overhead that our encryption has * on a packet. This does not include needed additional buffer size * -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/451?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1141eb7740d8900ed4af0ff5ff52aa3659df99aa Gerrit-Change-Number: 451 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-MessageType: merged ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XS] Change in openvpn[master]: Remove unused function prototype crypto_adjust_frame_parameters
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/451?usp=email ) Change subject: Remove unused function prototype crypto_adjust_frame_parameters .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/451?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1141eb7740d8900ed4af0ff5ff52aa3659df99aa Gerrit-Change-Number: 451 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Mon, 20 Nov 2023 11:58:27 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XS] Change in openvpn[master]: Remove unused function prototype crypto_adjust_frame_parameters
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/451?usp=email to review the following change. Change subject: Remove unused function prototype crypto_adjust_frame_parameters .. Remove unused function prototype crypto_adjust_frame_parameters Change-Id: I1141eb7740d8900ed4af0ff5ff52aa3659df99aa --- M src/openvpn/crypto.h 1 file changed, 0 insertions(+), 6 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/51/451/1 diff --git a/src/openvpn/crypto.h b/src/openvpn/crypto.h index c5fd253..9255d38 100644 --- a/src/openvpn/crypto.h +++ b/src/openvpn/crypto.h @@ -429,12 +429,6 @@ struct gc_arena *gc); -/** Calculate crypto overhead and adjust frame to account for that */ -void crypto_adjust_frame_parameters(struct frame *frame, -const struct key_type *kt, -bool packet_id, -bool packet_id_long_form); - /** Calculate the maximum overhead that our encryption has * on a packet. This does not include needed additional buffer size * -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/451?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1141eb7740d8900ed4af0ff5ff52aa3659df99aa Gerrit-Change-Number: 451 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-MessageType: newchange ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel