[Openvpn-devel] [XS] Change in openvpn[master]: cmake: build native binaries with debug info

2023-12-18 Thread d12fk (Code Review)
d12fk has abandoned this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/484?usp=email )

Change subject: cmake: build native binaries with debug info
..


Abandoned
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/484?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I5d835f37d9b75a2eba39504e673597cf7b6f8989
Gerrit-Change-Number: 484
Gerrit-PatchSet: 2
Gerrit-Owner: d12fk 
Gerrit-Reviewer: flichtenheld 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
Gerrit-MessageType: abandon
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel


[Openvpn-devel] [XS] Change in openvpn[master]: cmake: build native binaries with debug info

2023-12-18 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos.

d12fk has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/484?usp=email )

Change subject: cmake: build native binaries with debug info
..


Patch Set 2:

(1 comment)

Patchset:

PS2:
> unix-native uses a Ninja Multi-Config generator so it can build all the 
> configs in parallel. […]
Hm, the issue is that the cmake-tools extension for vscode doesn't deal with 
ninja at all. The generator are treated as just that, so they are not visible 
in the UI to select profiles from. However, I can add that to 
CMakeUserPresets.txt for my usecase.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/484?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I5d835f37d9b75a2eba39504e673597cf7b6f8989
Gerrit-Change-Number: 484
Gerrit-PatchSet: 2
Gerrit-Owner: d12fk 
Gerrit-Reviewer: flichtenheld 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
Gerrit-Attention: plaisthos 
Gerrit-Attention: flichtenheld 
Gerrit-Comment-Date: Mon, 18 Dec 2023 11:52:35 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld 
Gerrit-MessageType: comment
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel


[Openvpn-devel] [XS] Change in openvpn[master]: cmake: build native binaries with debug info

2023-12-18 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk, plaisthos.

flichtenheld has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/484?usp=email )

Change subject: cmake: build native binaries with debug info
..


Patch Set 2: Code-Review-2

(1 comment)

Patchset:

PS2:
unix-native uses a Ninja Multi-Config generator so it can build all the configs 
in parallel. So choose the config you want instead of hard-coding it.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/484?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I5d835f37d9b75a2eba39504e673597cf7b6f8989
Gerrit-Change-Number: 484
Gerrit-PatchSet: 2
Gerrit-Owner: d12fk 
Gerrit-Reviewer: flichtenheld 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
Gerrit-Attention: plaisthos 
Gerrit-Attention: d12fk 
Gerrit-Comment-Date: Mon, 18 Dec 2023 11:12:10 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel


[Openvpn-devel] [XS] Change in openvpn[master]: cmake: build native binaries with debug info

2023-12-16 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos.

Hello plaisthos, flichtenheld,

I'd like you to do a code review.
Please visit

http://gerrit.openvpn.net/c/openvpn/+/484?usp=email

to review the following change.


Change subject: cmake: build native binaries with debug info
..

cmake: build native binaries with debug info

Since the cmake unix builds are not the officially supported way to
build openvpn, it makes sense to always do debug builds for during
development.

Change-Id: I5d835f37d9b75a2eba39504e673597cf7b6f8989
Signed-off-by: Heiko Hund 
---
M CMakePresets.json
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/84/484/1

diff --git a/CMakePresets.json b/CMakePresets.json
index 135b19d..46aeeef 100644
--- a/CMakePresets.json
+++ b/CMakePresets.json
@@ -199,8 +199,9 @@
 "configuration": "Debug"
 },
 {
-"name": "unix-native",
-"configurePreset": "unix-native"
+"name": "unix-native-debug",
+"configurePreset": "unix-native",
+"configuration": "Debug"
 }
 ],
 "testPresets": [

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/484?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I5d835f37d9b75a2eba39504e673597cf7b6f8989
Gerrit-Change-Number: 484
Gerrit-PatchSet: 1
Gerrit-Owner: d12fk 
Gerrit-Reviewer: flichtenheld 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
Gerrit-Attention: plaisthos 
Gerrit-Attention: flichtenheld 
Gerrit-MessageType: newchange
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel