[Openvpn-devel] [XS] Change in openvpn[master]: multi: Fix wrong usage of mroute_extract_openvpn_sockaddr

2025-10-21 Thread cron2 (Code Review) 
cron2 has uploaded a new patch set (#3) to the change originally created by 
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1292?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by cron2, Code-Review+2 by its_Giaan


Change subject: multi: Fix wrong usage of mroute_extract_openvpn_sockaddr
..

multi: Fix wrong usage of mroute_extract_openvpn_sockaddr

maddr.proto needs to be set before the call since that
will change the behavior.

Found by GCC "'maddr.proto' is used uninitialized"

Change-Id: I76babf08b041162ddedf7a9b7c2799847f15cbdc
Signed-off-by: Frank Lichtenheld 
Acked-by: Gert Doering 
Acked-by: Gianmarco De Gregori 
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1292
Message-Id: <[email protected]>
URL: 
https://www.mail-archive.com/[email protected]/msg33830.html
Signed-off-by: Gert Doering 
---
M src/openvpn/multi.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/92/1292/3

diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c
index e907524..fa9c654 100644
--- a/src/openvpn/multi.c
+++ b/src/openvpn/multi.c
@@ -3965,9 +3965,9 @@
 saddr.addr.in4.sin_family = AF_INET;
 saddr.addr.in4.sin_addr.s_addr = htonl(addr);
 saddr.addr.in4.sin_port = htons(port);
+maddr.proto = proto;
 if (mroute_extract_openvpn_sockaddr(&maddr, &saddr, true))
 {
-maddr.proto = proto;
 hash_iterator_init(m->iter, &hi);
 while ((he = hash_iterator_next(&hi)))
 {

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1292?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I76babf08b041162ddedf7a9b7c2799847f15cbdc
Gerrit-Change-Number: 1292
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld 
Gerrit-Reviewer: cron2 
Gerrit-Reviewer: its_Giaan 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
___
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [XS] Change in openvpn[master]: multi: Fix wrong usage of mroute_extract_openvpn_sockaddr

2025-10-21 Thread cron2 (Code Review) 
cron2 has submitted this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/1292?usp=email )

Change subject: multi: Fix wrong usage of mroute_extract_openvpn_sockaddr
..

multi: Fix wrong usage of mroute_extract_openvpn_sockaddr

maddr.proto needs to be set before the call since that
will change the behavior.

Found by GCC "'maddr.proto' is used uninitialized"

Change-Id: I76babf08b041162ddedf7a9b7c2799847f15cbdc
Signed-off-by: Frank Lichtenheld 
Acked-by: Gert Doering 
Acked-by: Gianmarco De Gregori 
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1292
Message-Id: <[email protected]>
URL: 
https://www.mail-archive.com/[email protected]/msg33830.html
Signed-off-by: Gert Doering 
---
M src/openvpn/multi.c
1 file changed, 1 insertion(+), 1 deletion(-)




diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c
index e907524..fa9c654 100644
--- a/src/openvpn/multi.c
+++ b/src/openvpn/multi.c
@@ -3965,9 +3965,9 @@
 saddr.addr.in4.sin_family = AF_INET;
 saddr.addr.in4.sin_addr.s_addr = htonl(addr);
 saddr.addr.in4.sin_port = htons(port);
+maddr.proto = proto;
 if (mroute_extract_openvpn_sockaddr(&maddr, &saddr, true))
 {
-maddr.proto = proto;
 hash_iterator_init(m->iter, &hi);
 while ((he = hash_iterator_next(&hi)))
 {

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1292?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I76babf08b041162ddedf7a9b7c2799847f15cbdc
Gerrit-Change-Number: 1292
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld 
Gerrit-Reviewer: cron2 
Gerrit-Reviewer: its_Giaan 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
___
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [XS] Change in openvpn[master]: multi: Fix wrong usage of mroute_extract_openvpn_sockaddr

2025-10-21 Thread cron2 (Code Review) 
Attention is currently required from: flichtenheld, plaisthos.

cron2 has posted comments on this change by flichtenheld. ( 
http://gerrit.openvpn.net/c/openvpn/+/1292?usp=email )

Change subject: multi: Fix wrong usage of mroute_extract_openvpn_sockaddr
..


Patch Set 2: Code-Review+2

(1 comment)

Patchset:

PS2:
Oh, sorry.  That was a gerrit comparison artefact.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1292?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I76babf08b041162ddedf7a9b7c2799847f15cbdc
Gerrit-Change-Number: 1292
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld 
Gerrit-Reviewer: cron2 
Gerrit-Reviewer: its_Giaan 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
Gerrit-Attention: plaisthos 
Gerrit-Attention: flichtenheld 
Gerrit-Comment-Date: Tue, 21 Oct 2025 19:31:15 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
___
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [XS] Change in openvpn[master]: multi: Fix wrong usage of mroute_extract_openvpn_sockaddr

2025-10-21 Thread cron2 (Code Review) 
Attention is currently required from: flichtenheld, plaisthos.

cron2 has posted comments on this change by flichtenheld. ( 
http://gerrit.openvpn.net/c/openvpn/+/1292?usp=email )

Change subject: multi: Fix wrong usage of mroute_extract_openvpn_sockaddr
..


Patch Set 2: Code-Review-2

(1 comment)

Patchset:

PS2:
v2 has some stuff in there that doesn't belong here (push.c, ssl_verify.c 
integers)



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1292?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I76babf08b041162ddedf7a9b7c2799847f15cbdc
Gerrit-Change-Number: 1292
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld 
Gerrit-Reviewer: cron2 
Gerrit-Reviewer: its_Giaan 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
Gerrit-Attention: plaisthos 
Gerrit-Attention: flichtenheld 
Gerrit-Comment-Date: Tue, 21 Oct 2025 19:30:38 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
___
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [XS] Change in openvpn[master]: multi: Fix wrong usage of mroute_extract_openvpn_sockaddr

2025-10-21 Thread flichtenheld (Code Review) 
Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to reexamine a change. Please visit

http://gerrit.openvpn.net/c/openvpn/+/1292?usp=email

to look at the new patch set (#2).


Change subject: multi: Fix wrong usage of mroute_extract_openvpn_sockaddr
..

multi: Fix wrong usage of mroute_extract_openvpn_sockaddr

maddr.proto needs to be set before the call since that
will change the behavior.

Found by GCC "'maddr.proto' is used uninitialized"

Change-Id: I76babf08b041162ddedf7a9b7c2799847f15cbdc
Signed-off-by: Frank Lichtenheld 
---
M src/openvpn/multi.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/92/1292/2

diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c
index e907524..fa9c654 100644
--- a/src/openvpn/multi.c
+++ b/src/openvpn/multi.c
@@ -3965,9 +3965,9 @@
 saddr.addr.in4.sin_family = AF_INET;
 saddr.addr.in4.sin_addr.s_addr = htonl(addr);
 saddr.addr.in4.sin_port = htons(port);
+maddr.proto = proto;
 if (mroute_extract_openvpn_sockaddr(&maddr, &saddr, true))
 {
-maddr.proto = proto;
 hash_iterator_init(m->iter, &hi);
 while ((he = hash_iterator_next(&hi)))
 {

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1292?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I76babf08b041162ddedf7a9b7c2799847f15cbdc
Gerrit-Change-Number: 1292
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
Gerrit-Attention: plaisthos 
___
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

[Openvpn-devel] [XS] Change in openvpn[master]: multi: Fix wrong usage of mroute_extract_openvpn_sockaddr

2025-10-21 Thread its_Giaan (Code Review) 
Attention is currently required from: flichtenheld, plaisthos.

its_Giaan has posted comments on this change by flichtenheld. ( 
http://gerrit.openvpn.net/c/openvpn/+/1292?usp=email )

Change subject: multi: Fix wrong usage of mroute_extract_openvpn_sockaddr
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1292?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I76babf08b041162ddedf7a9b7c2799847f15cbdc
Gerrit-Change-Number: 1292
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld 
Gerrit-Reviewer: its_Giaan 
Gerrit-Reviewer: plaisthos 
Gerrit-CC: openvpn-devel 
Gerrit-Attention: plaisthos 
Gerrit-Attention: flichtenheld 
Gerrit-Comment-Date: Tue, 21 Oct 2025 17:35:41 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
___
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel