[Openvpn-devel] [XS] Change in openvpn[release/2.6]: CONTRIBUTING: add Gerrit option + links
Attention is currently required from: flichtenheld, plaisthos, uddr. chesain has posted comments on this change by chesain. ( http://gerrit.openvpn.net/c/openvpn/+/1338?usp=email ) Change subject: CONTRIBUTING: add Gerrit option + links .. Patch Set 2: (1 comment) File CONTRIBUTING.rst: http://gerrit.openvpn.net/c/openvpn/+/1338/comment/fea2190d_8ddbce6b?usp=email : PS1, Line 13: - Create account: https://gerrit.openvpn.net/pwm/public/newuser > We are about to change Gerrit auth method so this will have to wait when we > can describe it here. Understood, I went ahead and removed that line -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1338?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: Ifb4e9d79c167337fb780b53141d080abf55f3f5e Gerrit-Change-Number: 1338 Gerrit-PatchSet: 2 Gerrit-Owner: chesain Gerrit-Reviewer: chesain Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: uddr Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: uddr Gerrit-Comment-Date: Fri, 07 Nov 2025 22:21:08 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: uddr ___ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XS] Change in openvpn[release/2.6]: CONTRIBUTING: add Gerrit option + links
Attention is currently required from: chesain, flichtenheld, plaisthos, uddr. Hello flichtenheld, plaisthos, uddr, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1338?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by uddr Change subject: CONTRIBUTING: add Gerrit option + links .. CONTRIBUTING: add Gerrit option + links - Add Gerrit as an alternative review path - Add links: signup, web UI, best practices - Final patches still go to openvpn-devel Change-Id: Ifb4e9d79c167337fb780b53141d080abf55f3f5e Signed-off-by: chesain Refs: openvpn/openvpn#845 Link: https://github.com/OpenVPN/openvpn/issues/845 --- M CONTRIBUTING.rst 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/38/1338/2 diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index 67baa4e..e7afeafe 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -8,6 +8,13 @@ - https://lists.sourceforge.net/lists/listinfo/openvpn-devel +Alternatively, you can use Gerrit for code review: + +- Web UI: https://gerrit.openvpn.net/ +- Best practices & account setup: https://community.openvpn.net/Development/GerritBestPractices + +Note: final, approved patches are still sent to the mailing list. + While we do not merge GitHub pull requests as-is, we do allow their use for code review purposes. After the patch has been ACKed (reviewed and accepted), it must be sent to the mailing list. This last step does not necessarily need to be done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1338?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: Ifb4e9d79c167337fb780b53141d080abf55f3f5e Gerrit-Change-Number: 1338 Gerrit-PatchSet: 2 Gerrit-Owner: chesain Gerrit-Reviewer: chesain Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: uddr Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: uddr Gerrit-Attention: chesain ___ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XS] Change in openvpn[release/2.6]: CONTRIBUTING: add Gerrit option + links
Attention is currently required from: chesain, flichtenheld, plaisthos. uddr has posted comments on this change by chesain. ( http://gerrit.openvpn.net/c/openvpn/+/1338?usp=email ) Change subject: CONTRIBUTING: add Gerrit option + links .. Patch Set 1: Code-Review-1 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1338?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: Ifb4e9d79c167337fb780b53141d080abf55f3f5e Gerrit-Change-Number: 1338 Gerrit-PatchSet: 1 Gerrit-Owner: chesain Gerrit-Reviewer: chesain Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: uddr Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: chesain Gerrit-Comment-Date: Mon, 03 Nov 2025 07:59:05 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes ___ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XS] Change in openvpn[release/2.6]: CONTRIBUTING: add Gerrit option + links
Attention is currently required from: chesain, flichtenheld, plaisthos. uddr has posted comments on this change by chesain. ( http://gerrit.openvpn.net/c/openvpn/+/1338?usp=email ) Change subject: CONTRIBUTING: add Gerrit option + links .. Patch Set 1: Code-Review+2 (1 comment) File CONTRIBUTING.rst: http://gerrit.openvpn.net/c/openvpn/+/1338/comment/0fa52e9b_bf3b9512?usp=email : PS1, Line 13: - Create account: https://gerrit.openvpn.net/pwm/public/newuser We are about to change Gerrit auth method so this will have to wait when we can describe it here. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1338?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: Ifb4e9d79c167337fb780b53141d080abf55f3f5e Gerrit-Change-Number: 1338 Gerrit-PatchSet: 1 Gerrit-Owner: chesain Gerrit-Reviewer: chesain Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: uddr Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: chesain Gerrit-Comment-Date: Mon, 03 Nov 2025 07:42:09 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes ___ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XS] Change in openvpn[release/2.6]: CONTRIBUTING: add Gerrit option + links
Attention is currently required from: flichtenheld, plaisthos. chesain has removed a vote from this change. ( http://gerrit.openvpn.net/c/openvpn/+/1338?usp=email ) Change subject: CONTRIBUTING: add Gerrit option + links .. Removed Code-Review+2 by chesain -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1338?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: deleteVote Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: Ifb4e9d79c167337fb780b53141d080abf55f3f5e Gerrit-Change-Number: 1338 Gerrit-PatchSet: 1 Gerrit-Owner: chesain Gerrit-Reviewer: chesain Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld ___ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XS] Change in openvpn[release/2.6]: CONTRIBUTING: add Gerrit option + links
Attention is currently required from: flichtenheld, plaisthos. chesain has posted comments on this change by chesain. ( http://gerrit.openvpn.net/c/openvpn/+/1338?usp=email ) Change subject: CONTRIBUTING: add Gerrit option + links .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1338?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: Ifb4e9d79c167337fb780b53141d080abf55f3f5e Gerrit-Change-Number: 1338 Gerrit-PatchSet: 1 Gerrit-Owner: chesain Gerrit-Reviewer: chesain Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Sat, 01 Nov 2025 20:34:26 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes ___ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XS] Change in openvpn[release/2.6]: CONTRIBUTING: add Gerrit option + links
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1338?usp=email to review the following change. Change subject: CONTRIBUTING: add Gerrit option + links .. CONTRIBUTING: add Gerrit option + links - Add Gerrit as an alternative review path - Add links: signup, web UI, best practices - Final patches still go to openvpn-devel Change-Id: Ifb4e9d79c167337fb780b53141d080abf55f3f5e Signed-off-by: chesain --- M CONTRIBUTING.rst 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/38/1338/1 diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index 67baa4e..8181aa3 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -8,6 +8,14 @@ - https://lists.sourceforge.net/lists/listinfo/openvpn-devel +Alternatively, you can use Gerrit for code review: + +- Create account: https://gerrit.openvpn.net/pwm/public/newuser +- Web UI: https://gerrit.openvpn.net/ +- Best practices: https://community.openvpn.net/Development/GerritBestPractices + +Note: final, approved patches are still sent to the mailing list. + While we do not merge GitHub pull requests as-is, we do allow their use for code review purposes. After the patch has been ACKed (reviewed and accepted), it must be sent to the mailing list. This last step does not necessarily need to be done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1338?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: Ifb4e9d79c167337fb780b53141d080abf55f3f5e Gerrit-Change-Number: 1338 Gerrit-PatchSet: 1 Gerrit-Owner: chesain Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld ___ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
