Re: [Openvpn-devel] [PATCH] Check --ncp-ciphers list on startup

2016-10-12 Thread Steffan Karger
On 11 October 2016 at 22:11, Selva Nair wrote: > To nit-pick, Yes, please! > On Tue, Oct 11, 2016 at 3:35 PM, Steffan Karger wrote: >> >> +bool >> +tls_check_ncp_cipher_list(const char *list) { >> + char *tmp_ciphers = string_alloc (list, NULL); >> + char *tmp_ciphers_orig = tmp_ciphers; >> +

Re: [Openvpn-devel] [PATCH] Check --ncp-ciphers list on startup

2016-10-11 Thread Selva Nair
Hi, To nit-pick, On Tue, Oct 11, 2016 at 3:35 PM, Steffan Karger wrote: > +bool > +tls_check_ncp_cipher_list(const char *list) { > + char *tmp_ciphers = string_alloc (list, NULL); > + char *tmp_ciphers_orig = tmp_ciphers; > + bool unsupported_cipher_found = false; > + > + const char *token