Re: [Openvpn-devel] [PATCH] crypto.c: fix Visual Studio build

2019-07-24 Thread Arne Schwabe
Am 18.07.19 um 11:35 schrieb Lev Stipakov: > From: Lev Stipakov > > Commit fb4e8ab added variable-length array which > is C99 feature and is not supported by Visual Studio. > > This removes VLA and writes data directly into passed buffer. > After some confusion of the various buffer related fu

Re: [Openvpn-devel] [PATCH] crypto.c: fix Visual Studio build

2019-07-18 Thread Antonio Quartulli
On 18/07/2019 14:20, Lev Stipakov wrote: > Hi, > > >> Are we sure we can't call this function with 'len' longer than the >> available space in 'key' ? > > > Yep, because we get available space here: > >> +const int len = BCAP(key); >> > > and then pass it to rand_bytes: > Ok, that so

Re: [Openvpn-devel] [PATCH] crypto.c: fix Visual Studio build

2019-07-18 Thread Lev Stipakov
Hi, > Are we sure we can't call this function with 'len' longer than the > available space in 'key' ? Yep, because we get available space here: > +const int len = BCAP(key); > and then pass it to rand_bytes: > > +if (!rand_bytes(BEND(key), len)) -- -Lev __

Re: [Openvpn-devel] [PATCH] crypto.c: fix Visual Studio build

2019-07-18 Thread Antonio Quartulli
Hi, On 18/07/2019 11:35, Lev Stipakov wrote: > From: Lev Stipakov > > Commit fb4e8ab added variable-length array which > is C99 feature and is not supported by Visual Studio. > > This removes VLA and writes data directly into passed buffer. > > Signed-off-by: Lev Stipakov > --- > src/openvpn