Re: [Openvpn-devel] [PATCH 2/5] Prevent __stdcall name mangling of MSVC

2018-11-09 Thread Jon Kunkee via Openvpn-devel
Hi Jon, >> This approach keeps 'goes in DLL' next to the function itself, which I >> like. > > It's ugly but it keeps both building systems happy and produces consistent > DLL file. Fantastic. I'm sorry there isn't a more elegant solution, but I'm glad there's something that works. > I had to

Re: [Openvpn-devel] [PATCH 2/5] Prevent __stdcall name mangling of MSVC

2018-11-09 Thread Simon Rozman
Hi Jon, > This approach keeps 'goes in DLL' next to the function itself, which I > like. If you're interested, another possible approach here is to use > .DEF files with MSVC, which can also do symbol aliasing: > https://docs.microsoft.com/en-us/cpp/build/exporting-from-a-dll-using- > def-files >

Re: [Openvpn-devel] [PATCH 2/5] Prevent __stdcall name mangling of MSVC

2018-11-08 Thread Jon Kunkee via Openvpn-devel
Hi Simon, This approach keeps 'goes in DLL' next to the function itself, which I like. If you're interested, another possible approach here is to use .DEF files with MSVC, which can also do symbol aliasing: https://docs.microsoft.com/en-us/cpp/build/exporting-from-a-dll-using-def-files I would