Re: [Openvpn-devel] [PATCH 2/5] xmit_hold is only required for port_share

2021-03-31 Thread Antonio Quartulli
Hi, As discussed with Arne in our latest meeting, this patch will be ignored for now. Hope was that the xmit_hold filed could be eventually removed, but it turned out it is actually needed. For this reason there is no real interest at this point to carry on this change. Regards, -- Antonio

Re: [Openvpn-devel] [PATCH 2/5] xmit_hold is only required for port_share

2021-03-30 Thread Antonio Quartulli
Hi, On 25/03/2021 22:55, Antonio Quartulli wrote: > Hi, > > On 25/03/2021 22:37, Antonio Quartulli wrote: >> Anybody can see why we need that for port-share? >> I'd rather try to understand the above and ditch this member entirely, >> if the answer is "we don't need it". > > After more tests I

Re: [Openvpn-devel] [PATCH 2/5] xmit_hold is only required for port_share

2021-03-25 Thread Antonio Quartulli
Hi, On 25/03/2021 22:37, Antonio Quartulli wrote: > Anybody can see why we need that for port-share? > I'd rather try to understand the above and ditch this member entirely, > if the answer is "we don't need it". After more tests I indeed recovered the reason why this is needed with port-share.

Re: [Openvpn-devel] [PATCH 2/5] xmit_hold is only required for port_share

2021-03-25 Thread Antonio Quartulli
Hi, On 26/10/2020 10:49, Arne Schwabe wrote: > Am 24.10.20 um 21:43 schrieb Gert Doering: >> Hi, >> >> On Fri, Oct 23, 2020 at 01:34:28PM +0200, Arne Schwabe wrote: >>> Make options.c only set xmit_hold when port_share is active to least >>> document this dependency. I have not actually tested if

Re: [Openvpn-devel] [PATCH 2/5] xmit_hold is only required for port_share

2020-10-26 Thread Arne Schwabe
Am 24.10.20 um 21:43 schrieb Gert Doering: > Hi, > > On Fri, Oct 23, 2020 at 01:34:28PM +0200, Arne Schwabe wrote: >> Make options.c only set xmit_hold when port_share is active to least >> document this dependency. I have not actually tested if this dependency >> is actually true (or if

Re: [Openvpn-devel] [PATCH 2/5] xmit_hold is only required for port_share

2020-10-24 Thread Gert Doering
Hi, On Fri, Oct 23, 2020 at 01:34:28PM +0200, Arne Schwabe wrote: > Make options.c only set xmit_hold when port_share is active to least > document this dependency. I have not actually tested if this dependency > is actually true (or if port_share could work without xmit_hold). I'm not sure I