Re: [Openvpn-devel] [PATCH 3/3] travis: compile with -Werror on Linux

2019-11-11 Thread Antonio Quartulli
Hi, On 11/11/2019 08:23, Gert Doering wrote: >> But the patch does affect cross-compilation for Windows on linux. > > That seems to have been an oversight in how to feed Travis what we want - > I saw an update yesterday evening. > >> Unless restricted to a very small cross-section (say gcc x.y

Re: [Openvpn-devel] [PATCH 3/3] travis: compile with -Werror on Linux

2019-11-10 Thread Gert Doering
Hi, On Sun, Nov 10, 2019 at 05:03:26PM -0500, Selva Nair wrote: > > the > > > temptation to add -Werror in general and to Windows cross-build in > > > particular. > > > > Yeah, we're not intending to. > > But the patch does affect cross-compilation for Windows on linux. That seems to have been

Re: [Openvpn-devel] [PATCH 3/3] travis: compile with -Werror on Linux

2019-11-10 Thread Selva Nair
Forgot to hit send on this, and probably this is only partially relevant now, but here goes. Hi On Sun, Nov 10, 2019 at 12:03 PM Gert Doering wrote: > Hi, > > On Sun, Nov 10, 2019 at 11:48:16AM -0500, Selva Nair wrote: > > But it seems it may also affect mingw builds on travis. I would resist

Re: [Openvpn-devel] [PATCH 3/3] travis: compile with -Werror on Linux

2019-11-10 Thread Gert Doering
Hi, On Sun, Nov 10, 2019 at 11:48:16AM -0500, Selva Nair wrote: > But it seems it may also affect mingw builds on travis. I would resist the > temptation to add -Werror in general and to Windows cross-build in > particular. Yeah, we're not intending to. The plan is to have "default builds (no

Re: [Openvpn-devel] [PATCH 3/3] travis: compile with -Werror on Linux

2019-11-10 Thread Selva Nair
Hi, On Sun, Nov 10, 2019 at 8:36 AM Antonio Quartulli wrote: > Signed-off-by: Antonio Quartulli > --- > .travis/build-check.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.travis/build-check.sh b/.travis/build-check.sh > index 039a7dcf..250bb454 100755 > ---

Re: [Openvpn-devel] [PATCH 3/3] travis: compile with -Werror on Linux

2019-11-10 Thread Arne Schwabe
Am 10.11.19 um 14:35 schrieb Antonio Quartulli: > Signed-off-by: Antonio Quartulli > --- > .travis/build-check.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.travis/build-check.sh b/.travis/build-check.sh > index 039a7dcf..250bb454 100755 > --- a/.travis/build-check.sh > +++