Re: [Openvpn-devel] [PATCH 4/5] Add MSI custom action for reliable Windows 10 detection

2018-11-13 Thread Jon Kunkee via Openvpn-devel
> I gave the MsiBreak method a quick try, but I couldn't make it work. I have > set MsiBreak as a system environment variable, restarted Windows Installer > service, restarted the shell window from where I invoke msiexec calls to > make sure the environment is updated. But it doesn't pop-up any

Re: [Openvpn-devel] [PATCH 4/5] Add MSI custom action for reliable Windows 10 detection

2018-11-13 Thread Jon Kunkee via Openvpn-devel
> Note a side take-home message: msiexec.exe will never be Windows 10 aware. Unfortunately, yes. > > Let me know if that doesn't make sense or won't work for what you're > > doing. > I am familiar with EXE and manifests, thanks. Nevertheless, I really > appreciate your time to extensively

Re: [Openvpn-devel] [PATCH 4/5] Add MSI custom action for reliable Windows 10 detection

2018-11-12 Thread Simon Rozman
Hi, > > It might be somewhat more convenient to add the PID to the debug > > MessageBox call, but it is probably MUCH more convenient to use the > > CustomAction debugging facility built into the MSI service itself: > > > > https://docs.microsoft.com/en-us/windows/desktop/Msi/debugging-custom- >

Re: [Openvpn-devel] [PATCH 4/5] Add MSI custom action for reliable Windows 10 detection

2018-11-10 Thread Simon Rozman
Hi, > > The post on this link is true for Windows 7 (May 6, 2009). It's 2018 > > now and MSI's property VersionNT got stuck on Windows 8 (602 if I > recall correctly). > > Quite right. I just talked to someone familiar with this here, and, as I > understand it, MSI will never offer a way to do

Re: [Openvpn-devel] [PATCH 4/5] Add MSI custom action for reliable Windows 10 detection

2018-11-09 Thread Jon Kunkee via Openvpn-devel
>> From what I gather, the OS version should be checked in the >> CustomAction's MSI execution conditions instead of in the CustomAction >> itself. The appropriate information can then be passed in based on that: >> >> https://blogs.msdn.microsoft.com/cjacks/2009/05/06/why-custom-actions- >>

Re: [Openvpn-devel] [PATCH 4/5] Add MSI custom action for reliable Windows 10 detection

2018-11-09 Thread Simon Rozman
Hi, > This is painful to read, and I bet it was even more painful to write. I > am sorry it came to this, though it does look like it should(TM) work. I don't blame Microsoft for this mess. Version lies actually solve a lot of problems with legacy software. > From what I gather, the OS version

Re: [Openvpn-devel] [PATCH 4/5] Add MSI custom action for reliable Windows 10 detection

2018-11-08 Thread Jon Kunkee via Openvpn-devel
Hi Simon, This is painful to read, and I bet it was even more painful to write. I am sorry it came to this, though it does look like it should(TM) work. >From what I gather, the OS version should be checked in the CustomAction's MSI execution conditions instead of in the CustomAction itself.