Hi, On 11-08-17 11:07, Antonio Quartulli wrote: > From: Antonio Quartulli <anto...@openvpn.net> > > Signed-off-by: Antonio Quartulli <anto...@openvpn.net> > --- > src/openvpn/misc.c | 23 ----------------------- > src/openvpn/ssl.c | 10 ---------- > src/openvpn/ssl_openssl.c | 6 ------ > 3 files changed, 39 deletions(-) > > diff --git a/src/openvpn/misc.c b/src/openvpn/misc.c > index 07775992..a599fd70 100644 > --- a/src/openvpn/misc.c > +++ b/src/openvpn/misc.c > @@ -448,29 +448,6 @@ construct_name_value(const char *name, const char > *value, struct gc_arena *gc) > return BSTR(&out); > } > > -bool > -deconstruct_name_value(const char *str, const char **name, const char > **value, struct gc_arena *gc) > -{ > - char *cp; > - > - ASSERT(str); > - ASSERT(name && value); > - > - *name = cp = string_alloc(str, gc); > - *value = NULL; > - > - while ((*cp)) > - { > - if (*cp == '=' && !*value) > - { > - *cp = 0; > - *value = cp + 1; > - } > - ++cp; > - } > - return *name && *value; > -} > - > static bool > env_string_equal(const char *s1, const char *s2) > { > diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c > index 45b20e56..460ef9e8 100644 > --- a/src/openvpn/ssl.c > +++ b/src/openvpn/ssl.c > @@ -2177,16 +2177,6 @@ read_string_alloc(struct buffer *buf) > return str; > } > > -void > -read_string_discard(struct buffer *buf) > -{ > - char *data = read_string_alloc(buf); > - if (data) > - { > - free(data); > - } > -} > - > /* > * Handle the reading and writing of key data to and from > * the TLS control channel (cleartext). > diff --git a/src/openvpn/ssl_openssl.c b/src/openvpn/ssl_openssl.c > index 7ad6414e..fa06f068 100644 > --- a/src/openvpn/ssl_openssl.c > +++ b/src/openvpn/ssl_openssl.c > @@ -797,12 +797,6 @@ tls_ctx_load_cert_file(struct tls_root_ctx *ctx, const > char *cert_file, > tls_ctx_load_cert_file_and_copy(ctx, cert_file, cert_file_inline, NULL); > } > > -void > -tls_ctx_free_cert_file(X509 *x509) > -{ > - X509_free(x509); > -} > - > int > tls_ctx_load_priv_file(struct tls_root_ctx *ctx, const char *priv_key_file, > bool priv_key_file_inline) >
Verified that these are indeed not used, and safe to remove. ACK. -Steffan ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel