Re: [Openvpn-devel] [PATCH applied] Re: Add unit tests for engine keys

2020-06-23 Thread James Bottomley
On Wed, 2020-06-24 at 01:18 +0500, Илья Шипицин wrote: [...] > I've added output of log.txt, if you are going to modify "grep" > magic, can you adopt something like that, please ? OK, I folded this into the --enable-small correction James ---8>8>8><8<8<8--- From: James Bottomley Subject:

Re: [Openvpn-devel] [PATCH applied] Re: Add unit tests for engine keys

2020-06-23 Thread Илья Шипицин
ср, 24 июн. 2020 г. в 00:37, Gert Doering : > Hi, > > On Tue, Jun 23, 2020 at 12:32:42PM -0700, James Bottomley wrote: > > > James, are you triggering on specific openvpn messages? "--enable- > > > small" > > > changes these (trimming some warnings and help texts). Can you test > > > with > > >

Re: [Openvpn-devel] [PATCH applied] Re: Add unit tests for engine keys

2020-06-23 Thread Gert Doering
Hi, On Tue, Jun 23, 2020 at 12:32:42PM -0700, James Bottomley wrote: > > James, are you triggering on specific openvpn messages? "--enable- > > small" > > changes these (trimming some warnings and help texts). Can you test > > with > > "configure --enable-small", please? > > > >

Re: [Openvpn-devel] [PATCH applied] Re: Add unit tests for engine keys

2020-06-23 Thread James Bottomley
On Tue, 2020-06-23 at 21:26 +0200, Gert Doering wrote: > Hi, > > On Tue, Jun 23, 2020 at 08:47:33PM +0200, Gert Doering wrote: > > On Tue, Jun 23, 2020 at 11:36:49PM +0500, ?? > > wrote: > > > Also, I think we should out log.txt in case of failure. > > > > Indeed, this would

Re: [Openvpn-devel] [PATCH applied] Re: Add unit tests for engine keys

2020-06-23 Thread Gert Doering
Hi, On Tue, Jun 23, 2020 at 08:47:33PM +0200, Gert Doering wrote: > On Tue, Jun 23, 2020 at 11:36:49PM +0500, ?? wrote: > > Also, I think we should out log.txt in case of failure. > > Indeed, this would help. Yep. The "make distcheck" travis instance is now happy, but the

Re: [Openvpn-devel] [PATCH applied] Re: Add unit tests for engine keys

2020-06-23 Thread Gert Doering
Hi, On Tue, Jun 23, 2020 at 11:36:49PM +0500, ?? wrote: > Also, I think we should out log.txt in case of failure. Indeed, this would help. gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest

Re: [Openvpn-devel] [PATCH applied] Re: Add unit tests for engine keys

2020-06-23 Thread Илья Шипицин
вт, 23 июн. 2020 г. в 23:17, James Bottomley < james.bottom...@hansenpartnership.com>: > On Tue, 2020-06-23 at 21:43 +0500, Илья Шипицин wrote: > > as far as I understand, openssl-1.0.2 does not support engines ? > > No, it does. Engines were a pre 0.9.8 thing. I support openssl in my > builds

Re: [Openvpn-devel] [PATCH applied] Re: Add unit tests for engine keys

2020-06-23 Thread James Bottomley
On Tue, 2020-06-23 at 21:43 +0500, Илья Шипицин wrote: > as far as I understand, openssl-1.0.2 does not support engines ? No, it does. Engines were a pre 0.9.8 thing. I support openssl in my builds for the TPM engine down to 1.0.1 However, the failure: > Key mismatch not detected > > FAIL:

Re: [Openvpn-devel] [PATCH applied] Re: Add unit tests for engine keys

2020-06-23 Thread Gert Doering
Hi, On Tue, Jun 23, 2020 at 09:42:51PM +0500, ?? wrote: > apparently, it fails for some build on travis > https://travis-ci.org/github/OpenVPN/openvpn/jobs/701158156 This is the reason why James sent this new patch - what we have in master works but fails "make distcheck".

Re: [Openvpn-devel] [PATCH applied] Re: Add unit tests for engine keys

2020-06-23 Thread Илья Шипицин
as far as I understand, openssl-1.0.2 does not support engines ? вт, 23 июн. 2020 г. в 21:42, Илья Шипицин : > apparently, it fails for some build on travis > https://travis-ci.org/github/OpenVPN/openvpn/jobs/701158156 > > вт, 23 июн. 2020 г. в 18:07, James Bottomley < >

Re: [Openvpn-devel] [PATCH applied] Re: Add unit tests for engine keys

2020-06-23 Thread Илья Шипицин
apparently, it fails for some build on travis https://travis-ci.org/github/OpenVPN/openvpn/jobs/701158156 вт, 23 июн. 2020 г. в 18:07, James Bottomley < james.bottom...@hansenpartnership.com>: > On Tue, 2020-06-23 at 09:21 +0200, Gert Doering wrote: > > Hi, > > > > On Tue, Jun 23, 2020 at

Re: [Openvpn-devel] [PATCH applied] Re: Add unit tests for engine keys

2020-06-23 Thread James Bottomley
On Tue, 2020-06-23 at 09:21 +0200, Gert Doering wrote: > Hi, > > On Tue, Jun 23, 2020 at 08:28:36AM +0200, Gert Doering wrote: > > Acked-by: Gert Doering > > > > Tested on : > > - MacOS Mojave with OpenSSL 1.1.1c (brew) and out-of-tree build, > > works. > > - Linux with mbedtls (does not try

Re: [Openvpn-devel] [PATCH applied] Re: Add unit tests for engine keys

2020-06-23 Thread Gert Doering
Hi, On Tue, Jun 23, 2020 at 08:28:36AM +0200, Gert Doering wrote: > Acked-by: Gert Doering > > Tested on : > - MacOS Mojave with OpenSSL 1.1.1c (brew) and out-of-tree build, works. > - Linux with mbedtls (does not try engine tests, good :-) ) > - Linux with OpenSSL 1.1.1, works > - FreeBSD