Re: [Openvpn-devel] [PATCH applied] Re: wintun: add --windows-driver config option

[David Sommerseth]

On 12/11/2019 19:39, David Sommerseth wrote:
> On 09/11/2019 16:00, Gert Doering wrote:
>> Hi,
>>
>> On Sat, Nov 09, 2019 at 03:49:51PM +0100, Gert Doering wrote:
>>>  wintun: add --windows-driver config option
>>>
>>>  Signed-off-by: Lev Stipakov 
>>>  Acked-by: Simon Rozman 
>>
>> Ooops.  Misattributed the ACK, so this was really Steffan's ACK.
>>
>> I am not amending & re-pusing the commit.  This will call more confusion.
>>
>> Sorry.
> 
> Wise choice.  However you can use another little git feature ... git notes
> 
> 
> 
> Git notes does not change the commitish, but are more weakly tied to commits
> and does not have the same "change traceability" as commits does.  So I
> recommend to PGP sign notes (which might need to be handled outside git) if it
> important to ensure the note is unchanged.  But a note can be

Okay, lets complete that sentence ...

But a note can be removed without making it too obvious, so it's not a totally
secure extension to commit messages.  But it helps clarify things, especially
if the integrity of the note isn't critical.


-- 
kind regards,

David Sommerseth
OpenVPN Inc




signature.asc
Description: OpenPGP digital signature
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH applied] Re: wintun: add --windows-driver config option

[David Sommerseth]

On 09/11/2019 16:00, Gert Doering wrote:
> Hi,
> 
> On Sat, Nov 09, 2019 at 03:49:51PM +0100, Gert Doering wrote:
>>  wintun: add --windows-driver config option
>>
>>  Signed-off-by: Lev Stipakov 
>>  Acked-by: Simon Rozman 
> 
> Ooops.  Misattributed the ACK, so this was really Steffan's ACK.
> 
> I am not amending & re-pusing the commit.  This will call more confusion.
> 
> Sorry.

Wise choice.  However you can use another little git feature ... git notes



Git notes does not change the commitish, but are more weakly tied to commits
and does not have the same "change traceability" as commits does.  So I
recommend to PGP sign notes (which might need to be handled outside git) if it
important to ensure the note is unchanged.  But a note can be

AFAIK, it doesn't push or fetch notes by default, so that might need to be
handled separately, using:

$ git push  refs/notes/*

To fetch remote notes:

$ git fetch  refs/notes/*:refs/notes/*

We already have a few notes in our repo for similar situations or 
clarifications.


-- 
kind regards,

David Sommerseth
OpenVPN Inc




signature.asc
Description: OpenPGP digital signature
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH applied] Re: wintun: add --windows-driver config option

[Gert Doering]

Hi,

On Sat, Nov 09, 2019 at 03:49:51PM +0100, Gert Doering wrote:
>  wintun: add --windows-driver config option
> 
>  Signed-off-by: Lev Stipakov 
>  Acked-by: Simon Rozman 

Ooops.  Misattributed the ACK, so this was really Steffan's ACK.

I am not amending & re-pusing the commit.  This will call more confusion.

Sorry.

gert

-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
 Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany g...@greenie.muc.de


signature.asc
Description: PGP signature
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel