Hi,
On 24-09-16 17:54, Lev Stipakov wrote:
> Peer-id might change on restart and this should not trigger reopening
> tun.
>
> Trac #649
Feature-ACK.
The same holds for ncp stuff though, so I think we should do the same
for cipher, auth and keysize. Unless those change the tun-mtu, hmm...
That might need further investigation, so maybe keep that separate from
the peer-id issue.
> + char line[OPTION_PARM_SIZE];
> + while (buf_parse (&buf_orig, ',', line, sizeof (line)))
> + {
> + /* peer-id might change on restart and this should not
> trigger reopening tun */
> + if (strstr (line, "peer-id ") != line)
> + {
> + md_ctx_update (&c->c2.pulled_options_state, (const
> uint8_t *) line, strlen(line));
> + }
> + }
This looks like it should be a separate (static) function
'push_update_digest(state, msg)', or something like that.
> + md_ctx_cleanup (&c->c2.pulled_options_state);
Are you sure? I don't see a "- md_ctx_cleanup (...)" in the patch
for master (there is in 2.3 though). Do you fix a bug here, or is this
a cherry-picking mistake?
-Steffan
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
