Re: [Openvpn-devel] [PATCH v2 1/4] Only announce IV_NCP=2 when we are willing to support these ciphers

[Lev Stipakov]

To clarify - I am not arguing against config_ncp_ciphers in struct tls_options.

The only use of ncp_ciphers in context_1 is this:

   to.config_ncp_ciphers = c->c1.ncp_ciphers;

which can be changed to

  to.config_ncp_ciphers = options->ncp_ciphers;

which allows us to get rid of added "ncp_ciphers" in struct context_1.

-Lev


___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH v2 1/4] Only announce IV_NCP=2 when we are willing to support these ciphers

[Arne Schwabe]

Am 17.02.20 um 10:58 schrieb Lev Stipakov:
> Hi,
> 
> Since --ncp-ciphers are non-negotiable, why do we need
> to store it in context_1 at all? Cannot we use the value
> from struct options?

The push context do not have access to the options struct. Using options
directly would be massive refactoring. I want to avoid that for this
small patch.

Arne


___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH v2 1/4] Only announce IV_NCP=2 when we are willing to support these ciphers

[Lev Stipakov]

Hi,

Since --ncp-ciphers are non-negotiable, why do we need
to store it in context_1 at all? Cannot we use the value
from struct options?

This can be removed
> +c->c1.ncp_ciphers = c->options.ncp_ciphers;

This
> +to.config_ncp_ciphers = c->c1.ncp_ciphers;

can be changed to
> +to.config_ncp_ciphers = options->ncp_ciphers

Those are not needed:
> +dest->c1.ncp_ciphers = src->c1.ncp_ciphers;

> +const char *ncp_ciphers;/**< NCP Ciphers */

-Lev


___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel