Re: [OpenWrt-Devel] [PATCH V2] procd: simplify code in procd_inittab_run

2018-12-16 Thread John Crispin
On 09/12/2018 22:54, Michael Heimpold wrote: This is a trial to make it more obvious what the historically grown code is actually doing. Signed-off-by: Michael Heimpold --- V2: use Jo-Philipp Wich's proposal inittab.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff

Re: [OpenWrt-Devel] [PATCH] hotplug: Allow renaming phy devices.

2018-12-16 Thread John Crispin
I'd like to review your patch but it hits the ML as an attachment making it impossible. regardless, the subject is misleading, there are lots of phy types and i fail to understand why this is required.     John ___ openwrt-devel mailing list

Re: [OpenWrt-Devel] [PATCH v5 0/2] Allow sysupgrade restore on ER

2018-12-16 Thread John Crispin
On 06/12/2018 16:25, Jonathan Thibault wrote: This is a very simple patch that completes sysupgrade functionality on UBNT ER8. Default layout leaves about 128MB free on the kernel partition so there is plenty of space for temporary config backups. Hi Jonathan, the content of the patches is

Re: [OpenWrt-Devel] [PATCH] base-files:fix a bug when add led timer trigger

2018-12-16 Thread John Crispin
On 05/12/2018 07:05, robinson wrote: When I tried to add a led timer tirgger in "target/linux/ramips/base-files/ etc/board.d/01_leds" like below ucidef_set_led_timer "system" "system" "zhuotk:green:system" "1000" "1000" it will be failed to add value to "delayon" and "delayoff". This commit fix

Re: [OpenWrt-Devel] Broken packaging of modules (updating them) when using @lt or @gt

2018-12-16 Thread Yousong Zhou
On Mon, 17 Dec 2018 at 12:59, Rafał Miłecki wrote: > > On Sat, 15 Dec 2018 at 08:05, Yousong Zhou wrote: > > > > On Sat, 15 Dec 2018 at 06:00, Rafał Miłecki wrote: > > > > > > I've noticed a problem with kmod-phy-bcm-ns-usb2 defined in the > > > target/linux/bcm53xx/modules.mk > > > > > > Steps

Re: [OpenWrt-Devel] Broken packaging of modules (updating them) when using @lt or @gt

2018-12-16 Thread Rafał Miłecki
On Sat, 15 Dec 2018 at 08:05, Yousong Zhou wrote: > > On Sat, 15 Dec 2018 at 06:00, Rafał Miłecki wrote: > > > > I've noticed a problem with kmod-phy-bcm-ns-usb2 defined in the > > target/linux/bcm53xx/modules.mk > > > > Steps to reproduce: > > 1) Setup .config with: > > CONFIG_TARGET_bcm53xx >

Re: [OpenWrt-Devel] ath79: seting GPIO registers to specific values via DTS?

2018-12-16 Thread Chuanhong Guo
Hi! On Mon, Dec 17, 2018 at 7:43 AM Roger Pueyo Centelles | Guifi.net wrote: > > Hi Seb, > > You nailed it! :-) > > I was missing the ' "pinctrl-names = "default"; ' line. I must have > removed it from the .dts file I used as the source for mine at some > point. Then I just sorted the

Re: [OpenWrt-Devel] MIPS stack security and other problems

2018-12-16 Thread Rosen Penev
On Sun, Dec 16, 2018 at 4:54 PM Dave Taht wrote: > > > A pretty deep look at home MIPS and arm routers, and a surprising bug in > Linux/MIPS - by mudge and co: > > https://cyber-itl.org/2018/12/07/a-look-at-home-routers-and-linux-mips.html > > I have no idea if current openwrt, or what prior

[OpenWrt-Devel] MIPS stack security and other problems

2018-12-16 Thread Dave Taht
A pretty deep look at home MIPS and arm routers, and a surprising bug in Linux/MIPS - by mudge and co: https://cyber-itl.org/2018/12/07/a-look-at-home-routers-and-linux-mips.html I have no idea if current openwrt, or what prior releases... are subject to the problems they outline.

Re: [OpenWrt-Devel] ath79: seting GPIO registers to specific values via DTS?

2018-12-16 Thread Roger Pueyo Centelles | Guifi.net
Hi Seb, You nailed it! :-) I was missing the ' "pinctrl-names = "default"; ' line. I must have removed it from the .dts file I used as the source for mine at some point. Then I just sorted the pinctrl-0/1 issue, which I had already tried in any possible combination. After fixing this, I have

Re: [OpenWrt-Devel] ath79: seting GPIO registers to specific values via DTS?

2018-12-16 Thread Sebastian Kemper
On Sun, Dec 16, 2018 at 06:23:53PM +0100, Roger Pueyo Centelles | Guifi.net wrote: > > > Hi, Hello Roger! > [...] > >     leds { >     compatible = "gpio-leds"; >     pinctrl-1 = <_rssilow_pin _rssimediumhigh_pin > _rssihigh_pin>; > > [...] > > { >    

[OpenWrt-Devel] ath79: seting GPIO registers to specific values via DTS?

2018-12-16 Thread Roger Pueyo Centelles | Guifi.net
Hi, Some weeks ago I sent a PR adding ar71xx support for the Comfast CF-E110N [1], an outdoor 2,4 GHz router. Everything was working fine. A few days later I started working on adding ath79 support for the same device [2]. Almost everything worked, except for three GPIOs which I was not able to

Re: [OpenWrt-Devel] [PATCH v2] base-files: Fix netdev led trigger

2018-12-16 Thread Hannu Nyman
Thanks. The second version of the patch sets all three netdev trigger values properly. (tested by hand-editing the change to R7800) ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org

[OpenWrt-Devel] [PATCH v2] base-files: Fix netdev led trigger

2018-12-16 Thread Hauke Mehrtens
In the upstream netdev led trigger the one mode file was replaced by 3 files named rx, tx and link. Fix the netdev trigger configuration code to use the modified API. Fixes: aa3b6a08c56 ("kernel: Replace ledtrig-netdev with upstream backport") Signed-off-by: Hauke Mehrtens ---

Re: [OpenWrt-Devel] [PATCH] base-files: Fix netdev led trigger

2018-12-16 Thread Hannu Nyman
Based on editing the respective file manually in a live router, the patch fixes it partially: Now there is permanently lit wan led in R7800, but no blinking for wan activity. R7800 has the mode as "link tx rx", but the patch only does action for /sys/class/leds/r7800\:white\:wan/link ```

[OpenWrt-Devel] [PATCH] base-files: Fix netdev led trigger

2018-12-16 Thread Hauke Mehrtens
In the upstream netdev led trigger the one mode file was replaced by 3 files named rx, tx and link. Fix the netdev trigger configuration code to use the modified API. Fixes: aa3b6a08c56 ("kernel: Replace ledtrig-netdev with upstream backport") Signed-off-by: Hauke Mehrtens ---

[OpenWrt-Devel] [PATCH] treewide: dts: Remove default-state=off property from all gpio LED nodes

2018-12-16 Thread Petr Štetiar
From the Documentation/devicetree/bindings/leds/common.txt: - default-state : The initial state of the LED. Valid values are "on", "off", and "keep". If the LED is already on or off and the default-state property is set the to same value, then no glitch should be produced where the LED

Re: [OpenWrt-Devel] [PATCH 1/4] mvebu: add Turris Omnia LED support

2018-12-16 Thread Petr Štetiar
Klaus Kudielka [2018-12-16 09:52:27]: > Anyway, in the meantime I found a more recent discussion on linux-kernel > [1]. It still seems to circle around the interface. Thanks for the pointer. Well that discussion has happened in May, but that new LED pattern trigger code was added in October, I

Re: [OpenWrt-Devel] [PATCH 1/4] mvebu: add Turris Omnia LED support

2018-12-16 Thread Klaus Kudielka
On 15.12.18 21:32, Petr Štetiar wrote: I'm sorry, but I think, that this is not going to be that easy :-) Thanks for pointing that out after getting me in :-) Anyway, in the meantime I found a more recent discussion on linux-kernel [1]. It still seems to circle around the interface. I