Re: [OpenWrt-Devel] [PATCH 1/3] zynq: copy config from kernel 4.19 to 5.4

2020-03-13 Thread Luis Araneda
Hi, On Fri, Mar 13, 2020 at 9:34 AM Petr Štetiar wrote: > > Adrian Schmutzler [2020-03-13 13:17:42]: > > > I'm aware of the two-step procedure (1. copy without changes, 2. refresh), I > > just read the message in a way that the config was refreshed _before_ > > copying > > it? > > Yep, Luis

Re: [OpenWrt-Devel] [PATCH uhttpd] client: allow keep-alive for POST requests

2020-03-13 Thread Jo-Philipp Wich
Hi Wes, > That sounds ideal. Is this with or without the "[OpenWrt-Devel] [PATCH > ustream-ssl] ustream-openssl: clear error stack before SSL_read/SSL_write" > patch? it is including the error stack patch. Without it, I wasn't even able to fully load the page most of the time. Regards, Jo

Re: [OpenWrt-Devel] [PATCH] pkgconf: always retain -I and -L flags

2020-03-13 Thread Rosen Penev
On Fri, Mar 13, 2020 at 7:55 AM Jo-Philipp Wich wrote: > > The pkgconf fork filters -I and -L flag values from .pc files which match > pkgconf's builtin system directory value. > > During configure, pkgconf derives the default system include and library > search path values from exec_prefix,

Re: [OpenWrt-Devel] pkgconf issue with kmods and libelf [Was: Re: tools/pkg-config: Replace with pkgconf]

2020-03-13 Thread Rosen Penev
On Fri, Mar 13, 2020 at 7:33 AM Petr Štetiar wrote: > > Rosen Penev [2020-02-28 20:12:45]: > > Hi, > > > It's more portable and smaller. And as stated, it is still fairly active. > > Jo has today brought following issue to my attention: > > ## pkgconf > $ PATH=$(pwd)/staging_dir/host/bin:$PATH

Re: [OpenWrt-Devel] [PATCH 2/5] toolchain/gcc: make GCC9 by default for archs38

2020-03-13 Thread Evgeniy Didin
Also forgot to mention, that at GCC 8.4.0 it fails as well. I can try to find missing patches between 8.4.0 and 9.2.0 and add them. What should I better do? -Evgeniy From: openwrt-devel On Behalf Of Evgeniy Didin Sent: Friday, March 13, 2020 5:26 PM To: Hauke Mehrtens ;

Re: [OpenWrt-Devel] [PATCH] ath79: use downstream ag71xx for Kernel 5.4

2020-03-13 Thread David Bauer
Hello, On 3/13/20 1:29 PM, Petr Štetiar wrote: > Bjørn Mork [2020-03-13 09:29:49]: > >> David Bauer writes: >> >>> --- >>> a/target/linux/ath79/files-4.19/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c >>> +++ >>>

Re: [OpenWrt-Devel] [PATCH uhttpd] client: allow keep-alive for POST requests

2020-03-13 Thread Wes Turner
On Fri, Mar 13, 2020, 12:39 PM Jo-Philipp Wich wrote: > Hi Wes, > > > Are there *new* security implications of allowing keep-alive? > > I don't see any immediate concerns. You can trigger resource intensive > calls > via GET, HEAD, PATCH, PUT or DELETE as well, all of them were allowed for >

Re: [OpenWrt-Devel] [PATCH uhttpd] client: allow keep-alive for POST requests

2020-03-13 Thread Jo-Philipp Wich
Hi Wes, > Are there *new* security implications of allowing keep-alive? I don't see any immediate concerns. You can trigger resource intensive calls via GET, HEAD, PATCH, PUT or DELETE as well, all of them were allowed for keep-alive previously, only POST was filtered for unknown reasons. >

[OpenWrt-Devel] [PATCH 1/3] base-files: do not source system.sh in functions.sh

2020-03-13 Thread Adrian Schmutzler
The default_postinst() function in /lib/functions.sh sources /lib/functions/system.sh before cycling through uci-defaults files. This creates a pseudo-cyclic dependency as system.sh also uses functions that are located in functions.sh. Despite that, there is actually only one uci-defaults file in

[OpenWrt-Devel] [PATCH 2/3] base-files: source functions.sh in /lib/functions/system.sh

2020-03-13 Thread Adrian Schmutzler
The file /lib/functions/system.sh depends on find_mtd_index() and find_mtd_part() located in /lib/function.sh, so let's source that file. Signed-off-by: Adrian Schmutzler --- package/base-files/files/lib/functions/system.sh | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [OpenWrt-Devel] cyclic dependency for /lib/functions.sh and /lib/functions/system.sh in special case

2020-03-13 Thread Adrian Schmutzler
Hi, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On > Behalf Of mans0n > Sent: Freitag, 13. März 2020 14:35 > To: Adrian Schmutzler ; openwrt- > de...@lists.openwrt.org > Subject: Re: [OpenWrt-Devel] cyclic dependency for /lib/functions.sh

[OpenWrt-Devel] [PATCH 3/3] base-files: move find_mtd_chardev() to /lib/functions.sh

2020-03-13 Thread Adrian Schmutzler
While find_mtd_index() and find_mtd_part() are located in /lib/functions.sh, find_mtd_chardev() has been located in /lib/functions/system.sh. Move the latter to the former file to keep similar functions together. While at it, fix some corresponding includes. Signed-off-by: Adrian Schmutzler

Re: [OpenWrt-Devel] [PATCH uhttpd] client: allow keep-alive for POST requests

2020-03-13 Thread Wes Turner
Are there *new* security implications of allowing keep-alive? Slowloris DoS comes to mind: https://en.wikipedia.org/wiki/Slowloris_(computer_security) And the article mentions a number of tools. Older devices are likely somewhat trivially DoS-able without this patch; but maybe include a config

[OpenWrt-Devel] [PATCH] pkgconf: always retain -I and -L flags

2020-03-13 Thread Jo-Philipp Wich
The pkgconf fork filters -I and -L flag values from .pc files which match pkgconf's builtin system directory value. During configure, pkgconf derives the default system include and library search path values from exec_prefix, which is set to staging_dir/host in the host tool build phase. Due to

Re: [OpenWrt-Devel] [PATCH] .gitignore: ignore all .config* files

2020-03-13 Thread mans0n
On 2020-03-13 23:30, Adrian Schmutzler wrote: -Original Message- From: mans0n [mailto:man...@gorani.run] Sent: Freitag, 13. März 2020 14:26 To: Catrinel Catrinescu ; Adrian Schmutzler ; openwrt-devel@lists.openwrt.org Subject: Re: [OpenWrt-Devel] [PATCH] .gitignore: ignore all .config*

[OpenWrt-Devel] pkgconf issue with kmods and libelf [Was: Re: tools/pkg-config: Replace with pkgconf]

2020-03-13 Thread Petr Štetiar
Rosen Penev [2020-02-28 20:12:45]: Hi, > It's more portable and smaller. And as stated, it is still fairly active. Jo has today brought following issue to my attention: ## pkgconf $ PATH=$(pwd)/staging_dir/host/bin:$PATH STAGING_PREFIX=$(pwd)/staging_dir/host

Re: [OpenWrt-Devel] [PATCH] .gitignore: ignore all .config* files

2020-03-13 Thread Adrian Schmutzler
> -Original Message- > From: mans0n [mailto:man...@gorani.run] > Sent: Freitag, 13. März 2020 14:26 > To: Catrinel Catrinescu ; Adrian Schmutzler > ; openwrt-devel@lists.openwrt.org > Subject: Re: [OpenWrt-Devel] [PATCH] .gitignore: ignore all .config* files > > Hi, > > If we are going

Re: [OpenWrt-Devel] [PATCH 2/5] toolchain/gcc: make GCC9 by default for archs38

2020-03-13 Thread Evgeniy Didin
Hi Hauke, This problem reproduces only for ARC(ARM is ok) and Linux v5.4 (v4.19 is ok). Best regards, Evgeniy Didin From: Hauke Mehrtens Sent: Thursday, March 12, 2020 6:33 PM To: Evgeniy Didin ; openwrt-devel@lists.openwrt.org Cc: Alexey Brodkin ; Petr

Re: [OpenWrt-Devel] cyclic dependency for /lib/functions.sh and /lib/functions/system.sh in special case

2020-03-13 Thread mans0n
Hi Adrian, On 2020-03-13 03:38, mail at adrianschmutzler.de (Adrian Schmutzler) wrote: > Hi, > > I just wanted to source /lib/functions.sh in /lib/functions/system.sh > (base-files package), as several functions in the latter require the former and > it's annoying (and untidy) to have to

Re: [OpenWrt-Devel] [PATCH] .gitignore: ignore all .config* files

2020-03-13 Thread mans0n
Hi, If we are going to accept this patch, I would suggest "/.config.*" instead of "/.config*". That would suffice for all local usages. Thanks. On 2020-03-10 21:33, cc at 80211.de (Catrinel Catrinescu) wrote: Hi Adrian After successful testing, I always save the .config files, attaching

Re: [OpenWrt-Devel] [PATCH 1/3] zynq: copy config from kernel 4.19 to 5.4

2020-03-13 Thread Petr Štetiar
Adrian Schmutzler [2020-03-13 13:17:42]: > I'm aware of the two-step procedure (1. copy without changes, 2. refresh), I > just read the message in a way that the config was refreshed _before_ copying > it? Yep, Luis did exactly what he described in his commit description, he really refreshed

Re: [OpenWrt-Devel] [PATCH] ath79: use downstream ag71xx for Kernel 5.4

2020-03-13 Thread Petr Štetiar
Bjørn Mork [2020-03-13 09:29:49]: > David Bauer writes: > > > --- > > a/target/linux/ath79/files-4.19/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c > > +++ > > b/target/linux/ath79/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c > > @@ -1581,7 +1581,7 @@ static int

[OpenWrt-Devel] [PATCH uhttpd] client: allow keep-alive for POST requests

2020-03-13 Thread Jo-Philipp Wich
Allow POST requests via persistent connections to improve performance especially when using HTTPS on older devices. After this change, average page load times in LuCI improve significantly once the TLS connections are initiated. When testing an ar71xx 19.07.2 build on an ethernet connected

Re: [OpenWrt-Devel] [PATCH 1/3] zynq: copy config from kernel 4.19 to 5.4

2020-03-13 Thread Adrian Schmutzler
Hi Petr, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On > Behalf Of Petr Štetiar > Sent: Freitag, 13. März 2020 13:14 > To: Adrian Schmutzler > Cc: openwrt-devel@lists.openwrt.org; 'Luis Araneda' > Subject: Re: [OpenWrt-Devel] [PATCH 1/3]

Re: [OpenWrt-Devel] [PATCH 1/3] zynq: copy config from kernel 4.19 to 5.4

2020-03-13 Thread Petr Štetiar
Adrian Schmutzler [2020-03-13 13:02:10]: BTW, I've already accepted the series and I'm build testing/fixing it already[1]. > I do not see a change to kernel 4.19 config in this patch and why would you > refresh the old config before copying to the new kernel? Its common step to make review

Re: [OpenWrt-Devel] [PATCH 1/3] zynq: copy config from kernel 4.19 to 5.4

2020-03-13 Thread Adrian Schmutzler
> -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On > Behalf Of Luis Araneda > Sent: Freitag, 13. März 2020 04:23 > To: openwrt-devel@lists.openwrt.org > Cc: Luis Araneda > Subject: [OpenWrt-Devel] [PATCH 1/3] zynq: copy config from kernel 4.19

[OpenWrt-Devel] [PATCH ustream-ssl] ustream-openssl: clear error stack before SSL_read/SSL_write

2020-03-13 Thread Jo-Philipp Wich
The OpenSSL library uses a global error queue per thread which needs to be cleared prior to calling I/O functions in order to get reliable error results. Failure to do so will lead to stray errors reported by SSL_get_error() when an unrelated connection within the same thread encountered a TLS

Re: [OpenWrt-Devel] [PATCH] ath79: use downstream ag71xx for Kernel 5.4

2020-03-13 Thread Hauke Mehrtens
On 3/13/20 1:07 AM, David Bauer wrote: > The ag71xx driver from Linux 5.4 currently has various shortcomings > when used with OpenWrt compared to our downstream version. > > For example, the upstream driver does not support modifying the ethernet > clock and configuring RGMII delays on the MAC

Re: [OpenWrt-Devel] [PATCH] ath79: use downstream ag71xx for Kernel 5.4

2020-03-13 Thread Bjørn Mork
David Bauer writes: > --- > a/target/linux/ath79/files-4.19/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c > +++ > b/target/linux/ath79/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c > @@ -1581,7 +1581,7 @@ static int ag71xx_probe(struct platform_device *pdev) >